Alessandro/tests/UI (#199)

* Add pytest-qt dependency and enhance test coverage for UI components

* Add unit tests for various UI dialogs including actuator, AI model, FTP cameras, Telegram, and USB cameras

* Add installation step for QT dependencies in CI workflow

* Fix CI workflow to install missing QT dependencies and run tests with xvfb

* Remove USB cameras dialog tests

* Apply suggestion from @alessandropalla

* Fix formatting in test.yaml by removing trailing whitespace in dependency installation step

* Update requirements.txt to reflect changes in dependencies

* Update requirements.txt to include new dependencies

---------

Co-authored-by: Stefano Dell'Osa <stefano.dellosa@gmail.com>

Author: alessandropalla

.github/workflows/test.yaml

@@ -25,6 +25,10 @@ jobs:
         source .venv/bin/activate
         pip install --upgrade pip
         pip install -r requirements.txt
+    - name: Install QT dependencies
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y '^libxcb.*-dev' libx11-xcb-dev libglu1-mesa-dev libxrender-dev libxi-dev libxkbcommon-dev libxkbcommon-x11-dev libegl1 libxcb-cursor0 xvfb
     - name: Login to Hugging Face
       run: |
         source .venv/bin/activate
@@ -33,9 +37,9 @@ jobs:
     - name: Run tests
       run: |
         source .venv/bin/activate
-        python -m pytest test -sv --cov=. --cov-report=html
+        xvfb-run python -m pytest test -sv --cov=. --cov-report=html
         # To enforce minimum coverage, uncomment the following line:
-        # python -m pytest test -sv --cov=. --cov-report=html --cov-fail-under=80
+        # xvfb-run python -m pytest test -sv --cov=. --cov-report=html --cov-fail-under=80
     - name: Upload coverage report
       uses: actions/upload-artifact@v4
       with:

requirements.txt

@@ -1,2 +1,5 @@
 [flake8]
-max-line-length = 100
+max-line-length = 100
+
+[coverage:run]
+omit = test/*

setup.cfg

@@ -0,0 +1,37 @@
+# Ensure we can import from wadas
+import pathlib
+import sys
+from unittest.mock import MagicMock
+
+import pytest
+
+sys.path.append(str(pathlib.Path(__file__).parents[2]))
+
+from wadas.domain.notifier import Notifier  # # noqa: E402
+
+
+@pytest.fixture
+def mock_notifier_state(monkeypatch):
+    """Mock the global Notifier.notifiers dictionary."""
+    # Save original state
+    original_notifiers = Notifier.notifiers.copy()
+
+    # Reset for test
+    Notifier.notifiers = {
+        Notifier.NotifierTypes.EMAIL.value: None,
+        Notifier.NotifierTypes.TELEGRAM.value: None,
+        Notifier.NotifierTypes.WHATSAPP.value: None,
+    }
+
+    yield
+
+    # Restore original state
+    Notifier.notifiers = original_notifiers
+
+
+@pytest.fixture
+def mock_keyring(monkeypatch):
+    """Mock keyring to avoid system access."""
+    mock = MagicMock()
+    monkeypatch.setattr("wadas.ui.configure_email_dialog.keyring", mock)
+    return mock

test/ui/conftest.py

@@ -0,0 +1,98 @@
+from unittest.mock import patch
+
+import pytest
+from PySide6.QtWidgets import QComboBox, QDialogButtonBox, QLineEdit
+
+from wadas.domain.actuator import Actuator
+from wadas.domain.fastapi_actuator_server import FastAPIActuatorServer
+from wadas.ui.configure_actuators_dialog import DialogConfigureActuators
+
+
+@pytest.fixture
+def mock_actuator_state(monkeypatch):
+    """Mock Actuator and Server state."""
+    # Save original state
+    original_actuators = Actuator.actuators.copy()
+    original_server = FastAPIActuatorServer.actuator_server
+
+    # Reset
+    Actuator.actuators = []
+    FastAPIActuatorServer.actuator_server = None
+
+    yield
+
+    # Restore
+    Actuator.actuators = original_actuators
+    FastAPIActuatorServer.actuator_server = original_server
+
+
+def test_actuators_dialog_initial_state(qtbot, mock_actuator_state, mock_notifier_state):
+    """Test initial state of actuators dialog."""
+    dialog = DialogConfigureActuators()
+    qtbot.addWidget(dialog)
+
+    # Check default values
+    assert dialog.ui.lineEdit_server_ip.text() == "0.0.0.0"
+    assert dialog.ui.lineEdit_server_port.text() == "8443"
+
+    # Check buttons
+    assert dialog.ui.pushButton_stop_server.isEnabled() is False
+    assert dialog.ui.buttonBox.button(QDialogButtonBox.Ok).isEnabled() is False
+
+
+def test_actuators_dialog_add_actuator(qtbot, mock_actuator_state, mock_notifier_state):
+    """Test adding an actuator row."""
+    dialog = DialogConfigureActuators()
+    qtbot.addWidget(dialog)
+
+    # Initially one row is added by __init__
+    # grid = dialog.findChild(QGridLayout, "gridLayout_actuators")
+    # We can't easily count rows in QGridLayout, but we can check if widgets exist
+    # Row 0 should exist
+    assert dialog.findChild(QComboBox, "comboBox_actuator_type_0") is not None
+
+    # Add another actuator
+    dialog.ui.pushButton_add_actuator.click()
+
+    # Row 1 should exist
+    assert dialog.findChild(QComboBox, "comboBox_actuator_type_1") is not None
+
+
+def test_actuators_dialog_validation(qtbot, mock_actuator_state, mock_notifier_state):
+    """Test validation logic enables OK button."""
+    dialog = DialogConfigureActuators()
+    qtbot.addWidget(dialog)
+
+    # Fill valid server info
+    dialog.ui.lineEdit_server_ip.setText("127.0.0.1")
+    dialog.ui.lineEdit_server_port.setText("8080")
+    dialog.ui.lineEdit_actuator_timeout.setText("10")
+
+    # Fill actuator info (row 0)
+    # We need to find the widgets dynamically created
+    # Based on code: lineEdit_actuator_id_{row}
+    id_edit = dialog.findChild(QLineEdit, "lineEdit_actuator_id_0")
+
+    # Ensure widgets are visible and active before interaction
+    dialog.show()
+    # qtbot.waitForWindowShown(dialog) # Deprecated
+
+    # Mock file existence for SSL key/cert
+    with patch("os.path.isfile", return_value=True):
+        # Set valid file paths (mocked)
+        dialog.ui.label_key_file.setText("key.pem")
+        dialog.ui.label_cert_file.setText("cert.pem")
+
+        # Set ID
+        id_edit.setText("Actuator1")
+
+        # Trigger validation
+        dialog.validate()
+
+        # Check if OK button is enabled
+        assert dialog.ui.buttonBox.button(QDialogButtonBox.Ok).isEnabled() is True
+
+    # Check if OK button is enabled
+    # Note: validation might require more fields or specific conditions
+    # Let's check the validate method in code if possible, or just assert
+    assert dialog.ui.buttonBox.button(QDialogButtonBox.Ok).isEnabled() is True

test/ui/test_configure_actuators_dialog.py

@@ -0,0 +1,83 @@
+from unittest.mock import MagicMock
+
+import pytest
+from PySide6.QtWidgets import QDialogButtonBox
+
+from wadas.domain.ai_model import AiModel
+from wadas.ui.configure_ai_model_dialog import ConfigureAiModel
+
+
+@pytest.fixture
+def mock_ai_model_state(monkeypatch):
+    """Mock AiModel state."""
+    # Mock class attributes
+    monkeypatch.setattr(AiModel, "classification_threshold", 0.5)
+    monkeypatch.setattr(AiModel, "detection_threshold", 0.5)
+    monkeypatch.setattr(AiModel, "video_fps", 1)
+    monkeypatch.setattr(AiModel, "tunnel_mode_detection_threshold", 0.5)
+    monkeypatch.setattr(AiModel, "language", "en")
+    monkeypatch.setattr(AiModel, "detection_device", "auto")
+    monkeypatch.setattr(AiModel, "classification_device", "auto")
+    monkeypatch.setattr(AiModel, "classification_model_version", "DFv1.2")
+
+    # Mock txt_animalclasses
+    mock_classes = {"DFv1.2": ["en", "it"]}
+    monkeypatch.setattr("wadas.ui.configure_ai_model_dialog.txt_animalclasses", mock_classes)
+
+    # Mock openvino
+    mock_ov = MagicMock()
+    mock_ov.Core.return_value.get_available_devices.return_value = ["CPU", "GPU"]
+    monkeypatch.setattr("wadas.ui.configure_ai_model_dialog.ov", mock_ov)
+
+
+def test_ai_model_dialog_initial_state(qtbot, mock_ai_model_state, mock_notifier_state):
+    """Test initial state of AI model dialog."""
+    dialog = ConfigureAiModel()
+    qtbot.addWidget(dialog)
+
+    # Check default values
+    assert dialog.ui.lineEdit_classificationThreshold.text() == "0.5"
+    assert dialog.ui.lineEdit_detectionThreshold.text() == "0.5"
+    assert dialog.ui.lineEdit_video_fps.text() == "1"
+
+    # Check dropdowns
+    assert dialog.ui.comboBox_class_lang.currentText() == "en"
+    assert dialog.ui.comboBox_detection_dev.currentText() == "auto"
+
+    # OK button should be enabled if data is valid (default data is valid)
+    assert dialog.ui.buttonBox.button(QDialogButtonBox.Ok).isEnabled() is True
+
+
+def test_ai_model_dialog_validation(qtbot, mock_ai_model_state, mock_notifier_state):
+    """Test validation logic."""
+    dialog = ConfigureAiModel()
+    qtbot.addWidget(dialog)
+
+    # Invalid threshold
+    dialog.ui.lineEdit_classificationThreshold.setText("1.5")
+    assert dialog.ui.buttonBox.button(QDialogButtonBox.Ok).isEnabled() is False
+
+    # Valid threshold
+    dialog.ui.lineEdit_classificationThreshold.setText("0.8")
+    assert dialog.ui.buttonBox.button(QDialogButtonBox.Ok).isEnabled() is True
+
+    # Invalid FPS
+    dialog.ui.lineEdit_video_fps.setText("-1")
+    assert dialog.ui.buttonBox.button(QDialogButtonBox.Ok).isEnabled() is False
+
+
+def test_ai_model_dialog_save(qtbot, mock_ai_model_state, mock_notifier_state):
+    """Test saving configuration."""
+    dialog = ConfigureAiModel()
+    qtbot.addWidget(dialog)
+
+    # Change values
+    dialog.ui.lineEdit_classificationThreshold.setText("0.7")
+    dialog.ui.comboBox_class_lang.setCurrentText("it")
+
+    # Accept
+    dialog.accept_and_close()
+
+    # Verify AiModel updated
+    assert AiModel.classification_threshold == 0.7
+    assert AiModel.language == "it"

test/ui/test_configure_ai_model_dialog.py

@@ -0,0 +1,78 @@
+from PySide6.QtWidgets import QDialogButtonBox
+
+from wadas.domain.email_notifier import EmailNotifier
+from wadas.domain.notifier import Notifier
+from wadas.ui.configure_email_dialog import DialogInsertEmail
+
+
+def test_email_dialog_initial_state(qtbot, mock_notifier_state, mock_keyring):
+    """Test that the dialog initializes correctly with empty state."""
+    dialog = DialogInsertEmail()
+    qtbot.addWidget(dialog)
+
+    # Check initial state
+    assert dialog.ui.buttonBox.button(QDialogButtonBox.Ok).isEnabled() is False
+    assert dialog.ui.pushButton_testEmail.isEnabled() is False
+    assert dialog.ui.checkBox_email_en.isChecked() is True
+
+
+def test_email_dialog_validation(qtbot, mock_notifier_state, mock_keyring):
+    """Test that the OK button is enabled only when all fields are valid."""
+    dialog = DialogInsertEmail()
+    qtbot.addWidget(dialog)
+
+    # Simulate typing valid data
+    qtbot.keyClicks(dialog.ui.lineEdit_senderEmail, "sender@example.com")
+    qtbot.keyClicks(dialog.ui.lineEdit_smtpServer, "smtp.example.com")
+    qtbot.keyClicks(dialog.ui.lineEdit_port, "587")
+    qtbot.keyClicks(dialog.ui.lineEdit_password, "password123")
+
+    # Recipient email is a TextEdit, keyClicks might be slow or tricky,
+    # use setText for simplicity or keyClicks if needed
+    # dialog.ui.textEdit_recipient_email.setText("recipient@example.com")
+    # But to trigger textChanged, we might need to simulate input or call
+    # the slot manually if setText doesn't trigger it.
+    # PySide6 setText usually triggers signals? No, usually not for QLineEdit/QTextEdit.
+    # Let's use keyClicks for a short string.
+    qtbot.keyClicks(dialog.ui.textEdit_recipient_email, "recipient@example.com")
+
+    # Check if OK button is enabled
+    # Note: The validation logic in the dialog seems to rely on individual validators setting flags
+    # and then calling check_enable_ok_button (implied).
+    # Let's verify if the button is enabled.
+    assert dialog.ui.buttonBox.button(QDialogButtonBox.Ok).isEnabled() is True
+
+
+def test_email_dialog_save(qtbot, mock_notifier_state, mock_keyring):
+    """Test that accepting the dialog saves the configuration."""
+    dialog = DialogInsertEmail()
+    qtbot.addWidget(dialog)
+
+    # Fill data
+    dialog.ui.lineEdit_senderEmail.setText("sender@example.com")
+    dialog.ui.lineEdit_smtpServer.setText("smtp.example.com")
+    dialog.ui.lineEdit_port.setText("587")
+    dialog.ui.lineEdit_password.setText("password123")
+    dialog.ui.textEdit_recipient_email.setText("recipient@example.com")
+
+    # Manually trigger validation because setText doesn't always
+    # trigger textChanged signals in tests or we can just call the
+    # validation methods directly if we want to be sure,
+    # but better to simulate user interaction if possible.
+    # However, for saving, we just need the data to be there when accept_and_close is called.
+    # The accept_and_close method reads from the UI elements.
+
+    # We need to make sure the internal flags are set if accept_and_close checks them?
+    # Looking at the code: accept_and_close reads text() from widgets.
+    # It creates EmailNotifier.
+
+    # Trigger accept
+    dialog.accept_and_close()
+
+    # Check if Notifier was updated
+    email_notifier = Notifier.notifiers[Notifier.NotifierTypes.EMAIL.value]
+    assert isinstance(email_notifier, EmailNotifier)
+    assert email_notifier.sender_email == "sender@example.com"
+    assert email_notifier.smtp_hostname == "smtp.example.com"
+    assert email_notifier.smtp_port == "587"
+    assert "recipient@example.com" in email_notifier.recipients_email