Merge pull request graphiti-api#53 from richmolj/master

Add around_persistence

Author: richmolj

lib/graphiti/resource/persistence.rb

@@ -44,6 +44,14 @@ def around_save(method = nil, only: [:create, :update], &blk)
           end
         end
 
+        def around_persistence(method = nil, only: [:create, :update], &blk)
+          if blk
+            raise Errors::AroundCallbackProc.new(self, 'around_persistence')
+          else
+            add_callback(:persistence, :around, method, only, &blk)
+          end
+        end
+
         def around_destroy(method = nil, &blk)
           if blk
             raise Errors::AroundCallbackProc.new(self, 'around_destroy')
@@ -64,31 +72,35 @@ def add_callback(kind, lifecycle, method = nil, only, &blk)
       def create(create_params)
         model_instance = nil
 
-        run_callbacks :attributes, :create, create_params do |params|
-          model_instance = build(model)
-          assign_attributes(model_instance, params)
-          model_instance
-        end
+        run_callbacks :persistence, :create, create_params do
+          run_callbacks :attributes, :create, create_params do |params|
+            model_instance = build(model)
+            assign_attributes(model_instance, params)
+            model_instance
+          end
 
-        run_callbacks :save, :create, model_instance do
-          model_instance = save(model_instance)
-        end
+          run_callbacks :save, :create, model_instance do
+            model_instance = save(model_instance)
+          end
 
-        model_instance
+          model_instance
+        end
       end
 
       def update(update_params)
         model_instance = nil
         id = update_params.delete(:id)
 
-        run_callbacks :attributes, :update, update_params do |params|
-          model_instance = self.class._find(params.merge(id: id)).data
-          assign_attributes(model_instance, params)
-          model_instance
-        end
+        run_callbacks :persistence, :update, update_params do
+          run_callbacks :attributes, :update, update_params do |params|
+            model_instance = self.class._find(params.merge(id: id)).data
+            assign_attributes(model_instance, params)
+            model_instance
+          end
 
-        run_callbacks :save, :update, model_instance do
-          model_instance = save(model_instance)
+          run_callbacks :save, :update, model_instance do
+            model_instance = save(model_instance)
+          end
         end
 
         model_instance

spec/persistence_spec.rb

@@ -532,6 +532,83 @@ def do_after_save(model)
       end
     end
 
+    describe '.around_persistence' do
+      RSpec.shared_examples 'around persistence' do |opts|
+        opts ||= {}
+
+        before do
+          klass.class_eval do
+            before_attributes do |attrs|
+              attrs[:first_name] = "#{attrs[:first_name]}mid"
+            end
+
+            def do_around_persistence(attributes)
+              attributes[:first_name] = 'b4'
+              model = yield
+              model.update_attributes(first_name: "#{model.first_name}after")
+              model
+              1 # return value shouldnt matter
+            end
+          end
+        end
+
+        if opts[:only_update]
+          context 'when creating' do
+            include_context 'create hooks'
+
+            it 'does not fire' do
+              employee
+              expect(klass.calls.length).to eq(0)
+            end
+          end
+        else
+          context 'when creating' do
+            include_context 'create hooks'
+
+            it 'can modify attributes and the saved model' do
+              reloaded = PORO::Employee.find(employee.id)
+              expect(reloaded.first_name).to eq('b4midafter')
+            end
+          end
+        end
+
+        context 'when updating' do
+          include_context 'update hooks'
+
+          it 'can modify attributes and the saved model' do
+            reloaded = PORO::Employee.find(employee.id)
+            expect(reloaded.first_name).to eq('b4midafter')
+          end
+        end
+      end
+
+      context 'when registering via method' do
+        before do
+          klass.around_persistence :do_around_persistence
+        end
+
+        include_examples 'around persistence'
+      end
+
+      context 'when registering via proc' do
+        it 'raises error' do
+          expect {
+            klass.around_persistence do
+              'dontgethere'
+            end
+          }.to raise_error(Graphiti::Errors::AroundCallbackProc, /around_persistence/)
+        end
+      end
+
+      context 'when limiting actions' do
+        before do
+          klass.around_persistence :do_around_persistence, only: [:update]
+        end
+
+        include_examples 'around persistence', only_update: true
+      end
+    end
+
     describe '.around_save' do
       RSpec.shared_examples 'around save' do |opts|
         opts ||= {}