Fix navigate-to-source for generic types

Author: waf

CSharpRepl.Services/SymbolExploration/SymbolExplorer.cs

@@ -77,7 +77,7 @@ public async Task<SymbolResult> LookupSymbolAtPosition(string text, int position
             .Select(t => assemblyReader.GetTypeDefinition(t))
             .FirstOrDefault(t =>
                 assemblyReader.GetString(t.Namespace) == symbolAtPosition.ContainingNamespace.ToDisplayString()
-                && assemblyReader.GetString(t.Name) == (symbolAtPosition.ContainingType?.Name ?? symbolAtPosition.Name)
+                && assemblyReader.GetString(t.Name) == (symbolAtPosition.ContainingType?.Name ?? symbolAtPosition.MetadataName)
             );
 
         using var debugSymbolLoader = new DebugSymbolLoader(assemblyFilePath);
@@ -163,6 +163,15 @@ orderby node.Span.Length
             m => m
         );
 
+    private static SequencePointRange? FindConstructor(MetadataReader symbolReader, MetadataReader assemblyReader, TypeDefinition type, IMethodSymbol method) =>
+        FindSequencePoint(
+            symbolReader,
+            type.GetMethods(),
+            m => assemblyReader.GetMethodDefinition(m),
+            m => assemblyReader.GetString(m.Name) == method.Name,
+            m => m
+        );
+
     private static SequencePointRange? FindProperty(MetadataReader symbolReader, MetadataReader assemblyReader, TypeDefinition type, IPropertySymbol method) =>
         FindSequencePoint(
             symbolReader,

CSharpRepl.Tests/SymbolExplorerTests.cs

@@ -42,6 +42,16 @@ public async Task GetSymbolAtIndex_ClassInSourceLinkedAssembly_ReturnsSourceLink
         Assert.EndsWith("Console.cs", symbol.Url);
     }
 
+    [Fact]
+    public async Task GetGenericSymbolAtIndex_ClassInSourceLinkedAssembly_ReturnsSourceLinkUrl()
+    {
+        // should return a string like https://www.github.com/dotnet/runtime/blob/208e377a5329ad6eb1db5e5fb9d4590fa50beadd/src/libraries/System.Console/src/System/Console.cs
+        var symbol = await services.GetSymbolAtIndexAsync(@"List<string>", "Li".Length);
+
+        Assert.StartsWith("https://www.github.com/dotnet/runtime/", symbol.Url);
+        Assert.EndsWith("List.cs", symbol.Url);
+    }
+
     [Fact]
     public async Task GetSymbolAtIndex_MethodInSourceLinkedAssembly_ReturnsSourceLinkUrl()
     {