Feat: faq api 테스트 코드 구현 (#102)

- faq 테스트 코드를 작성했습니다
- faq api에서 QuestionNowFoundException를 QuestionNotFoundException로 바꿨습니다
- faq 생성 api에서 Service 레이어에 request를 넘겨주는 것으로 수정했습니다

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* Bug Fixes
* Ensured FAQ “question not found” responses consistently return 404
with a clear message.

* Refactor
* Streamlined FAQ creation flow to improve consistency and
maintainability.

* Tests
* Added comprehensive tests covering FAQ create, read, update, and
delete scenarios.
  * Updated sponsor tests to support and verify partial updates.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: deveroskp

wacruit/src/apps/faq/exceptions.py

@@ -1,6 +1,6 @@
 from wacruit.src.apps.common.exceptions import WacruitException
 
 
-class QuestionNowFoundException(WacruitException):
+class QuestionNotFoundException(WacruitException):
     def __init__(self):
         super().__init__(status_code=404, detail="존재하지 않는 질문입니다.")

wacruit/src/apps/faq/services.py

@@ -2,9 +2,10 @@
 
 from fastapi import Depends
 
-from wacruit.src.apps.faq.exceptions import QuestionNowFoundException
+from wacruit.src.apps.faq.exceptions import QuestionNotFoundException
 from wacruit.src.apps.faq.models import FAQ
 from wacruit.src.apps.faq.repositories import QuestionRepository
+from wacruit.src.apps.faq.schemas import CreateQuestionRequest
 from wacruit.src.apps.faq.schemas import UpdateQuestionRequest
 
 
@@ -15,10 +16,11 @@ def __init__(self, question_repository: Annotated[QuestionRepository, Depends()]
     def get_question_by_id(self, questions_id: int) -> FAQ:
         question = self.question_repository.get_question_by_id(questions_id)
         if question is None:
-            raise QuestionNowFoundException
+            raise QuestionNotFoundException
         return question
 
-    def create_question(self, question: FAQ) -> FAQ:
+    def create_question(self, request: CreateQuestionRequest) -> FAQ:
+        question = FAQ(question=request.question, answer=request.answer)
         return self.question_repository.create_questions(question)
 
     def get_questions(self) -> list[FAQ]:

wacruit/src/apps/faq/views.py

@@ -34,9 +34,7 @@ def create_question(
     request: CreateQuestionRequest,
     question_service: Annotated[QuestionService, Depends()],
 ) -> QuestionResponse:
-    res = question_service.create_question(
-        FAQ(question=request.question, answer=request.answer)
-    )
+    res = question_service.create_question(request)
 
     return QuestionResponse.from_orm(res)
 

wacruit/src/tests/faq/conftest.py

@@ -0,0 +1,64 @@
+from typing import List
+
+import pytest
+from sqlalchemy.orm import Session
+
+from wacruit.src.apps.faq.models import FAQ
+from wacruit.src.apps.faq.repositories import QuestionRepository
+from wacruit.src.apps.faq.schemas import CreateQuestionRequest
+from wacruit.src.apps.faq.schemas import UpdateQuestionRequest
+from wacruit.src.apps.faq.services import QuestionService
+from wacruit.src.database.connection import Transaction
+
+
+@pytest.fixture
+def created_question(db_session: Session) -> FAQ:
+    question = FAQ(
+        question="개발 경험이 없는데 지원 가능한가요?",
+        answer="개발을 처음 접하시는 분들도 물론 준회원(Rookies)으로 지원 가능합니다! \
+            와플스튜디오에서 제공하는 세미나를 통해 지식과 협업 경험을 쌓으실 수 있습니다.",
+    )
+    db_session.add(question)
+    db_session.commit()
+    return question
+
+
+@pytest.fixture
+def created_questions(db_session: Session) -> List[FAQ]:
+    question1 = FAQ(
+        question="개발 경험이 없는데 지원 가능한가요?",
+        answer="개발을 처음 접하시는 분들도 물론 준회원(Rookies)으로 지원 가능합니다! \
+            와플스튜디오에서 제공하는 세미나를 통해 지식과 협업 경험을 쌓으실 수 있습니다.",
+    )
+    question2 = FAQ(
+        question="저학번/고학번/졸업생인데 지원해도 되나요?",
+        answer="와플스튜디오는 서울대학교에 재학중이거나 졸업했던 누구나, 나이 제한 없이 가입 가능합니다. \
+            다양한 학번으로 구성되어 있어 학번 및 졸업 여부와 상관 없이 지원 가능하니 부담 가지지 말고 지원해주세요!",
+    )
+    db_session.add_all([question1, question2])
+    db_session.commit()
+    return [question1, question2]
+
+
+@pytest.fixture
+def create_question_dto() -> CreateQuestionRequest:
+    return CreateQuestionRequest(
+        question="개발 경험이 없는데 지원 가능한가요?",
+        answer="개발을 처음 접하시는 분들도 물론 준회원(Rookies)으로 지원 가능합니다! \
+            와플스튜디오에서 제공하는 세미나를 통해 지식과 협업 경험을 쌓으실 수 있습니다.",
+    )
+
+
+@pytest.fixture
+def update_question_dto() -> UpdateQuestionRequest:
+    return UpdateQuestionRequest(answer="답변 수정")
+
+
+@pytest.fixture
+def question_service(question_repository: QuestionRepository) -> QuestionService:
+    return QuestionService(question_repository=question_repository)
+
+
+@pytest.fixture
+def question_repository(db_session: Session) -> QuestionRepository:
+    return QuestionRepository(session=db_session, transaction=Transaction(db_session))

wacruit/src/tests/faq/test_faq_service.py

@@ -0,0 +1,60 @@
+from typing import List
+
+import pytest
+
+from wacruit.src.apps.faq.exceptions import QuestionNotFoundException
+from wacruit.src.apps.faq.models import FAQ
+from wacruit.src.apps.faq.schemas import CreateQuestionRequest
+from wacruit.src.apps.faq.schemas import UpdateQuestionRequest
+from wacruit.src.apps.faq.services import QuestionService
+
+
+def test_create_question(
+    question_service: QuestionService, create_question_dto: CreateQuestionRequest
+):
+    created_question = question_service.create_question(create_question_dto)
+    assert created_question.id is not None
+    assert created_question.question == create_question_dto.question
+    assert created_question.answer == create_question_dto.answer
+
+
+def test_update_question(
+    question_service: QuestionService,
+    created_question: FAQ,
+    update_question_dto: UpdateQuestionRequest,
+):
+    question_id = created_question.id
+    updated_question = question_service.update_question(
+        question_id, update_question_dto
+    )
+    assert updated_question.id == question_id
+    if update_question_dto.question is not None:
+        assert updated_question.question == update_question_dto.question
+    if update_question_dto.answer is not None:
+        assert updated_question.answer == update_question_dto.answer
+
+
+def test_get_questions(question_service: QuestionService, created_questions: list[FAQ]):
+    questions = question_service.get_questions()
+    assert len(questions) == len(created_questions)
+
+    for got, exp in zip(questions, created_questions):
+        assert got.id == exp.id
+        assert got.question == exp.question
+        assert got.answer == exp.answer
+
+
+def test_delete_question(question_service: QuestionService, created_question: FAQ):
+    question_id = created_question.id
+    question_service.delete_question(question_id)
+    with pytest.raises(QuestionNotFoundException):
+        question_service.get_question_by_id(question_id)
+
+
+def test_delete_question_twice(
+    question_service: QuestionService, created_question: FAQ
+):
+    question_id = created_question.id
+    question_service.delete_question(question_id)
+    with pytest.raises(QuestionNotFoundException):
+        question_service.delete_question(question_id)

wacruit/src/tests/sponsor/test_sponsor_service.py

@@ -64,6 +64,9 @@ def test_update_sponsor(
     sponsor = sponsor_service.create_sponsor(sponsor_create_dto)
     assert sponsor.id is not None
     updated_sponsor = sponsor_service.update_sponsor(sponsor.id, sponsor_update_dto)
-    assert updated_sponsor.amount == sponsor_update_dto.amount
-    assert updated_sponsor.email == sponsor_update_dto.email
-    assert updated_sponsor.phone_number == sponsor_update_dto.phone_number
+    if sponsor_update_dto.email is not None:
+        assert updated_sponsor.email == sponsor_update_dto.email
+    if sponsor_update_dto.amount is not None:
+        assert updated_sponsor.amount == sponsor_update_dto.amount
+    if sponsor_update_dto.phone_number is not None:
+        assert updated_sponsor.phone_number == sponsor_update_dto.phone_number