Skip to content

Commit c33697a

Browse files
authored
Fix: Review Response에 멤버 기수 포함 (#105)
- review를 불러오는 api에서 멤버의 기수를 불러오도록 수정하였습니다.
1 parent 664238e commit c33697a

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

wacruit/src/apps/review/schemas.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ class ReviewResponse(BaseModel):
1616
member_id: int
1717
member_first_name: str
1818
member_last_name: str
19+
member_generation: str
1920
member_position: Position | None
2021
is_active: bool
2122

wacruit/src/apps/review/services.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ def get_review(self, review_id: int):
4444
member_id=review.member_id,
4545
member_first_name=writer.first_name,
4646
member_last_name=writer.last_name,
47+
member_generation=writer.generation,
4748
member_position=writer.position if writer.position else None,
4849
is_active=writer.is_active,
4950
)
@@ -62,6 +63,7 @@ def get_reviews(
6263
member_id=review.member_id,
6364
member_first_name=review.member.first_name,
6465
member_last_name=review.member.last_name,
66+
member_generation=review.member.generation,
6567
member_position=review.member.position
6668
if review.member.position
6769
else None,
@@ -101,6 +103,7 @@ def update_review(
101103
member_id=updated_review.member_id,
102104
member_first_name=updated_review.member.first_name,
103105
member_last_name=updated_review.member.last_name,
106+
member_generation=updated_review.member.generation,
104107
member_position=updated_review.member.position
105108
if updated_review.member.position
106109
else None,

0 commit comments

Comments
 (0)