Skip to content

Commit 62a7350

Browse files
authored
Fix Renovate schedule and stale documentation paths; complete unused.mjs triage (#54)
* Fix Renovate schedule and stale documentation paths * Populate src/unused.mjs with rules declined in Stylelint 17 upgrade
1 parent 1250484 commit 62a7350

5 files changed

Lines changed: 106 additions & 6 deletions

File tree

.agents/skills/upgrading-shared-stylelint-config/SKILL.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ Note any warnings or errors from npm or from the project’s QA tools. Those mig
148148
This is crucial for the success of the upgrade, and we have bespoke tools to facilitate this.
149149

150150
- [ ] Use `npm run test:rules` to determine which new rules have been introduced.
151-
- [ ] Update `src/unused.js`, making sure to add any new rules in the correct section (look at the guidance inside the file).
151+
- [ ] Update `src/unused.mjs`, making sure to add any new rules in the correct section (look at the guidance inside the file).
152152
- [ ] If in doubt, move the rules to a new section inside the `toReview` array so this can be further reviewed at a later date.
153153
- [ ] Use `npm run test -- -u` to update the project’s snapshots. This is crucial to understand which rule changes will affect users of this project.
154154

@@ -183,9 +183,9 @@ The configuration now mandates stylelint v<version>. {Add commentary about the m
183183

184184
For the key rules sections,
185185

186-
- [ ] Populate "New rules configuration" for newly-introduced rules, which will show as additions in the git diff of `src/__snapshots__/semver.test.js.snap`.
187-
- [ ] Populate "New rules configuration" for config changes on existing rules, which will show as additions + deletions inside `src/__snapshots__/semver.test.js.snap`.
188-
- [ ] Populate "New unused rules" based on the changes in the diff of `src/unused.js`.
186+
- [ ] Populate "New rules configuration" for newly-introduced rules, which will show as additions in the git diff of `src/__snapshots__/semver.test.mjs.snap`.
187+
- [ ] Populate "New rules configuration" for config changes on existing rules, which will show as additions + deletions inside `src/__snapshots__/semver.test.mjs.snap`.
188+
- [ ] Populate "New unused rules" based on the changes in the diff of `src/unused.mjs`.
189189

190190
### Update documentation
191191

.github/renovate.jsonc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
// Silently merge updates without PRs
2525
"automergeType": "branch",
2626
// https://renovatebot.com/docs/configuration-options/#schedule
27-
"schedule": ["every weekend"],
27+
"schedule": ["* * 3,22 * *"],
2828
// https://docs.renovatebot.com/configuration-options/#minimumreleaseage
2929
"minimumReleaseAge": "7 days",
3030
// Limit the number of consecutive PRs

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1414
- Enable type-aware linting with type checking in `vp lint` and `vp check`.
1515
- Update the development and testing Node.js version to 26 (was 24), refreshing `package-lock.json`.
1616
- Pick up `stylelint-config-recommended-scss` 17.0.1 through the lockfile refresh, where `no-invalid-position-declaration` ignores declarations inside `@mixin` at-rules.
17+
- Complete the `src/unused.mjs` triage with the rules declined in the Stylelint 17 upgrade, so `npm run test:rules` passes again.
1718

1819
## [2.0.0](https://github.com/wagtail/stylelint-config-wagtail/releases/tag/2.0.0) - 2026-04-23
1920

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ To get the most out of this config, it is assumed that projects have the followi
124124
125125
## What’s included
126126
127-
> See [`config.js`](./config.js) for the config definition. This package includes configuration from:
127+
> See [`index.js`](./index.js) for the config definition. This package includes configuration from:
128128
>
129129
> - [stylelint-config-recommended-scss](https://github.com/stylelint-scss/stylelint-config-recommended-scss)
130130
> - [`stylelint-order`](https://github.com/hudochenkov/stylelint-order)

src/unused.mjs

Lines changed: 99 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,105 @@ const toReviewUpgrades = {
6262
upgrade17: {
6363
'display-notation':
6464
'https://stylelint.io/user-guide/rules/display-notation',
65+
'alpha-value-notation':
66+
'https://stylelint.io/user-guide/rules/alpha-value-notation',
67+
'at-rule-no-vendor-prefix':
68+
'https://stylelint.io/user-guide/rules/at-rule-no-vendor-prefix',
69+
'block-no-redundant-nested-style-rules':
70+
'https://stylelint.io/user-guide/rules/block-no-redundant-nested-style-rules',
71+
'color-function-alias-notation':
72+
'https://stylelint.io/user-guide/rules/color-function-alias-notation',
73+
'color-function-notation':
74+
'https://stylelint.io/user-guide/rules/color-function-notation',
75+
'comment-empty-line-before':
76+
'https://stylelint.io/user-guide/rules/comment-empty-line-before',
77+
'comment-whitespace-inside':
78+
'https://stylelint.io/user-guide/rules/comment-whitespace-inside',
79+
'container-name-pattern':
80+
'https://stylelint.io/user-guide/rules/container-name-pattern',
81+
'custom-media-pattern':
82+
'https://stylelint.io/user-guide/rules/custom-media-pattern',
83+
'custom-property-empty-line-before':
84+
'https://stylelint.io/user-guide/rules/custom-property-empty-line-before',
85+
'custom-property-pattern':
86+
'https://stylelint.io/user-guide/rules/custom-property-pattern',
87+
'declaration-empty-line-before':
88+
'https://stylelint.io/user-guide/rules/declaration-empty-line-before',
89+
'font-family-name-quotes':
90+
'https://stylelint.io/user-guide/rules/font-family-name-quotes',
91+
'function-name-case':
92+
'https://stylelint.io/user-guide/rules/function-name-case',
93+
'hue-degree-notation':
94+
'https://stylelint.io/user-guide/rules/hue-degree-notation',
95+
'import-notation': 'https://stylelint.io/user-guide/rules/import-notation',
96+
'keyframe-selector-notation':
97+
'https://stylelint.io/user-guide/rules/keyframe-selector-notation',
98+
'keyframes-name-pattern':
99+
'https://stylelint.io/user-guide/rules/keyframes-name-pattern',
100+
'layer-name-pattern':
101+
'https://stylelint.io/user-guide/rules/layer-name-pattern',
102+
'lightness-notation':
103+
'https://stylelint.io/user-guide/rules/lightness-notation',
104+
'media-feature-name-no-vendor-prefix':
105+
'https://stylelint.io/user-guide/rules/media-feature-name-no-vendor-prefix',
106+
'media-feature-range-notation':
107+
'https://stylelint.io/user-guide/rules/media-feature-range-notation',
108+
'number-max-precision':
109+
'https://stylelint.io/user-guide/rules/number-max-precision',
110+
'property-layout-mappings':
111+
'https://stylelint.io/user-guide/rules/property-layout-mappings',
112+
'relative-selector-nesting-notation':
113+
'https://stylelint.io/user-guide/rules/relative-selector-nesting-notation',
114+
'selector-attribute-quotes':
115+
'https://stylelint.io/user-guide/rules/selector-attribute-quotes',
116+
'selector-class-pattern':
117+
'https://stylelint.io/user-guide/rules/selector-class-pattern',
118+
'selector-id-pattern':
119+
'https://stylelint.io/user-guide/rules/selector-id-pattern',
120+
'selector-max-type':
121+
'https://stylelint.io/user-guide/rules/selector-max-type',
122+
'selector-no-deprecated':
123+
'https://stylelint.io/user-guide/rules/selector-no-deprecated',
124+
'selector-no-invalid':
125+
'https://stylelint.io/user-guide/rules/selector-no-invalid',
126+
'selector-no-unmatchable':
127+
'https://stylelint.io/user-guide/rules/selector-no-unmatchable',
128+
'selector-no-vendor-prefix':
129+
'https://stylelint.io/user-guide/rules/selector-no-vendor-prefix',
130+
'selector-not-notation':
131+
'https://stylelint.io/user-guide/rules/selector-not-notation',
132+
'selector-pseudo-element-colon-notation':
133+
'https://stylelint.io/user-guide/rules/selector-pseudo-element-colon-notation',
134+
'selector-type-case':
135+
'https://stylelint.io/user-guide/rules/selector-type-case',
136+
'shorthand-property-no-redundant-values':
137+
'https://stylelint.io/user-guide/rules/shorthand-property-no-redundant-values',
138+
'unit-layout-mappings':
139+
'https://stylelint.io/user-guide/rules/unit-layout-mappings',
140+
'value-keyword-case':
141+
'https://stylelint.io/user-guide/rules/value-keyword-case',
142+
'value-keyword-layout-mappings':
143+
'https://stylelint.io/user-guide/rules/value-keyword-layout-mappings',
144+
'scss/at-function-pattern':
145+
'https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/at-function-pattern',
146+
'scss/at-mixin-argumentless-call-parentheses':
147+
'https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/at-mixin-argumentless-call-parentheses',
148+
'scss/at-mixin-pattern':
149+
'https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/at-mixin-pattern',
150+
'scss/at-rule-conditional-no-parentheses':
151+
'https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/at-rule-conditional-no-parentheses',
152+
'scss/declaration-nested-properties':
153+
'https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/declaration-nested-properties',
154+
'scss/dollar-variable-empty-line-before':
155+
'https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/dollar-variable-empty-line-before',
156+
'scss/dollar-variable-pattern':
157+
'https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/dollar-variable-pattern',
158+
'scss/double-slash-comment-empty-line-before':
159+
'https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/double-slash-comment-empty-line-before',
160+
'scss/double-slash-comment-whitespace-inside':
161+
'https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/double-slash-comment-whitespace-inside',
162+
'scss/percent-placeholder-pattern':
163+
'https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/percent-placeholder-pattern',
65164
},
66165
upgrade16: {
67166
'scss/at-mixin-no-risky-nesting-selector':

0 commit comments

Comments
 (0)