Skip datetime parse if string too short

Author: waketzheng

tests/test_filtering.py

@@ -167,8 +167,7 @@ async def test_filter_not_with_or(self):
 
     @test.requireCapability(dialect__in=["postgres", "mysql"])
     async def test_filter_exact(self):
-        is_mysql = test._TORTOISE_TEST_DB.startswith("mysql")
-        await DatetimeFields.create(
+        obj = await DatetimeFields.create(
             datetime=datetime.datetime(
                 year=2020, month=5, day=20, hour=0, minute=0, second=0, microsecond=0
             )
@@ -177,11 +176,15 @@ async def test_filter_exact(self):
         self.assertEqual(await DatetimeFields.filter(datetime__quarter=2).count(), 1)
         self.assertEqual(await DatetimeFields.filter(datetime__month=5).count(), 1)
         self.assertEqual(await DatetimeFields.filter(datetime__day=20).count(), 1)
-        if is_mysql:
+        if test._TORTOISE_TEST_DB.startswith("mysql"):
             self.assertEqual(await DatetimeFields.filter(datetime__week=20).count(), 1)
             self.assertEqual(await DatetimeFields.filter(datetime__hour=0).count(), 1)
         else:
-            self.assertEqual(await DatetimeFields.filter(datetime__week=21).count(), 1)
+            # PostgreSQL enables tzinfo by default
+            dt = obj.datetime.astimezone()
+            week = dt.isocalendar()[1]
+            self.assertEqual(await DatetimeFields.filter(datetime__week=week).count(), 1)
+            self.assertEqual(await DatetimeFields.filter(datetime__hour=dt.hour).count(), 1)
         self.assertEqual(await DatetimeFields.filter(datetime__minute=0).count(), 1)
         self.assertEqual(await DatetimeFields.filter(datetime__second=0).count(), 1)
         self.assertEqual(await DatetimeFields.filter(datetime__microsecond=0).count(), 1)
@@ -193,9 +196,8 @@ async def test_filter_exact(self):
         self.assertEqual(await DateFields.filter(date__day=21).count(), 1)
         self.assertEqual(await DateFields.filter(date__year="2021").count(), 1)
         self.assertEqual(await DateFields.filter(date__year=2021.0).count(), 1)
-        if is_mysql:
-            self.assertEqual(await DateFields.filter(date="2021-6-21").count(), 1)
         self.assertEqual(await DateFields.filter(date="20210621").count(), 1)
+        self.assertEqual(await DateFields.filter(date="2021-06-21").count(), 1)
         self.assertEqual(
             await DateFields.filter(date=datetime.date(year=2021, month=6, day=21)).count(), 1
         )

tortoise/fields/data.py

@@ -417,9 +417,9 @@ def to_python_value(self, value: Any) -> datetime.date | None:
     def to_db_value(
         self, value: DateFieldQueryValueType | None, instance: type[Model] | Model
     ) -> DateFieldQueryValueType | None:
-        if value is not None and isinstance(value, str):
+        if value is not None and isinstance(value, str) and len(value) > 4:
             with contextlib.suppress(ValueError):
-                value = parse_datetime(value).date()  # type:ignore[assignment]
+                value = parse_datetime(value).date()
         self.validate(value)
         return value