Do not run inspections that require symbols outside the project

Author: waleedyaseen

CHANGELOG.md

@@ -1,6 +1,8 @@
 # intellij-runescript Changelog
 
 ## [Unreleased]
+### Changed
+- Inspections that require symbols will no longer run on files outside the project.
 
 ## [1.3.0] - 2023-08-30
 

src/main/kotlin/io/runescript/plugin/ide/inspections/RuneScriptMissingScriptSymbolInspection.kt

@@ -10,6 +10,7 @@ import com.intellij.refactoring.suggested.startOffset
 import io.runescript.plugin.ide.RsBundle
 import io.runescript.plugin.lang.psi.RsScript
 import io.runescript.plugin.lang.psi.RsVisitor
+import io.runescript.plugin.lang.psi.isSourceFile
 import io.runescript.plugin.lang.psi.qualifiedName
 import io.runescript.plugin.lang.psi.type.RsPrimitiveType
 import io.runescript.plugin.symbollang.psi.index.RsSymbolIndex
@@ -20,6 +21,7 @@ class RuneScriptMissingScriptSymbolInspection : LocalInspectionTool() {
         return object : RsVisitor() {
 
             override fun visitScript(o: RsScript) {
+                if (!o.isSourceFile()) return
                 val name = o.qualifiedName
                 val length = o.rbracket.endOffset - o.lbracket.startOffset
                 val range = TextRange.from(o.lbracket.startOffsetInParent, length)

src/main/kotlin/io/runescript/plugin/ide/inspections/RuneScriptTypeCheckerInspection.kt

@@ -5,6 +5,7 @@ import com.intellij.codeInspection.ProblemsHolder
 import com.intellij.psi.PsiElement
 import com.intellij.psi.PsiElementVisitor
 import io.runescript.plugin.lang.psi.RsVisitor
+import io.runescript.plugin.lang.psi.isSourceFile
 import io.runescript.plugin.lang.psi.type.typeErrors
 
 class RuneScriptTypeCheckerInspection : LocalInspectionTool() {
@@ -13,6 +14,7 @@ class RuneScriptTypeCheckerInspection : LocalInspectionTool() {
         return object : RsVisitor() {
 
             override fun visitElement(element: PsiElement) {
+                if (!element.isSourceFile()) return
                 element.typeErrors.forEach {
                     holder.registerProblem(it.element, it.message)
                 }

src/main/kotlin/io/runescript/plugin/ide/inspections/RuneScriptUnresolvedClientscriptInspection.kt

@@ -13,12 +13,14 @@ import io.runescript.plugin.ide.RsBundle
 import io.runescript.plugin.lang.psi.RsHookFragment
 import io.runescript.plugin.lang.psi.RsScript
 import io.runescript.plugin.lang.psi.RsVisitor
+import io.runescript.plugin.lang.psi.isSourceFile
 
 class RuneScriptUnresolvedClientscriptInspection : LocalInspectionTool() {
 
     override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
         return object : RsVisitor() {
             override fun visitHookFragment(o: RsHookFragment) {
+                if (!o.isSourceFile()) return
                 val resolvedClientScript = o.reference!!.resolve()
                 if (resolvedClientScript == null) {
                     holder.registerProblem(o.nameLiteral,

src/main/kotlin/io/runescript/plugin/ide/inspections/RuneScriptUnresolvedCommandInspection.kt

@@ -7,12 +7,14 @@ import com.intellij.psi.PsiElementVisitor
 import io.runescript.plugin.ide.RsBundle
 import io.runescript.plugin.lang.psi.RsCommandExpression
 import io.runescript.plugin.lang.psi.RsVisitor
+import io.runescript.plugin.lang.psi.isSourceFile
 
 class RuneScriptUnresolvedCommandInspection : LocalInspectionTool() {
 
     override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
         return object : RsVisitor() {
             override fun visitCommandExpression(o: RsCommandExpression) {
+                if (!o.isSourceFile()) return
                 val resolvedCommand = o.reference!!.resolve()
                 if (resolvedCommand == null) {
                     holder.registerProblem(o.nameLiteral,

src/main/kotlin/io/runescript/plugin/ide/inspections/RuneScriptUnresolvedConstantInspection.kt

@@ -7,12 +7,14 @@ import com.intellij.psi.PsiElementVisitor
 import io.runescript.plugin.ide.RsBundle
 import io.runescript.plugin.lang.psi.RsConstantExpression
 import io.runescript.plugin.lang.psi.RsVisitor
+import io.runescript.plugin.lang.psi.isSourceFile
 
 class RuneScriptUnresolvedConstantInspection : LocalInspectionTool() {
 
     override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
         return object : RsVisitor() {
             override fun visitConstantExpression(o: RsConstantExpression) {
+                if (!o.isSourceFile()) return
                 val reference = o.reference ?: return
                 if (reference.resolve() == null) {
                     holder.registerProblem(o,

src/main/kotlin/io/runescript/plugin/ide/inspections/RuneScriptUnresolvedProcedureInspection.kt

@@ -13,12 +13,14 @@ import io.runescript.plugin.ide.RsBundle
 import io.runescript.plugin.lang.psi.RsGosubExpression
 import io.runescript.plugin.lang.psi.RsScript
 import io.runescript.plugin.lang.psi.RsVisitor
+import io.runescript.plugin.lang.psi.isSourceFile
 
 class RuneScriptUnresolvedProcedureInspection : LocalInspectionTool() {
 
     override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
         return object : RsVisitor() {
             override fun visitGosubExpression(o: RsGosubExpression) {
+                if (!o.isSourceFile()) return
                 val resolvedGosub = o.reference!!.resolve()
                 if (resolvedGosub == null) {
                     holder.registerProblem(o.nameLiteral,

src/main/kotlin/io/runescript/plugin/ide/inspections/RuneScriptUnresolvedReferenceInspection.kt

@@ -8,12 +8,14 @@ import io.runescript.plugin.ide.RsBundle
 import io.runescript.plugin.lang.psi.RsDynamicExpression
 import io.runescript.plugin.lang.psi.RsStringLiteralExpression
 import io.runescript.plugin.lang.psi.RsVisitor
+import io.runescript.plugin.lang.psi.isSourceFile
 
 class RuneScriptUnresolvedReferenceInspection : LocalInspectionTool() {
 
     override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
         return object : RsVisitor() {
             override fun visitStringLiteralExpression(o: RsStringLiteralExpression) {
+                if (!o.isSourceFile()) return
                 val reference = o.reference ?: return
                 val resolved = reference.resolve()
                 if (resolved == null) {
@@ -25,6 +27,7 @@ class RuneScriptUnresolvedReferenceInspection : LocalInspectionTool() {
                 }
             }
             override fun visitDynamicExpression(o: RsDynamicExpression) {
+                if (!o.isSourceFile()) return
                 val reference = o.reference?: return
                 val resolved = reference.resolve()
                 if (resolved==null) {

src/main/kotlin/io/runescript/plugin/ide/inspections/RuneScriptUnresolvedScopedVariableInspection.kt

@@ -7,12 +7,14 @@ import com.intellij.psi.PsiElementVisitor
 import io.runescript.plugin.ide.RsBundle
 import io.runescript.plugin.lang.psi.RsScopedVariableExpression
 import io.runescript.plugin.lang.psi.RsVisitor
+import io.runescript.plugin.lang.psi.isSourceFile
 
 class RuneScriptUnresolvedScopedVariableInspection : LocalInspectionTool() {
 
     override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
         return object : RsVisitor() {
             override fun visitScopedVariableExpression(o: RsScopedVariableExpression) {
+                if (!o.isSourceFile()) return
                 val reference = o.reference ?: return
                 if (reference.resolve() == null) {
                     holder.registerProblem(o,

src/main/kotlin/io/runescript/plugin/lang/psi/psi.kt

@@ -1,6 +1,12 @@
 package io.runescript.plugin.lang.psi
 
+import com.intellij.openapi.project.Project
+import com.intellij.openapi.project.modules
+import com.intellij.openapi.roots.ModuleRootManager
+import com.intellij.openapi.roots.ProjectFileIndex
+import com.intellij.psi.PsiElement
 import com.intellij.psi.util.parentOfType
+import io.runescript.plugin.ide.sdk.RsSdkType
 
 val RsStatement.controlFlowHolder: RsControlFlowHolder?
     get() = parentOfType<RsControlFlowHolder>()
@@ -67,3 +73,24 @@ fun RsLocalVariableExpression.isForArrayAccess(): Boolean {
     val parent = parent
     return parent is RsArrayAccessExpression && this === parent.expressionList[0]
 }
+
+fun Project.isRsProject(): Boolean {
+    if (modules.size != 1) {
+        return false
+    }
+    val moduleRootManager = ModuleRootManager.getInstance(modules[0])
+    val sdk = moduleRootManager.sdk
+    return sdk?.sdkType == RsSdkType.find()
+}
+
+fun PsiElement.isSourceFile(): Boolean {
+    if (!project.isRsProject()) {
+        return false
+    }
+    val containingFile = containingFile?.virtualFile ?: return false
+    val fileIndex = ProjectFileIndex.getInstance(project)
+    if (fileIndex.isExcluded(containingFile)) {
+        return false
+    }
+    return fileIndex.isInContent(containingFile)
+}