Fix type checking when there is a type error

Author: waleedyaseen

CHANGELOG.md

@@ -16,6 +16,7 @@
 - Fix a bug with script block indentation.
 - Fix missing indentation for file block.
 - Fix type checking for expression lists.
+- Fix type checking when there is a type error.
 
 ## [1.2.0] - 2023-08-18
 

src/main/kotlin/io/runescript/plugin/lang/psi/type/RsTypeExt.kt

@@ -35,10 +35,7 @@ fun Iterable<RsType>.flatten(): Array<RsType> {
     for (type in this) {
         when (type) {
             is RsTupleType -> flattened.addAll(type.types)
-            is RsPrimitiveType -> flattened.add(type)
-            is RsArrayType -> flattened.add(type)
-            is RsTypeType -> flattened.add(type)
-            else -> error("Called flatten() on non primitive type array: ${type::class}")
+            else -> flattened.add(type)
         }
     }
     return flattened.toTypedArray()

src/main/kotlin/io/runescript/plugin/lang/psi/type/inference/RsTypeInferenceVisitor.kt

@@ -99,7 +99,9 @@ class RsTypeInferenceVisitor(private val myInferenceData: RsTypeInference) : RsV
     }
 
     private fun RsType?.unfold(): RsType? {
-        if (this is RsTupleType && types.size == 1) return types[0]
+        if (this is RsTupleType && types.size == 1) {
+            return types[0]
+        }
         return this
     }
 
@@ -119,6 +121,12 @@ class RsTypeInferenceVisitor(private val myInferenceData: RsTypeInference) : RsV
         if (unfoldedActualType is RsErrorType || unfoldedExpectedType is RsErrorType) {
             return
         }
+        if (unfoldedActualType is RsTupleType && RsErrorType in unfoldedActualType.types) {
+            return
+        }
+        if (unfoldedExpectedType is RsTupleType && RsErrorType in unfoldedExpectedType.types) {
+            return
+        }
         if (unfoldedExpectedType == RsPrimitiveType.OBJ && unfoldedActualType == RsPrimitiveType.NAMEDOBJ) {
             // namedobj extends obj
             return