Skip to content

Commit 89de864

Browse files
committed
rename cwl_watcher to cwl_subinterpreter
1 parent 783630f commit 89de864

18 files changed

+36
-36
lines changed

docs/advanced.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ This will override the default implementation of `gromacs` and use `amber`. This
3737

3838
## Subinterpreters
3939

40-
A portion of [`examples/gromacs/nvt.wic`](https://github.com/PolusAI/mm-workflows/blob/main/examples/gromacs/nvt.wic) in `mm-workflows` is shown below. You can see that the `in:` tag of gmx_energy is identical to the `config:` tag of cwl_watcher. This currently needs to be manually copy & pasted (and indented), but it should be possible to automatically do this in the future.
40+
A portion of [`examples/gromacs/nvt.wic`](https://github.com/PolusAI/mm-workflows/blob/main/examples/gromacs/nvt.wic) in `mm-workflows` is shown below. You can see that the `in:` tag of gmx_energy is identical to the `config:` tag of cwl_subinterpreter. This currently needs to be manually copy & pasted (and indented), but it should be possible to automatically do this in the future.
4141

4242
```yaml
4343
...
@@ -51,9 +51,9 @@ A portion of [`examples/gromacs/nvt.wic`](https://github.com/PolusAI/mm-workflow
5151
config: !ii
5252
terms: [Temperature]
5353
output_xvg_path: temperature.xvg
54-
# NOTE: explicit edges are not supported with cwl_watcher, and all filenames
54+
# NOTE: explicit edges are not supported with cwl_subinterpreter, and all filenames
5555
# must be globally unique!
56-
- cwl_watcher:
56+
- cwl_subinterpreter:
5757
in:
5858
#cachedir_path: /absolute/path/to/cachedir/ (automatically filled in by wic)
5959
file_pattern: '*nvt.edr' # Any strings that start with & or * need to be escaped in quotes
@@ -68,13 +68,13 @@ A portion of [`examples/gromacs/nvt.wic`](https://github.com/PolusAI/mm-workflow
6868
...
6969
```
7070

71-
Note that although gmx_energy appears before cwl_watcher in the YAML file, gmx_energy is independent of cwl_watcher in the DAG and thus not considered to be a previous step. We include gmx_energy simply to guarantee that the analysis gets run one more time in the main workflow, when all the files are known to be in their final state.
71+
Note that although gmx_energy appears before cwl_subinterpreter in the YAML file, gmx_energy is independent of cwl_subinterpreter in the DAG and thus not considered to be a previous step. We include gmx_energy simply to guarantee that the analysis gets run one more time in the main workflow, when all the files are known to be in their final state.
7272

7373
### Known Issues
7474

7575
Since the two runtimes are not linked, there is not currently a reliable way to determine if the previous steps have finished. Thus, to guarantee termination of the second runtime, we simply execute `cwl_tool` upto `max_times`. We also waive any guarantees about the files, so the subworkflow in the second runtime may of course fail for any number of reasons. Thus, we do not propagate speculative failures up to the main workflow.
7676

77-
The runtime system intentionally hides the working sub-directories of each step. Thus, we are forced to use a file watcher (hence the name cwl_watcher) recursively starting from `cachedir_path`. This is why all filenames used with cwl_watcher must be globally unique. (Actually, for technical reasons we cannot use a file watching library; we simply use a good old fashioned polling loop.)
77+
The runtime system intentionally hides the working sub-directories of each step. Thus, we are forced to use a file watcher recursively starting from `cachedir_path`. This is why all filenames used with cwl_subinterpreter must be globally unique. (Actually, for technical reasons we cannot use a file watching library; we simply use a good old fashioned polling loop.)
7878

7979
## Real-time plots
8080

examples/config_ci.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,10 @@
6565
"cg",
6666
"yank",
6767
// These (currently) always return success, so no point in running them.
68-
"cwl_watcher_analysis",
69-
"cwl_watcher_complex",
70-
"cwl_watcher_ligand",
71-
"cwl_watcher_protein",
68+
"cwl_subinterpreter_analysis",
69+
"cwl_subinterpreter_complex",
70+
"cwl_subinterpreter_ligand",
71+
"cwl_subinterpreter_protein",
7272
// Skip vs_demo_4 and run_diffdock so we don't accidentally DOS pdbbind.org.cn
7373
"vs_demo_4",
7474
"run_diffdock"

examples/docking/docking_stability.wic

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ wic:
3737
(3, prod.wic):
3838
wic:
3939
steps:
40-
(4, cwl_watcher_analysis.wic):
40+
(4, cwl_subinterpreter_analysis.wic):
4141
wic:
4242
implementation: complex
4343
(3, analysis.wic):

examples/docking/vs_demo_2.wic

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ wic:
178178
- output_crd_path: !& prod_complex.gro # overload prod.gro
179179
- output_trr_path: !& prod.trr
180180
- output_edr_path: !& prod.edr
181-
(4, cwl_watcher_analysis.wic):
181+
(4, cwl_subinterpreter_analysis.wic):
182182
wic:
183183
implementation: complex
184184
(3, analysis.wic):

examples/docking/vs_demo_3.wic

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ wic:
154154
- output_crd_path: !& prod_complex.gro # overload prod.gro
155155
- output_trr_path: !& prod.trr
156156
- output_edr_path: !& prod.edr
157-
(4, cwl_watcher_analysis.wic):
157+
(4, cwl_subinterpreter_analysis.wic):
158158
wic:
159159
implementation: complex
160160
(3, analysis.wic):

examples/docking/vs_demo_4.wic

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ wic:
229229
- output_crd_path: !& prod_complex.gro # overload prod.gro
230230
- output_trr_path: !& prod.trr
231231
- output_edr_path: !& prod.edr
232-
(4, cwl_watcher_analysis.wic):
232+
(4, cwl_subinterpreter_analysis.wic):
233233
wic:
234234
implementation: complex
235235
(3, analysis.wic):

examples/gromacs/analysis_realtime_complex.wic

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# This causes the rmsd w.r.t. the last equil timestep to start at exactly zero,
44
# which distorts the comparison between the xray and equil cases.
55
# NOTE: Most paths can be inferred, but explicitly specify them anyway because
6-
# for cwl_watcher and so we can re-order steps in analysis.
6+
# for cwl_subinterpreter and so we can re-order steps in analysis.
77
steps:
88
- gmxselect: # NOTE: make_ndx does NOT work! (It erroneously selects all of the atoms.)
99
in:

examples/gromacs/analysis_realtime_ligand.wic

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# This causes the rmsd w.r.t. the last equil timestep to start at exactly zero,
44
# which distorts the comparison between the xray and equil cases.
55
# NOTE: Most paths can be inferred, but explicitly specify them anyway because
6-
# for cwl_watcher and so we can re-order steps in analysis.
6+
# for cwl_subinterpreter and so we can re-order steps in analysis.
77
steps:
88
- gmxselect: # NOTE: make_ndx does NOT work! (It erroneously selects all of the atoms.)
99
in:

examples/gromacs/analysis_realtime_protein.wic

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# This causes the rmsd w.r.t. the last equil timestep to start at exactly zero,
44
# which distorts the comparison between the xray and equil cases.
55
# NOTE: Most paths can be inferred, but explicitly specify them anyway because
6-
# for cwl_watcher and so we can re-order steps in analysis.
6+
# for cwl_subinterpreter and so we can re-order steps in analysis.
77
steps:
88
- gmx_rms:
99
in:

examples/gromacs/cwl_watcher_analysis.wic renamed to examples/gromacs/cwl_subinterpreter_analysis.wic

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@ wic:
33
implementations:
44
protein:
55
steps:
6-
- cwl_watcher_protein.wic:
6+
- cwl_subinterpreter_protein.wic:
77
ligand:
88
steps:
9-
- cwl_watcher_ligand.wic:
9+
- cwl_subinterpreter_ligand.wic:
1010
complex:
1111
steps:
12-
- cwl_watcher_complex.wic:
12+
- cwl_subinterpreter_complex.wic:
1313
graphviz:
1414
label: 'Real-time\nAnalysis'
1515
style: invis # Make this graph (and all subgraphs) invisible

0 commit comments

Comments
 (0)