Skip to content

Commit e2a40b8

Browse files
authored
Merge pull request PolusAI#234 from misterbrandonwalker/revert_commit
Revert "Merge pull request PolusAI#230 from ndonyapour/Molgan_DockingRescori…
2 parents 6d6e493 + a4e678c commit e2a40b8

File tree

11 files changed

+8
-120
lines changed

11 files changed

+8
-120
lines changed

cwl_adapters/convert_mol2.cwl

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -126,13 +126,6 @@ outputs:
126126
glob: $(inputs.output_mol2_path)
127127
format: edam:format_3816 # mol2
128128
129-
stderr:
130-
type: File
131-
outputBinding:
132-
glob: stderr
133-
134-
stderr: stderr
135-
136129
$namespaces:
137130
edam: https://edamontology.org/
138131

cwl_adapters/extract_molecules_sdf.cwl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ arguments: [$(inputs.input_path), "-o", "sdf", "-O", $(inputs.output_sdf_path),
7070

7171
hints:
7272
DockerRequirement:
73-
#dockerPull: ndonyapour/openbabel
73+
#dockerPull: jakefennick/openbabel
7474
dockerPull: quay.io/biocontainers/biobb_chemistry:4.0.0--pyhdfd78af_1
7575

7676
inputs:

cwl_adapters/load_trained_molgan_model.cwl

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,6 @@ hints:
1111
DockerRequirement:
1212
dockerPull: ndonyapour/molgan
1313

14-
# Set environment variables for the tool,
15-
# See: https://www.commonwl.org/user_guide/topics/environment-variables.html
16-
requirements:
17-
EnvVarRequirement:
18-
envDef:
19-
RDKIT_ERROR_LOGGING: $(inputs.rdkit_error_logging)
2014
inputs:
2115
input_data_path:
2216
label: Path to the input data file
@@ -113,16 +107,6 @@ inputs:
113107
prefix: --num_samples
114108
default: 1000
115109

116-
rdkit_error_logging:
117-
label: Enable or disable RDKit error logging
118-
doc: |-
119-
Enable or disable RDKit error logging
120-
type: string?
121-
format:
122-
- edam:format_2330
123-
# RDKit prints out all errors by default, which can pose issues for CI,
124-
# particularly with large databases. It would be more efficient to suppress these errors.
125-
default: ON
126110
outputs:
127111
output_log_path:
128112
label: Path to the log file
@@ -142,12 +126,6 @@ outputs:
142126
glob: $(inputs.output_sdf_path)
143127
format: edam:format_3814 # sdf
144128

145-
stderr:
146-
type: File
147-
outputBinding:
148-
glob: stderr
149-
150-
stderr: stderr
151129

152130
$namespaces:
153131
edam: https://edamontology.org/

cwl_adapters/obmin.cwl

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ baseCommand: bash
1212

1313
hints:
1414
DockerRequirement:
15-
dockerPull: ndonyapour/openbabel
15+
dockerPull: jakefennick/openbabel
1616

1717
inputs:
1818
script:
@@ -31,8 +31,8 @@ inputs:
3131
type: string
3232
format:
3333
- edam:format_3816
34-
inputBinding:
35-
position: 3
34+
# inputBinding:
35+
# position: 3
3636
default: system.mol2
3737

3838
outputs:
@@ -43,13 +43,7 @@ outputs:
4343
outputBinding:
4444
glob: $(inputs.output_mol2_path)
4545

46-
stderr:
47-
type: File
48-
outputBinding:
49-
glob: stderr
50-
51-
stderr: stderr
52-
46+
stdout: $(inputs.output_mol2_path)
5347

5448
$namespaces:
5549
edam: https://edamontology.org/

cwl_adapters/preprocess_molgan_database.cwl

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,6 @@ hints:
1111
DockerRequirement:
1212
dockerPull: ndonyapour/molgan
1313

14-
# Set environment variables for the tool,
15-
# See: https://www.commonwl.org/user_guide/topics/environment-variables.html
16-
requirements:
17-
EnvVarRequirement:
18-
envDef:
19-
RDKIT_ERROR_LOGGING: $(inputs.rdkit_error_logging)
20-
2114
inputs:
2215
input_sdf_path:
2316
label: Path to the input file
@@ -48,17 +41,6 @@ inputs:
4841
prefix: --output_data_path
4942
default: system.pkl
5043

51-
rdkit_error_logging:
52-
label: Enable or disable RDKit error logging
53-
doc: |-
54-
Enable or disable RDKit error logging
55-
type: string?
56-
format:
57-
- edam:format_2330
58-
# RDKit prints out all errors by default, which can pose issues for CI,
59-
# particularly with large databases. It would be more efficient to suppress these errors.
60-
default: ON
61-
6244
outputs:
6345
output_data_path:
6446
label: Path to the output data file
@@ -69,13 +51,6 @@ outputs:
6951
glob: $(inputs.output_data_path)
7052
format: edam:format_3653 # sdf
7153

72-
stderr:
73-
type: File
74-
outputBinding:
75-
glob: stderr
76-
77-
stderr: stderr
78-
7954
$namespaces:
8055
edam: https://edamontology.org/
8156

cwl_adapters/run_trained_molgan_model.cwl

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,6 @@ hints:
1111
DockerRequirement:
1212
dockerPull: ndonyapour/molgan
1313

14-
# Set environment variables for the tool,
15-
# See: https://www.commonwl.org/user_guide/topics/environment-variables.html
16-
requirements:
17-
EnvVarRequirement:
18-
envDef:
19-
RDKIT_ERROR_LOGGING: $(inputs.rdkit_error_logging)
20-
2114
inputs:
2215
input_data_path:
2316
label: Path to the input data file
@@ -113,16 +106,6 @@ inputs:
113106
prefix: --num_samples
114107
default: 1000
115108

116-
rdkit_error_logging:
117-
label: Enable or disable RDKit error logging
118-
doc: |-
119-
Enable or disable RDKit error logging
120-
type: string?
121-
format:
122-
- edam:format_2330
123-
# RDKit prints out all errors by default, which can pose issues for CI,
124-
# particularly with large databases. It would be more efficient to suppress these errors.
125-
default: ON
126109
outputs:
127110
output_log_path:
128111
label: Path to the log file
@@ -142,13 +125,6 @@ outputs:
142125
glob: $(inputs.output_sdf_path)
143126
format: edam:format_3814 # sdf
144127

145-
stderr:
146-
type: File
147-
outputBinding:
148-
glob: stderr
149-
150-
stderr: stderr
151-
152128

153129
$namespaces:
154130
edam: https://edamontology.org/

cwl_adapters/train_molgan_model.cwl

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,6 @@ hints:
1111
DockerRequirement:
1212
dockerPull: ndonyapour/molgan
1313

14-
# Set environment variables for the tool,
15-
# See: https://www.commonwl.org/user_guide/topics/environment-variables.html
16-
requirements:
17-
EnvVarRequirement:
18-
envDef:
19-
RDKIT_ERROR_LOGGING: $(inputs.rdkit_error_logging)
20-
2114
inputs:
2215
input_data_path:
2316
label: Path to the input data file
@@ -120,17 +113,6 @@ inputs:
120113
inputBinding:
121114
prefix: --save_frequency
122115

123-
rdkit_error_logging:
124-
label: Enable or disable RDKit error logging
125-
doc: |-
126-
Enable or disable RDKit error logging
127-
type: string?
128-
format:
129-
- edam:format_2330
130-
# RDKit prints out all errors by default, which can pose issues for CI,
131-
# particularly with large databases. It would be more efficient to suppress these errors.
132-
default: ON
133-
134116
outputs:
135117

136118
output_log_path:
@@ -147,13 +129,6 @@ outputs:
147129
outputBinding:
148130
glob: $(inputs.output_model_dir)
149131
format: edam:format_2330 # 'Textual format
150-
151-
stderr:
152-
type: File
153-
outputBinding:
154-
glob: stderr
155-
156-
stderr: stderr
157132

158133
$namespaces:
159134
edam: https://edamontology.org/

docker/dockerBuild.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ sudo docker build --no-cache --pull -f Dockerfile_bash_scripts -t jakefennick/ba
2525
sudo docker build --no-cache --pull -f Dockerfile_calculate_net_charge -t jakefennick/calculate_net_charge .
2626
sudo docker build --no-cache --pull -f Dockerfile_mol2_to_pdbqt -t jakefennick/mol2_to_pdbqt .
2727
sudo docker build --no-cache --pull -f Dockerfile_nmr4md -t jakefennick/nmr4md .
28-
sudo docker build --no-cache --pull -f Dockerfile_openbabel -t ndonyapour/openbabel .
28+
sudo docker build --no-cache --pull -f Dockerfile_openbabel -t jakefennick/openbabel .
2929
sudo docker build --no-cache --pull -f Dockerfile_remove_terminal_residue_name_prefixes -t jakefennick/remove_terminal_residue_name_prefixes .
3030
sudo docker build --no-cache --pull -f Dockerfile_rename_residues_mol -t jakefennick/rename_residues_mol .
3131
sudo docker build --no-cache --pull -f Dockerfile_combine_structure -t ndonyapour/combine_structure .

dockerPull.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ docker pull jakefennick/calculate_net_charge
1717
docker pull jakefennick/generate_conformers
1818
docker pull jakefennick/mol2_to_pdbqt
1919
docker pull jakefennick/nmr4md
20-
docker pull ndonyapour/openbabel
20+
docker pull jakefennick/openbabel
2121
docker pull jakefennick/remove_terminal_residue_name_prefixes
2222
docker pull jakefennick/rename_residues_mol
2323
docker pull ndonyapour/molgan

examples/scripts/Dockerfile_molgan

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
FROM condaforge/mambaforge
33
# NOT mambaforge-pypy3 (rdkit is incompatible with pypy)
44

5-
# RDKIT logging
6-
ENV RDKIT_ERROR_LOGGING="OFF"
7-
85
RUN apt-get update && apt-get install -y wget git
96

107
# Clone MolGAN

0 commit comments

Comments
 (0)