DetectAssetChangeProcessor bug fix (#182)

## Description

- Skip scene assets when doing `LoadAssetAtPath` in
DetectAssetChangePostProcessor
- Add documentation URL to package.json
- Update home page to github pages

## Related Issue

<!-- Link to the issue this PR addresses -->

Fixes #180
Fixes #181

## Type of Change

<!-- Check all that apply -->

- [x] Bug fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [x] Documentation update
- [ ] Refactor (code change that neither fixes a bug nor adds a feature)

## Checklist

<!-- Ensure all items are completed before requesting review -->

- [x] I have added tests that prove my fix is effective or my feature
works
- [x] I have updated the documentation accordingly
- [x] I have updated the [CHANGELOG](../CHANGELOG.md)
- [x] My changes do not introduce breaking changes, or breaking changes
are documented

Author: wallstop

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- **DetectAssetChanged scene file crash**: Fixed Unity crash ("Do not use ReadObjectThreaded on scene objects!") when `.unity` or `.scenetemplate` files were processed by the asset change detection system
+
 See [the roadmap](./docs/overview/roadmap.md) for details
 
 ## [3.1.6]

Editor/AssetProcessors/DetectAssetChangeProcessor.cs

@@ -554,15 +554,19 @@ IReadOnlyList<string> createdPaths
                 }
 
                 // If main asset doesn't match, check sub-assets (e.g., Sprites in a Texture2D)
-                UnityEngine.Object[] allAssets = AssetDatabase.LoadAllAssetsAtPath(path);
-                if (allAssets != null)
+                // Scene files crash LoadAllAssetsAtPath (ReadObjectThreaded not allowed)
+                if (!IsScenePath(path))
                 {
-                    for (int j = 0; j < allAssets.Length; j++)
+                    UnityEngine.Object[] allAssets = AssetDatabase.LoadAllAssetsAtPath(path);
+                    if (allAssets != null)
                     {
-                        UnityEngine.Object subAsset = allAssets[j];
-                        if (subAsset != null && assetType.IsInstanceOfType(subAsset))
+                        for (int j = 0; j < allAssets.Length; j++)
                         {
-                            instances.Add(subAsset);
+                            UnityEngine.Object subAsset = allAssets[j];
+                            if (subAsset != null && assetType.IsInstanceOfType(subAsset))
+                            {
+                                instances.Add(subAsset);
+                            }
                         }
                     }
                 }
@@ -974,6 +978,12 @@ List<string> buffer
 
         private static bool HasMatchingSubAsset(string path, Type assetType)
         {
+            // Scene files crash LoadAllAssetsAtPath (ReadObjectThreaded not allowed)
+            if (IsScenePath(path))
+            {
+                return false;
+            }
+
             UnityEngine.Object[] allAssets = AssetDatabase.LoadAllAssetsAtPath(path);
             if (allAssets == null || allAssets.Length <= 1)
             {
@@ -1492,5 +1502,14 @@ private static bool ShouldSkipPath(string assetPath)
 
             return false;
         }
+
+        private static bool IsScenePath(string assetPath)
+        {
+            return assetPath != null
+                && (
+                    assetPath.EndsWith(".unity", StringComparison.OrdinalIgnoreCase)
+                    || assetPath.EndsWith(".scenetemplate", StringComparison.OrdinalIgnoreCase)
+                );
+        }
     }
 }

Tests/Editor/AssetProcessors/DetectAssetChangeProcessorTests.cs

@@ -826,6 +826,74 @@ public void MixedHandlerTypesInSingleEventBatchProcessCorrectly()
             );
         }
 
+        [TestCase(".unity", TestName = "SceneFile.LowerCase.DoesNotCrash")]
+        [TestCase(".Unity", TestName = "SceneFile.PascalCase.DoesNotCrash")]
+        [TestCase(".UNITY", TestName = "SceneFile.UpperCase.DoesNotCrash")]
+        [TestCase(".scenetemplate", TestName = "SceneFile.SceneTemplate.DoesNotCrash")]
+        public void SceneFileImportDoesNotCrash(string extension)
+        {
+            // Regression test: Importing a .unity scene file should not crash.
+            // Previously, HasMatchingSubAsset called AssetDatabase.LoadAllAssetsAtPath on
+            // scene files, which triggers Unity's "Do not use ReadObjectThreaded on scene objects!" error.
+            string fakeScenePath = TestRoot + "/TestScene" + extension;
+
+            ClearTestState();
+
+            Assert.DoesNotThrow(
+                () =>
+                    DetectAssetChangeProcessor.ProcessChangesForTesting(
+                        new[] { fakeScenePath },
+                        null,
+                        null,
+                        null
+                    ),
+                $"Processing a '{extension}' scene file as an imported asset should not throw or crash"
+            );
+
+            // Scene files are not TestDetectableAsset, so no handler should fire for created assets
+            foreach (AssetChangeContext context in TestDetectAssetChangeHandler.RecordedContexts)
+            {
+                CollectionAssert.DoesNotContain(
+                    context.CreatedAssetPaths,
+                    fakeScenePath,
+                    $"Scene file '{fakeScenePath}' should not appear in created asset paths for a ScriptableObject watcher"
+                );
+            }
+        }
+
+        [Test]
+        public void SceneFileInMixedBatchDoesNotInterfereWithNormalAssets()
+        {
+            // Verify that a scene file in the same import batch does not prevent normal asset processing.
+            string fakeScenePath = TestRoot + "/TestScene.unity";
+
+            CreatePayloadAssetAt(PayloadPath);
+            ClearTestState();
+
+            DetectAssetChangeProcessor.ProcessChangesForTesting(
+                new[] { PayloadPath, fakeScenePath },
+                null,
+                null,
+                null
+            );
+
+            Assert.GreaterOrEqual(
+                TestDetectAssetChangeHandler.RecordedContexts.Count,
+                1,
+                $"Expected at least 1 handler invocation for valid asset '{PayloadPath}' in mixed batch with scene file, "
+                    + $"but got {TestDetectAssetChangeHandler.RecordedContexts.Count}"
+            );
+
+            foreach (AssetChangeContext context in TestDetectAssetChangeHandler.RecordedContexts)
+            {
+                CollectionAssert.DoesNotContain(
+                    context.CreatedAssetPaths,
+                    fakeScenePath,
+                    $"Scene file '{fakeScenePath}' should not appear in created asset paths when mixed with normal assets"
+                );
+            }
+        }
+
         [TestCase(false, false, true, true, TestName = "ChangeFlags.MovedOnly.HandlesMovedAsset")]
         public void MovedAssetFlagsDataDriven(
             bool hasCreated,

docs/images/unity-helpers-banner.svg

@@ -1,8 +1,8 @@
 {
   "name": "com.wallstop-studios.unity-helpers",
-  "version": "3.1.6",
+  "version": "3.1.7",
   "displayName": "Unity Helpers",
-  "description": "Treasure chest of Unity developer tools ",
+  "description": "Treasure chest of Unity developer tools",
   "unity": "2021.3",
   "keywords": [
     "inspector-attributes",
@@ -40,8 +40,10 @@
     "url": "https://github.com/wallstop/unity-helpers/issues"
   },
   "author": "wallstop studios <[email protected]> (https://wallstopstudios.com)",
-  "homepage": "https://github.com/wallstop/unity-helpers#readme",
-  "main": "README.md",
+  "homepage": "https://wallstop.github.io/unity-helpers",
+  "documentationUrl": "https://wallstop.github.io/unity-helpers",
+  "changelogUrl": "https://github.com/wallstop/unity-helpers/blob/main/CHANGELOG.md",
+  "licensesUrl": "https://wallstop.github.io/unity-helpers/project/license/",
   "samples": [
     {
       "displayName": "DI – VContainer",