linting plugins

Author: walterhiggins

.eslintignore

@@ -0,0 +1 @@
+src/main/js/lib/json2.js

.eslintrc.js

@@ -12,7 +12,14 @@ module.exports = {
     "__dirname": true,
     "persist": true,
     "isOp": true,
-    "echo": true
+    "echo": true,
+    "scload": true,
+    "nashorn": true,
+    "plugin": true, // not the same as __plugin!!!
+    "command": true,
+    "config": true,
+    "window": false,
+    "document": false
   },
   "extends": "eslint:recommended",
   "rules": {

src/main/java/bukkit/org/scriptcraftjs/bukkit/ScriptCraftPlugin.java

@@ -30,19 +30,19 @@ public class ScriptCraftPlugin extends JavaPlugin implements Listener
         try {
             ScriptEngineManager factory = new ScriptEngineManager();
             this.engine = factory.getEngineByName("JavaScript");
-			if (this.engine == null) {
-				this.getLogger().severe(NO_JAVASCRIPT_MESSAGE);
-			} else {
-				Invocable inv = (Invocable) this.engine;
-				this.engine.eval(new InputStreamReader(this.getResource("boot.js")));
-				inv.invokeFunction("__scboot", this, engine);
-			}
-		} catch (Exception e) {
-			e.printStackTrace();
-			this.getLogger().severe(e.getMessage());
-		} finally {
-			currentThread.setContextClassLoader(previousClassLoader);
-		}
+            if (this.engine == null) {
+                this.getLogger().severe(NO_JAVASCRIPT_MESSAGE);
+            } else {
+                Invocable inv = (Invocable) this.engine;
+                this.engine.eval(new InputStreamReader(this.getResource("boot.js")));
+                inv.invokeFunction("__scboot", this, engine);
+            }
+        } catch (Exception e) {
+            e.printStackTrace();
+            this.getLogger().severe(e.getMessage());
+        } finally {
+            currentThread.setContextClassLoader(previousClassLoader);
+        }
     }
 
     public List<String> onTabComplete(CommandSender sender, Command cmd,

src/main/js/lib/events-bukkit.js

@@ -1,8 +1,7 @@
 /*global Java, exports, org, __plugin */
 var bkEventPriority = org.bukkit.event.EventPriority,
   bkEventExecutor = org.bukkit.plugin.EventExecutor,
-  bkRegisteredListener = org.bukkit.plugin.RegisteredListener,
-  bkEventPackage = 'org.bukkit.event.';
+  bkRegisteredListener = org.bukkit.plugin.RegisteredListener;
 
 var nashorn = (typeof Java != 'undefined');
 
@@ -15,7 +14,7 @@ function getHandlerListForEventType( eventType ){
     //so to avoid this problem, call getHandlerList using java.lang.reflect
     //methods
     clazz = eventType['class'];
-    result = clazz.getMethod("getHandlerList").invoke(null);
+    result = clazz.getMethod('getHandlerList').invoke(null);
 
   } else { 
     result = eventType.getHandlerList();

src/main/js/lib/events-canary.js

@@ -1,8 +1,6 @@
 /*global nashorn, exports, require, Packages, __plugin*/
 var cmPriority = Packages.net.canarymod.plugin.Priority,
   cmCanary = Packages.net.canarymod.Canary,
-  cmDispatcher = Packages.net.canarymod.hook.Dispatcher,
-  cmRegisteredPluginListener = Packages.net.canarymod.plugin.RegisteredPluginListener,
   cmPluginListener = Packages.net.canarymod.plugin.PluginListener;
 var cmHookExecutor = cmCanary.hooks();
 
@@ -13,8 +11,7 @@ exports.on = function(
   handler,   
   /* (optional) String (CRITICAL, HIGH, NORMAL, LOW, PASSIVE), */
   priority   ) {
-  var handlerList,
-    regd,
+  var regd,
     eventExecutor;
 
   if ( typeof priority == 'undefined' ) {

src/main/js/lib/events.js

@@ -109,4 +109,4 @@ if (__plugin.canary){
 }
 for ( var func in helper ) {
   module.exports[func] = helper[func];
-};
+}

src/main/js/lib/find.js

@@ -4,10 +4,10 @@ module.exports = function find(dir, filter) {
   var result = [];
   function recurse( dir, store ) {
     var files, 
-	len,
-	i,
-	file,
-	dirfile = new File( dir );
+      len,
+      i,
+      file,
+      dirfile = new File( dir );
 
     if ( typeof filter == 'undefined' ) {
       files = dirfile.list();

src/main/js/lib/js-patch.js

@@ -13,28 +13,28 @@ module.exports = function( $ ) {
     Function.prototype.bind = (function (slice){
       // (C) WebReflection - Mit Style License
       function bind(context) {
-	var self = this; // "trapped" function reference
-	// only if there is more than an argument
+        var self = this; // "trapped" function reference
+        // only if there is more than an argument
         // we are interested into more complex operations
         // this will speed up common bind creation
         // avoiding useless slices over arguments
-	if (1 < arguments.length) {
-	  // extra arguments to send by default
+        if (1 < arguments.length) {
+          // extra arguments to send by default
           var $arguments = slice.call(arguments, 1);
           return function () {
             return self.apply(
               context,
               // thanks @kangax for this suggestion
               arguments.length ?
-              // concat arguments with those received
-              $arguments.concat(slice.call(arguments)) :
-              // send just arguments, no concat, no slice
-              $arguments
+                // concat arguments with those received
+      $arguments.concat(slice.call(arguments)) :
+                // send just arguments, no concat, no slice
+                $arguments
             );
           };
         }
-	// optimized callback
-	return function () {
+        // optimized callback
+        return function () {
           // speed up when function is called without arguments
           return arguments.length ? self.apply(context, arguments) : self.call(context);
         };
@@ -52,8 +52,8 @@ module.exports = function( $ ) {
 
   return function unitTest( console ) {
     /*
-     sanity tests 
-     */
+      sanity tests 
+    */
     $.setTimeout(function(){
       console.log('js-patch setTimeout() test complete');
     },100);
@@ -66,10 +66,10 @@ module.exports = function( $ ) {
     var clearAfterRuns = $.setInterval(function(){
       runs --;
       if (runs == 0){
-	$.clearInterval(clearAfterRuns);
+        $.clearInterval(clearAfterRuns);
       }
       if (runs < 0){
-	console.error('js-patch clearInterval test failed.');
+        console.error('js-patch clearInterval test failed.');
       }
     },100);
   };