incremental fixes

Author: tonyyli-wandb

pyproject.toml

@@ -182,6 +182,8 @@ select = [
     "C90",    # mccabe
     "UP",     # pyupgrade
     "T20",    # flake8-print
+    "TC004",  # flake8-type-checking
+    "TC005",  # flake8-type-checking
     "RUF100", # unused-noqa
 
     # tryceratops

wandb/apis/public/jobs.py

@@ -743,6 +743,8 @@ def create(
             template_variables: Optional dictionary for template variables
                 used in the resource configuration.
         """
+        from wandb.apis.public import Api
+
         public_api = Api()
         return public_api.create_run_queue(
             name, resource, entity, prioritization_mode, config, template_variables

wandb/automations/_filters/run_states.py

@@ -35,6 +35,8 @@ class StateFilter(GQLBase):  # from: RunStateFilter
 
     @property
     def event_type(self) -> EventType:
+        from wandb.automations import EventType
+
         return EventType.RUN_STATE
 
     @field_validator("states", mode="after")

wandb/sdk/artifacts/storage_policies/wandb_storage_policy.py

@@ -130,6 +130,8 @@ def load_file(
                 closed when the artifact download completes. If this is `None`,
                 download the file serially.
         """
+        from requests import HTTPError
+
         if dest_path is not None:
             self._cache._override_cache_path = dest_path
 
@@ -172,7 +174,7 @@ def fetch_fresh_url() -> str:
             # Serial download
             try:
                 response = self._session.get(url, stream=True)
-            except requests.HTTPError:
+            except HTTPError:
                 # Signed URL might have expired, fall back to fetching it one by one.
                 manifest_entry._download_url = None
 

wandb/sdk/lib/gitlib.py

@@ -16,7 +16,7 @@
         Repo,
     )
 except ImportError:
-    Repo = None  # type: ignore
+    pass
 
 if TYPE_CHECKING:
     from git import Repo
@@ -45,7 +45,9 @@ def __init__(
 
     def _init_repo(self) -> Repo | None:
         self._repo_initialized = True
-        if Repo is None:
+        try:
+            from git import Repo
+        except ImportError:
             return None
         if self.remote_name is None:
             return None

wandb/sdk/wandb_init.py

@@ -22,7 +22,6 @@
 import tempfile
 import time
 from collections.abc import Iterable, Iterator, Sequence
-from typing import TYPE_CHECKING
 
 from typing_extensions import Any, Literal, Protocol, Self
 
@@ -49,9 +48,6 @@
 from .wandb_run import Run, TeardownHook, TeardownStage
 from .wandb_settings import Settings
 
-if TYPE_CHECKING:
-    import wandb.jupyter
-
 
 def _huggingface_version() -> str | None:
     if "transformers" in sys.modules:

wandb/sdk/wandb_run.py

@@ -96,16 +96,16 @@
 
     import torch  # type: ignore [import-not-found]
 
-    import wandb.sdk.backend.backend
-    import wandb.sdk.interface.interface_queue
     from wandb.apis.public import Api as PublicApi
     from wandb.proto.wandb_internal_pb2 import (
         GetSummaryResponse,
         InternalMessagesResponse,
         SampledHistoryResponse,
     )
-    from wandb.sdk.artifacts.artifact import Artifact
 
+    from .artifacts.artifact import Artifact
+    from .backend.backend import Backend
+    from .interface.interface_queue import InterfaceQueue
     from .wandb_settings import Settings
 
     class GitSourceDict(TypedDict):
@@ -526,8 +526,8 @@ class Run:
 
     _teardown_hooks: list[TeardownHook]
 
-    _backend: wandb.sdk.backend.backend.Backend | None
-    _internal_run_interface: wandb.sdk.interface.interface_queue.InterfaceQueue | None
+    _backend: Backend | None
+    _internal_run_interface: InterfaceQueue | None
     _wl: _WandbSetup | None
 
     _out_redir: redirect.RedirectBase | None
@@ -1619,13 +1619,10 @@ def _tensorboard_callback(
     def _set_library(self, library: _WandbSetup) -> None:
         self._wl = library
 
-    def _set_backend(self, backend: wandb.sdk.backend.backend.Backend) -> None:
+    def _set_backend(self, backend: Backend) -> None:
         self._backend = backend
 
-    def _set_internal_run_interface(
-        self,
-        interface: wandb.sdk.interface.interface_queue.InterfaceQueue,
-    ) -> None:
+    def _set_internal_run_interface(self, interface: InterfaceQueue) -> None:
         self._internal_run_interface = interface
 
     def _set_teardown_hooks(self, hooks: list[TeardownHook]) -> None: