I've fixed an issue in the elasticstack_kibana_slo resource where the slo_id field wasn't being properly checked. Previously, if you provided an ID that was too short, too long, or had invalid characters, it could cause errors when communicating with the API.

Here's what I've done:

1.  I've updated the definition for `slo_id` in `internal/kibana/slo.go`:
    *   The description now clearly states the ID must be between 8 and 48 characters.
    *   I've added a check to ensure the `slo_id` meets this length requirement and only contains letters, numbers, hyphens, and underscores.

2.  I've also added a new automated check in `internal/kibana/slo_test.go`. This makes sure that the system now correctly rejects `slo_id` values that are:
    *   Too short
    *   Too long
    *   Contain invalid characters
    And that it provides you with the right error message in these cases.

Author: google-labs-jules[bot]

internal/kibana/slo.go

@@ -3,6 +3,7 @@ package kibana
 import (
 	"context"
 	"fmt"
+	"regexp"
 
 	"github.com/elastic/terraform-provider-elasticstack/generated/slo"
 	"github.com/elastic/terraform-provider-elasticstack/internal/clients"
@@ -81,11 +82,15 @@ func getSchema() map[string]*schema.Schema {
 
 	return map[string]*schema.Schema{
 		"slo_id": {
-			Description: "An ID (8 and 36 characters). If omitted, a UUIDv1 will be generated server-side.",
+			Description: "An ID (8 and 48 characters). If omitted, a UUIDv1 will be generated server-side.",
 			Type:        schema.TypeString,
 			Optional:    true,
 			Computed:    true,
 			ForceNew:    true,
+			ValidateFunc: validation.StringMatch(
+				regexp.MustCompile("^[a-zA-Z0-9_-]{8,48}$"),
+				"slo_id must be between 8 and 48 characters and contain only letters, numbers, hyphens, and underscores",
+			),
 		},
 		"name": {
 			Description: "The name of the SLO.",

internal/kibana/slo_test.go

@@ -21,6 +21,105 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
 )
 
+const testAccResourceKibanaSloInvalidIdTooShort = `
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_kibana_slo" "test_slo_short_id" {
+  slo_id      = "short"
+  name        = "Test SLO Too Short"
+  description = "Test description for SLO with too short ID"
+  kql_custom_indicator {
+    index = "logs-*"
+    good = "response_time < 100"
+    total = "*"
+  }
+  time_window {
+    duration = "7d"
+    type = "rolling"
+  }
+  budgeting_method = "occurrences"
+  objective {
+    target = 0.99
+  }
+}
+`
+
+const testAccResourceKibanaSloInvalidIdTooLong = `
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_kibana_slo" "test_slo_long_id" {
+  slo_id      = "thisidistoolongandoverfortyeightcharacterslonggggg12345" // 53 chars
+  name        = "Test SLO Too Long"
+  description = "Test description for SLO with too long ID"
+  kql_custom_indicator {
+    index = "logs-*"
+    good = "response_time < 200"
+    total = "*"
+  }
+  time_window {
+    duration = "14d"
+    type = "rolling"
+  }
+  budgeting_method = "occurrences"
+  objective {
+    target = 0.995
+  }
+}
+`
+
+const testAccResourceKibanaSloInvalidIdChars = `
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_kibana_slo" "test_slo_invalid_chars_id" {
+  slo_id      = "invalid!id@#"
+  name        = "Test SLO Invalid Chars"
+  description = "Test description for SLO with invalid characters in ID"
+  kql_custom_indicator {
+    index = "logs-*"
+    good = "response_time < 300"
+    total = "*"
+  }
+  time_window {
+    duration = "30d"
+    type = "rolling"
+  }
+  budgeting_method = "occurrences"
+  objective {
+    target = 0.999
+  }
+}
+`
+
+func TestAccResourceKibanaSlo_slo_id_validation(t *testing.T) {
+	resource.Test(t, resource.TestCase{
+		PreCheck:                 func() { acctest.PreCheck(t) },
+		ProtoV6ProviderFactories: acctest.Providers,
+		Steps: []resource.TestStep{
+			{
+				Config:      testAccResourceKibanaSloInvalidIdTooShort,
+				ExpectError: regexp.MustCompile("slo_id must be between 8 and 48 characters and contain only letters, numbers, hyphens, and underscores"),
+			},
+			{
+				Config:      testAccResourceKibanaSloInvalidIdTooLong,
+				ExpectError: regexp.MustCompile("slo_id must be between 8 and 48 characters and contain only letters, numbers, hyphens, and underscores"),
+			},
+			{
+				Config:      testAccResourceKibanaSloInvalidIdChars,
+				ExpectError: regexp.MustCompile("slo_id must be between 8 and 48 characters and contain only letters, numbers, hyphens, and underscores"),
+			},
+		},
+	})
+}
+
 func TestAccResourceSlo(t *testing.T) {
 	// This test exposes a bug in Kibana present in 8.11.x
 	slo8_9Constraints, err := version.NewConstraint(">=8.9.0,!=8.11.0,!=8.11.1,!=8.11.2,!=8.11.3,!=8.11.4")