allow nulls in CompactRange() fixing #67

Author: warrenfalk

RocksDbSharp/RocksDb.cs

@@ -295,16 +295,16 @@ public void IngestExternalFiles(string[] files, IngestExternalFileOptions ingest
         public void CompactRange(byte[] start, byte[] limit, ColumnFamilyHandle cf = null)
         {
             if (cf == null)
-                Native.Instance.rocksdb_compact_range(Handle, start, (UIntPtr)start.GetLongLength(0), limit, (UIntPtr)limit.GetLongLength(0));
+                Native.Instance.rocksdb_compact_range(Handle, start, (UIntPtr)(start?.GetLongLength(0) ?? 0L), limit, (UIntPtr)(limit?.GetLongLength(0) ?? 0L));
             else
-                Native.Instance.rocksdb_compact_range_cf(Handle, cf.Handle, start, (UIntPtr)start.GetLongLength(0), limit, (UIntPtr)limit.GetLongLength(0));
+                Native.Instance.rocksdb_compact_range_cf(Handle, cf.Handle, start, (UIntPtr)(start?.GetLongLength(0) ?? 0L), limit, (UIntPtr)(limit?.GetLongLength(0) ?? 0L));
         }
 
         public void CompactRange(string start, string limit, ColumnFamilyHandle cf = null, Encoding encoding = null)
         {
             if (encoding == null)
                 encoding = Encoding.UTF8;
-            CompactRange(encoding.GetBytes(start), encoding.GetBytes(limit), cf);
+            CompactRange(start == null ? null : encoding.GetBytes(start), limit == null ? null : encoding.GetBytes(limit), cf);
         }
     }
 }

tests/RocksDbSharpTest/FunctionalTests.cs

@@ -170,6 +170,14 @@ public void FunctionalTest()
                 Assert.Null(cpdb.Get("four"));
             }
 
+            // Test various operations
+            using (var db = RocksDb.Open(options, path))
+            {
+                // Nulls should be allowed here
+                db.CompactRange((byte[])null, (byte[])null);
+                db.CompactRange((string)null, (string)null);
+            }
+
             // Test with column families
             var optionsCf = new DbOptions()
                 .SetCreateIfMissing(true)