fix

Author: HerrCai0907

bin/cli.js

@@ -80,10 +80,10 @@ const testOption = {
 };
 
 start_unit_test(testOption)
-  .then((success) => {
-    if (!success) {
+  .then((returnCode) => {
+    if (returnCode !== 0) {
       console.error(chalk.redBright("Test Failed") + "\n");
-      exit(1);
+      exit(returnCode);
     }
   })
   .catch((e) => {

src/core/compile.ts

@@ -1,6 +1,6 @@
-import { main } from "assemblyscript/asc";
 import { join, relative } from "node:path";
 import { findRoot } from "../utils/pathResolver.js";
+import { ascMain } from "../utils/ascWrapper.js";
 
 export async function compile(testCodePaths: string[], outputFolder: string, compileFlags: string): Promise<string[]> {
   const wasm: string[] = [];
@@ -25,12 +25,7 @@ export async function compile(testCodePaths: string[], outputFolder: string, com
       const argv = compileFlags.split(" ");
       ascArgv = ascArgv.concat(argv);
     }
-    const { error, stderr } = await main(ascArgv);
-    if (error) {
-      // eslint-disable-next-line @typescript-eslint/no-base-to-string
-      console.log(stderr.toString());
-      process.exit(2);
-    }
+    await ascMain(ascArgv);
   };
 
   // Here, for-await is more efficient and less memory cost than Promise.all()

src/core/precompile.ts

@@ -3,12 +3,12 @@
  */
 
 import ignore from "ignore";
-import { main } from "assemblyscript/asc";
 import { join, relative, resolve } from "node:path";
 import { getIncludeFiles } from "../utils/pathResolver.js";
 import { SourceFunctionInfo, UnittestPackage } from "../interface.js";
 import { projectRoot } from "../utils/projectRoot.js";
 import assert from "node:assert";
+import { ascMain } from "../utils/ascWrapper.js";
 
 // eslint-disable-next-line sonarjs/cognitive-complexity
 export async function precompile(
@@ -91,12 +91,7 @@ async function transform(transformFunction: string, codePath: string, flags: str
     const argv = flags.split(" ");
     ascArgv = ascArgv.concat(argv);
   }
-  const { error, stderr } = await main(ascArgv);
-  if (error) {
-    // eslint-disable-next-line @typescript-eslint/no-base-to-string
-    console.log(stderr.toString());
-    process.exit(2);
-  }
+  await ascMain(ascArgv);
   collectCallback();
 }
 

src/index.ts

@@ -8,6 +8,7 @@ import { execWasmBinaries } from "./core/execute.js";
 import { generateReport, reportConfig } from "./generator/index.js";
 import { TestOption } from "./interface.js";
 import { join } from "node:path";
+import { CompilationError } from "./utils/ascWrapper.js";
 
 const { readFileSync, emptydirSync } = pkg;
 
@@ -30,10 +31,7 @@ export function validateArgument(includes: unknown, excludes: unknown) {
   }
 }
 
-/**
- * main function of unit-test, will throw Exception in most condition except job carsh
- */
-export async function start_unit_test(options: TestOption): Promise<boolean> {
+async function startUniTestImpl(options: TestOption): Promise<number> {
   const failurePath = join(options.outputFolder, "failures.json");
   let failedTestCases: string[] = [];
   if (options.onlyFailures) {
@@ -85,6 +83,18 @@ export async function start_unit_test(options: TestOption): Promise<boolean> {
     reportConfig.errorLimit = options.errorLimit || reportConfig.errorLimit;
     generateReport(options.mode, options.outputFolder, fileCoverageInfo);
   }
+  return executedResult.fail === 0 ? 0 : 1;
+}
 
-  return executedResult.fail === 0;
+export async function start_unit_test(options: TestOption): Promise<number> {
+  try {
+    return await startUniTestImpl(options);
+  } catch (error) {
+    if (error instanceof CompilationError) {
+      console.log(error.message);
+      return 2;
+    }
+    // unknown exception.
+    throw error;
+  }
 }

src/utils/ascWrapper.ts

@@ -0,0 +1,20 @@
+import { createMemoryStream, main } from "assemblyscript/asc";
+
+export const compiler = {
+  compile: main,
+};
+
+export class CompilationError extends Error {
+  constructor(errorMessage: string) {
+    super(errorMessage);
+    this.name = "CompilationError";
+  }
+}
+
+export async function ascMain(ascArgv: string[]) {
+  let stderr = createMemoryStream();
+  const { error } = await compiler.compile(ascArgv, { stderr });
+  if (error) {
+    throw new CompilationError(stderr.toString());
+  }
+}

tests/ts/test/core/throwError.test.ts

@@ -1,40 +1,27 @@
 // eslint-disable-next-line n/no-extraneous-import
 import { jest } from "@jest/globals";
-
-jest.unstable_mockModule("assemblyscript/asc", () => ({
-  main: jest.fn(() => {
-    return {
-      error: new Error("mock asc.main() error"),
-      stderr: "mock asc.main() error",
-    };
-  }),
-}));
-
-const { precompile } = await import("../../../../src/core/precompile.js");
-const { compile } = await import("../../../../src/core/compile.js");
-
-let exitSpy: any | null = null;
+import { precompile } from "../../../../src/core/precompile.js";
+import { compile } from "../../../../src/core/compile.js";
+import { compiler } from "../../../../src/utils/ascWrapper.js";
 
 beforeEach(() => {
-  exitSpy = jest.spyOn(process, "exit").mockImplementation(() => {
-    throw new Error("process.exit");
+  jest.spyOn(compiler, "compile").mockImplementation(async () => {
+    throw new Error("mock asc.main() error");
   });
 });
 
 afterEach(() => {
-  exitSpy!.mockRestore();
+  jest.clearAllMocks();
 });
 
 test("transform error", async () => {
   await expect(async () => {
-    await precompile(["tests/ts/fixture/transformFunction.ts"], [], ["non-exist.ts"], undefined, [], true, "");
-  }).rejects.toThrow("process.exit");
-  expect(exitSpy).toHaveBeenCalled();
+    await precompile(["tests/ts/fixture/transformFunction.ts"], [], undefined, undefined, [], true, "");
+  }).rejects.toThrow("mock asc.main() error");
 });
 
 test("compile error", async () => {
   await expect(async () => {
     await compile(["non-exist.ts"], "mockFolder", "");
-  }).rejects.toThrow("process.exit");
-  expect(exitSpy).toHaveBeenCalled();
+  }).rejects.toThrow("mock asc.main() error");
 });