[CI] Add windows arm64 spectest to public github (#764)

Author: Changqing-JING

.github/workflows/public_github.yml

@@ -0,0 +1,52 @@
+name: Public GitHub
+
+on:
+  push:
+    branches:
+      - master
+      - develop
+      - 'release/*'
+  pull_request:
+    branches:
+      - master
+      - develop
+      - 'release/*'
+  workflow_dispatch:
+
+concurrency:
+  group: "${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}"
+  cancel-in-progress: true
+
+jobs:
+  aarch64_windows_cmake_build_test:
+    runs-on: windows-11-arm
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - Compiler_type: aarch64_debug_msvc
+            cmake_arguments: -DVB_ENABLE_DEV_FEATURE=OFF -DENABLE_MSVC_PARALLEL=0 -DENABLE_WERROR=1 -A ARM64 -DENABLE_SPECTEST=1 -DENABLE_DEMO=1
+            Build_type: Debug
+          - Compiler_type: aarch64_relwithdebinfo_msvc
+            cmake_arguments: -DVB_ENABLE_DEV_FEATURE=OFF -DENABLE_MSVC_PARALLEL=0 -DENABLE_WERROR=1 -A ARM64 -DENABLE_SPECTEST=1 -DENABLE_DEMO=1
+            Build_type: RelWithDebInfo
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: true
+      # Here x86_64 executable file can be used because windows has instruction emulator.
+      - name: Install wabt
+        run: |
+          aria2c https://github.com/WebAssembly/wabt/releases/download/1.0.36/wabt-1.0.36-windows.tar.gz
+          tar -xzf wabt-1.0.36-windows.tar.gz
+          mv wabt-1.0.36 C:\wabt-1.0.36
+          echo "C:\wabt-1.0.36\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
+      - name: gen testcase
+        run: python tests/spectest.py
+      - name: Build and test
+        run: |
+          mkdir build
+          cd build
+          cmake .. ${{ matrix.cmake_arguments }}
+          cmake --build . --config ${{ matrix.Build_type }}
+          ctest --verbose -C ${{ matrix.Build_type }}

cmake/AutoSelectBackendTarget.cmake

@@ -1,9 +1,9 @@
 function(AutoSelectBackendTarget)	
 	if(${CMAKE_GENERATOR} MATCHES "Visual Studio")
 		message("Visual Studio Setting")
-		if(${CMAKE_GENERATOR_PLATFORM} MATCHES "ARM64")
+		if(${CMAKE_GENERATOR_PLATFORM} MATCHES "[Aa][Rr][Mm]64")
 			set(NOW_TARGET "aarch64")
-		elseif(${CMAKE_GENERATOR_PLATFORM} MATCHES "ARM")
+		elseif(${CMAKE_GENERATOR_PLATFORM} MATCHES "[Aa][Rr][Mm]")
 			set(NOW_TARGET "aarch32")
 		elseif(${CMAKE_GENERATOR_PLATFORM} MATCHES "x64")
 			set(NOW_TARGET "x86_64")

src/utils/SignalFunctionWrapper.hpp

@@ -35,6 +35,32 @@ static_assert(false, "OS not supported");
 #endif
 
 namespace vb {
+
+///
+/// @brief RAII wrapper to set and reset runtime pointer for signal handling
+///
+/// Sets the thread-local runtime pointer in constructor and resets to nullptr in destructor
+///
+class ScopedRuntimeGuard final {
+public:
+  ///
+  /// @brief Construct and set the runtime pointer
+  ///
+  /// @param runtime The runtime to set
+  ///
+  explicit ScopedRuntimeGuard(Runtime const &runtime) VB_NOEXCEPT;
+
+  ///
+  /// @brief Destructor resets runtime pointer to nullptr
+  ///
+  ~ScopedRuntimeGuard() VB_NOEXCEPT;
+
+  ScopedRuntimeGuard(ScopedRuntimeGuard const &) = delete;
+  ScopedRuntimeGuard &operator=(ScopedRuntimeGuard const &) & = delete;
+  ScopedRuntimeGuard(ScopedRuntimeGuard &&) = delete;
+  ScopedRuntimeGuard &operator=(ScopedRuntimeGuard &&) & = delete;
+};
+
 ///
 /// @brief A wrapper to run Wasm function inside signal handler
 ///
@@ -51,7 +77,7 @@ class SignalFunctionWrapper final {
   /// @throws std::runtime_error signal handler setup failed
   ///
   static inline void start(Runtime &runtime) {
-    trySetRuntime(runtime);
+    ScopedRuntimeGuard const guard{runtime};
     SignalFunction::call_raw(start_wrapper, runtime);
   }
 
@@ -77,7 +103,7 @@ class SignalFunctionWrapper final {
   template <size_t NumReturnValue, typename... FunctionArguments>
   static std::array<WasmValue, NumReturnValue> call(ModuleFunction<NumReturnValue, FunctionArguments...> const &function,
                                                     FunctionArguments... args) VB_THROW {
-    trySetRuntime(function.getRuntime());
+    ScopedRuntimeGuard const guard{function.getRuntime()};
     return SignalFunction::call_raw<NumReturnValue>(function, args...);
   }
 
@@ -91,7 +117,7 @@ class SignalFunctionWrapper final {
   /// @throws std::runtime_error signal handler setup failed
   ///
   static void call(RawModuleFunction const &function, uint8_t const *const serializedArgs, uint8_t *const results) {
-    trySetRuntime(function.getRuntime());
+    ScopedRuntimeGuard const guard{function.getRuntime()};
     return SignalFunction::call_raw(callRawModuleFunction_wrapper, function, serializedArgs, results);
   }
 
@@ -105,7 +131,7 @@ class SignalFunctionWrapper final {
   /// @throws std::runtime_error signal handler setup failed
   ///
   static void call(RawModuleFunction const &function, WasmValue const *const serializedArgs, WasmValue *const results) {
-    trySetRuntime(function.getRuntime());
+    ScopedRuntimeGuard const guard{function.getRuntime()};
     return SignalFunction::call_raw(callRawModuleFunction_wrapper, function, pCast<uint8_t const *const>(serializedArgs),
                                     pCast<uint8_t *const>(results));
   }
@@ -131,18 +157,6 @@ class SignalFunctionWrapper final {
 #endif
 
 private:
-  ///
-  /// @brief Set the runtime pointer of current thread
-  ///
-  /// @param runtime
-  /// @note If signal handler is not required by current build config, this function will do nothing
-  static void trySetRuntime(Runtime const &runtime) VB_NOEXCEPT {
-#if !LINEAR_MEMORY_BOUNDS_CHECKS || !ACTIVE_STACK_OVERFLOW_CHECK
-    pRuntime_ = &runtime;
-#else
-    static_cast<void>(runtime);
-#endif
-  }
   ///
   /// @brief wrap the raw module function in a function type
   ///
@@ -191,8 +205,25 @@ class SignalFunctionWrapper final {
   static void probeLinearMemoryOffset() VB_NOEXCEPT;
 #endif
 
-  friend SignalFunction; ///< Allow OS specific signal function to access private members
+  friend SignalFunction;     ///< Allow OS specific signal function to access private members
+  friend ScopedRuntimeGuard; ///< Allow RAII guard to access pRuntime_
 };
 
+// ScopedRuntimeGuard implementation (after SignalFunctionWrapper is complete)
+// coverity[autosar_cpp14_a3_1_5_violation]
+inline ScopedRuntimeGuard::ScopedRuntimeGuard(Runtime const &runtime) VB_NOEXCEPT {
+  static_cast<void>(runtime);
+#if !LINEAR_MEMORY_BOUNDS_CHECKS || !ACTIVE_STACK_OVERFLOW_CHECK
+  SignalFunctionWrapper::pRuntime_ = &runtime;
+#endif
+}
+// coverity[autosar_cpp14_a3_1_5_violation]
+// coverity[autosar_cpp14_a12_7_1_violation]
+inline ScopedRuntimeGuard::~ScopedRuntimeGuard() VB_NOEXCEPT {
+#if !LINEAR_MEMORY_BOUNDS_CHECKS || !ACTIVE_STACK_OVERFLOW_CHECK
+  SignalFunctionWrapper::pRuntime_ = nullptr;
+#endif
+}
+
 } // namespace vb
 #endif