add more tests

Author: wasm-forge

Cargo.toml

@@ -10,7 +10,7 @@ repository = "https://github.com/wasm-forge/ic-wasi-polyfill"
 [dependencies]
 ic-cdk = "0.17.1"
 ic-stable-structures = "0.6.7"
-#stable-fs = "0.7"
+#stable-fs = "0.8"
 stable-fs = { path = "../stable-fs"}
 
 rand = "0.9.0"

src/lib.rs

@@ -407,8 +407,8 @@ pub unsafe extern "C" fn __ic_custom_path_open(
     path_len: i32,
 
     oflags: i32,
-    fs_rights_base: i64,
-    fs_rights_inheriting: i64,
+    fs_rights_base: wasi::Rights,
+    fs_rights_inheriting: wasi::Rights,
 
     fdflags: i32,
     res: *mut Fd,
@@ -433,8 +433,8 @@ pub unsafe extern "C" fn __ic_custom_path_open(
 
         let fd_stat = FdStat {
             flags: FdFlags::from_bits_truncate(fdflags as u16),
-            rights_base: fs_rights_base as u64,
-            rights_inheriting: fs_rights_inheriting as u64,
+            rights_base: fs_rights_base,
+            rights_inheriting: fs_rights_inheriting,
         };
 
         let open_flags = OpenFlags::from_bits_truncate(oflags as u16);

src/test/common.rs

@@ -20,8 +20,8 @@ pub fn create_test_file_with_content(parent_fd: Fd, file_name: &str, content: Ve
             0,
             new_file_name.as_ptr(),
             new_file_name.len() as i32,
-            1 + 4 + 8,
-            0,
+            (wasi::OFLAGS_CREAT | wasi::OFLAGS_TRUNC | wasi::OFLAGS_EXCL) as i32,
+            wasi::RIGHTS_FD_WRITE | wasi::RIGHTS_FD_READ,
             0,
             0,
             (&mut file_fd) as *mut u32,

src/test/fd_filestat_set.rs

@@ -0,0 +1,118 @@
+use crate::{init, test::common::libc, wasi};
+
+unsafe fn test_fd_filestat_set_size_rw(dir_fd: wasi::Fd) {
+    // Create a file in the scratch directory, opened read/write
+    let file_fd = wasi::path_open(
+        dir_fd,
+        0,
+        "file",
+        wasi::OFLAGS_CREAT,
+        wasi::RIGHTS_FD_READ | wasi::RIGHTS_FD_WRITE,
+        0,
+        0,
+    )
+    .expect("failed to create file");
+
+    assert!(
+        file_fd > libc::STDERR_FILENO as wasi::Fd,
+        "file descriptor range check",
+    );
+
+    // Check file size
+    let stat = wasi::fd_filestat_get(file_fd).expect("failed filestat");
+    assert_eq!(stat.size, 0, "file size should be 0");
+
+    // Check fd_filestat_set_size
+    wasi::fd_filestat_set_size(file_fd, 100).expect("fd_filestat_set_size");
+
+    let stat = wasi::fd_filestat_get(file_fd).expect("failed filestat 2");
+    assert_eq!(stat.size, 100, "file size should be 100");
+
+    wasi::fd_close(file_fd).expect("failed to close fd");
+    wasi::path_unlink_file(dir_fd, "file").expect("failed to remove file");
+}
+
+unsafe fn test_fd_filestat_set_size_ro(dir_fd: wasi::Fd) {
+    // Create a file in the scratch directory. Creating a file implies opening it for writing, so
+    // we have to close and re-open read-only to observe read-only behavior.
+    let file_fd = wasi::path_open(dir_fd, 0, "file", wasi::OFLAGS_CREAT, 0, 0, 0)
+        .expect("failed to create file");
+    wasi::fd_close(file_fd).expect("failed to close fd");
+
+    // Open the created file read-only
+    let file_fd = wasi::path_open(dir_fd, 0, "file", 0, wasi::RIGHTS_FD_READ, 0, 0)
+        .expect("failed to create file");
+
+    // Check file size
+    let stat = wasi::fd_filestat_get(file_fd).expect("failed filestat");
+    assert_eq!(stat.size, 0, "file size should be 0");
+
+    // Check fd_filestat_set_size on a file opened read-only fails with EINVAL, like ftruncate is defined to do on posix
+    assert_eq!(
+        wasi::fd_filestat_set_size(file_fd, 100)
+            .expect_err("fd_filestat_set_size should error when file is opened read-only"),
+        wasi::ERRNO_INVAL
+    );
+
+    let stat = wasi::fd_filestat_get(file_fd).expect("failed filestat 2");
+    assert_eq!(stat.size, 0, "file size should remain 0");
+
+    wasi::fd_close(file_fd).expect("failed to close fd");
+    wasi::path_unlink_file(dir_fd, "file").expect("failed to remove file");
+}
+
+unsafe fn test_fd_filestat_set_times(dir_fd: wasi::Fd, rights: wasi::Rights) {
+    let resolution = wasi::clock_res_get(wasi::CLOCKID_MONOTONIC).unwrap();
+
+    // Create a file in the scratch directory. OFLAGS_CREAT implies opening for writing, so we will
+    // close it and re-open with the desired rights (FD_READ for read only, FD_READ | FD_WRITE for
+    // readwrite)
+    let file_fd = wasi::path_open(dir_fd, 0, "file", wasi::OFLAGS_CREAT, 0, 0, 0)
+        .expect("failed to create file");
+
+    wasi::fd_close(file_fd).expect("failed to close fd");
+
+    // Open the file with the rights given.
+    let file_fd =
+        wasi::path_open(dir_fd, 0, "file", 0, rights, 0, 0).expect("failed to create file");
+
+    let stat = wasi::fd_filestat_get(file_fd).expect("failed filestat 2");
+
+    // Check fd_filestat_set_times
+    let old_atim = stat.atim;
+    let new_mtim = stat.mtim - resolution * 2;
+
+    wasi::fd_filestat_set_times(file_fd, new_mtim, new_mtim, wasi::FSTFLAGS_MTIM)
+        .expect("fd_filestat_set_times");
+
+    let stat = wasi::fd_filestat_get(file_fd).expect("failed filestat 3");
+    assert_eq!(stat.size, 0, "file size should remain unchanged at 0");
+
+    // Support accuracy up to at least 1ms
+    assert_eq!(stat.mtim, new_mtim, "mtim should change");
+
+    assert_eq!(stat.atim, old_atim, "atim should not change");
+
+    // let status = wasi_fd_filestat_set_times(file_fd, new_mtim, new_mtim, wasi::FILESTAT_SET_MTIM | wasi::FILESTAT_SET_MTIM_NOW);
+    // assert_eq!(status, wasi::EINVAL, "ATIM & ATIM_NOW can't both be set");
+
+    wasi::fd_close(file_fd).expect("failed to close fd");
+    wasi::path_unlink_file(dir_fd, "file").expect("failed to remove file");
+}
+
+#[test]
+fn fd_filestat_test_tests() {
+    init(&[], &[]);
+
+    // Open scratch directory
+    let dir_fd = 3; // root folder
+
+    // Run the tests.
+    unsafe { test_fd_filestat_set_size_rw(dir_fd) }
+    unsafe { test_fd_filestat_set_size_ro(dir_fd) }
+
+    // test to work on unix-like file system
+    unsafe { test_fd_filestat_set_times(dir_fd, wasi::RIGHTS_FD_READ) }
+
+    unsafe { test_fd_filestat_set_times(dir_fd, wasi::RIGHTS_FD_READ | wasi::RIGHTS_FD_WRITE) }
+}