Skip to content

Commit d2c0771

Browse files
lxfonteslxfontes
committed
chore: lint
Signed-off-by: Lucas Fontes <[email protected]>
1 parent 3fb6940 commit d2c0771

File tree

9 files changed

+34
-30
lines changed

9 files changed

+34
-30
lines changed

‎.github/workflows/wasmbus-go.yaml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,16 +63,16 @@ jobs:
6363

6464
- name: wasmbus
6565
working-directory: wasmbus
66-
run: go test -v -wash-output
66+
run: go test -cover -v -wash-output
6767

6868
- name: wasmbus/control
6969
working-directory: wasmbus/control
70-
run: go test -v -wash-output
70+
run: go test -cover -v -wash-output
7171

7272
- name: wasmbus/wadm
7373
working-directory: wasmbus/wadm
74-
run: go test -v -wash-output
74+
run: go test -cover -v -wash-output
7575

7676
- name: wasmbus/events
7777
working-directory: wasmbus/events
78-
run: go test -v -wash-output
78+
run: go test -cover -v -wash-output

‎wasmbus/client_test.go‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ func TestLatticeRequest(t *testing.T) {
118118
if err != nil {
119119
t.Fatal(err)
120120
}
121-
defer sub.Drain()
121+
defer func() { _ = sub.Drain() }()
122122

123123
var errCh = make(chan error, 1)
124124
go sub.Handle(func(msg *Message) {
@@ -168,13 +168,13 @@ func TestLatticeRequest(t *testing.T) {
168168
if err != nil {
169169
t.Fatal(err)
170170
}
171-
defer sub.Drain()
171+
defer func() { _ = sub.Drain() }()
172172

173173
go sub.Handle(func(msg *Message) {
174174
respMsg := NewMessage(msg.Reply)
175175
respMsg.Header.Set("Content-Type", "bricks")
176176
respMsg.Data = []byte("boom")
177-
bus.Publish(respMsg)
177+
_ = bus.Publish(respMsg)
178178
})
179179
req := NewLatticeRequest(bus, "test", &testMessage{Name: "request"}, testMessage{})
180180
_, err = req.Execute(context.TODO())
@@ -198,7 +198,7 @@ func TestLatticeRequest(t *testing.T) {
198198
if err != nil {
199199
t.Fatal(err)
200200
}
201-
defer sub.Drain()
201+
defer func() { _ = sub.Drain() }()
202202

203203
var errCh = make(chan error, 1)
204204
go sub.Handle(func(msg *Message) {
@@ -211,7 +211,7 @@ func TestLatticeRequest(t *testing.T) {
211211
errCh <- errors.New("pre-request failed")
212212
}
213213
respMsg := NewMessage(msg.Reply)
214-
bus.Publish(respMsg)
214+
_ = bus.Publish(respMsg)
215215
})
216216

217217
req := NewLatticeRequest(bus, "test", &testMessage{Name: "request"}, testMessage{})
@@ -244,7 +244,7 @@ func TestLatticeRequest(t *testing.T) {
244244
if err != nil {
245245
t.Fatal(err)
246246
}
247-
defer sub.Drain()
247+
defer func() { _ = sub.Drain() }()
248248

249249
var errCh = make(chan error, 1)
250250
go sub.Handle(func(msg *Message) {

‎wasmbus/cmd/wasmcloud-rpc/events.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func eventCommand() *cli.Command {
5555
if err != nil {
5656
return err
5757
}
58-
defer subscription.Drain()
58+
defer func() { _ = subscription.Drain() }()
5959

6060
log.Printf("Listening for events on lattice '%s' with pattern '%s'", lattice, pattern)
6161
<-ctx.Done()

‎wasmbus/cmd/wasmcloud-rpc/main.go‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,11 @@ import (
1717
)
1818

1919
var (
20-
titleStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("35"))
21-
keyStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("63"))
22-
valueStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("255"))
23-
oddStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("35"))
24-
evenStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("83"))
25-
borderStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("63"))
20+
titleStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("35"))
21+
keyStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("63"))
22+
valueStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("255"))
23+
oddStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("35"))
24+
evenStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("83"))
2625
)
2726

2827
func renderKv(k, v string) {

‎wasmbus/control/client.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ func (c *Client) HostPing(ctx context.Context, req *HostPingRequest) (*HostPingR
137137
if err != nil {
138138
return nil, err
139139
}
140-
defer sub.Drain()
140+
defer func() { _ = sub.Drain() }()
141141

142142
resp := &HostPingResponse{
143143
Success: true,

‎wasmbus/nats_test.go‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func TestNatsPublish(t *testing.T) {
3838
if err != nil {
3939
t.Fatal(err)
4040
}
41-
defer sub.Drain()
41+
defer func() { _ = sub.Drain() }()
4242
received := make(chan bool)
4343

4444
go sub.Handle(func(msg *Message) {
@@ -92,7 +92,8 @@ func TestNatsSubscribe(t *testing.T) {
9292
if err != nil {
9393
t.Fatal(err)
9494
}
95-
defer sub.Drain()
95+
defer func() { _ = sub.Drain() }()
96+
9697
received := make(chan bool)
9798
go sub.Handle(func(msg *Message) {
9899
if msg.Subject == "success" {
@@ -143,7 +144,7 @@ func TestNatsQueueSubscribe(t *testing.T) {
143144
if err != nil {
144145
t.Fatal(err)
145146
}
146-
defer sub.Drain()
147+
defer func() { _ = sub.Drain() }()
147148
received := make(chan bool)
148149
go sub.Handle(func(msg *Message) {
149150
if msg.Subject == "success" {

‎wasmbus/server.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ func (s *Server) reportError(ctx context.Context, req *Message, err error) {
5050
select {
5151
// We don't want to block the server if the error stream is full or nobody is listening
5252
case s.errorStream <- &ServerError{Context: ctx, Err: err, Request: req}:
53+
default:
5354
}
5455
}
5556

‎wasmbus/server_test.go‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,14 @@ func TestServerRegisterHandler(t *testing.T) {
1919

2020
bus := NewNatsBus(nc)
2121
server := NewServer(bus, "test")
22-
server.RegisterHandler("test", ServerHandlerFunc(func(ctx context.Context, msg *Message) error {
22+
err = server.RegisterHandler("test", ServerHandlerFunc(func(ctx context.Context, msg *Message) error {
2323
reply := NewMessage(msg.Reply)
2424
reply.Data = []byte("hello")
2525
return server.Publish(reply)
2626
}))
27+
if err != nil {
28+
t.Fatal(err)
29+
}
2730

2831
resp, err := server.Request(context.TODO(), NewMessage("test"))
2932
if err != nil {
@@ -34,7 +37,7 @@ func TestServerRegisterHandler(t *testing.T) {
3437
t.Fatalf("want %q, got %q", want, got)
3538
}
3639

37-
resp, err = server.Request(context.TODO(), NewMessage("error"))
40+
_, err = server.Request(context.TODO(), NewMessage("error"))
3841
if err == nil {
3942
t.Fatal("expected NO_RESPONDERS")
4043
}
@@ -51,7 +54,7 @@ func TestServerDrain(t *testing.T) {
5154
bus := NewNatsBus(nc)
5255
server := NewServer(bus, "test")
5356
checkpoint := make(chan bool)
54-
server.RegisterHandler("slow", ServerHandlerFunc(func(ctx context.Context, msg *Message) error {
57+
_ = server.RegisterHandler("slow", ServerHandlerFunc(func(ctx context.Context, msg *Message) error {
5558
close(checkpoint)
5659
<-time.After(200 * time.Millisecond)
5760
return server.Publish(NewMessage(msg.Reply))
@@ -87,9 +90,9 @@ func TestServerErrorStream(t *testing.T) {
8790
server := NewServer(bus, "test")
8891
bomb := errors.New("bomb")
8992
bombCh := make(chan error, 1)
90-
server.RegisterHandler("bomb", ServerHandlerFunc(func(ctx context.Context, msg *Message) error {
93+
_ = server.RegisterHandler("bomb", ServerHandlerFunc(func(ctx context.Context, msg *Message) error {
9194
reply := NewMessage(msg.Reply)
92-
server.Publish(reply)
95+
_ = server.Publish(reply)
9396
return bomb
9497
}))
9598

@@ -134,7 +137,7 @@ func TestRequestHandler(t *testing.T) {
134137
Hello: "world",
135138
}, nil
136139
})
137-
server.RegisterHandler("test", handler)
140+
_ = server.RegisterHandler("test", handler)
138141

139142
rawResp, err := server.Request(context.TODO(), NewMessage("test"))
140143
if err != nil {

‎wasmbus/wadm/types.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,9 @@ type SpreadScalerProperty struct {
235235
}
236236

237237
type Trait struct {
238-
Type TraitType `json:"type" yaml:"type"`
239-
Link *LinkProperty `json:"-" yaml:"-"`
240-
SpreadScaler *SpreadScalerProperty `json:"-" yaml:"-"`
238+
Type TraitType `json:"type" yaml:"type"`
239+
Link *LinkProperty `json:"-" yaml:"-"`
240+
SpreadScaler *SpreadScalerProperty `json:"-" yaml:"-"`
241241
}
242242

243243
type rawTrait struct {

0 commit comments

Comments
 (0)