mark EngineStacks Send and Sync

Robbepop · Robbepop · commit 3085cb17a729 · 2025-10-24T15:50:55.000+02:00
Stack is no longer Send and Sync due to storing temporary NonNull for instance tracking. This is important for performance. However, EngineStacks use Stack in a way that we can safely make it Send and Sync.
diff --git a/crates/wasmi/src/engine/mod.rs b/crates/wasmi/src/engine/mod.rs
@@ -517,6 +517,9 @@ pub struct EngineStacks {
     config: StackConfig,
 }
 
+unsafe impl Send for EngineStacks {} // TODO: write safety docs
+unsafe impl Sync for EngineStacks {} // TODO: write safety docs
+
 impl EngineStacks {
     /// Creates new [`EngineStacks`] with the given [`StackConfig`].
     pub fn new(config: &StackConfig) -> Self {

Original file line number	Diff line number	Diff line change
`@@ -517,6 +517,9 @@ pub struct EngineStacks {`
`517`	`517`	`config: StackConfig,`
`518`	`518`	`}`
`519`	`519`
	`520`	`+unsafe impl Send for EngineStacks {} // TODO: write safety docs`
	`521`	`+unsafe impl Sync for EngineStacks {} // TODO: write safety docs`
	`522`	`+`
`520`	`523`	`impl EngineStacks {`
`521`	`524`	/// Creates new [`EngineStacks`] with the given [`StackConfig`].
`522`	`525`	`pub fn new(config: &StackConfig) -> Self {`