add #[inline(always)] annotations to push_frame API

Robbepop · Robbepop · commit 57f3ae8d90e2 · 2025-11-01T15:51:10.000+01:00
This shows significant performance gains in call intense workloads of ~15%.
diff --git a/crates/wasmi/src/engine/executor/handler/state.rs b/crates/wasmi/src/engine/executor/handler/state.rs
@@ -214,6 +214,7 @@ impl Stack {
         self.values.capacity()
     }
 
+    #[inline(always)]
     pub fn push_frame(
         &mut self,
         caller_ip: Option<Ip>,
@@ -283,6 +284,7 @@ impl ValueStack {
         Sp::new(&mut self.cells, start)
     }
 
+    #[inline(always)]
     fn push(&mut self, start: usize, len_slots: usize, len_params: u16) -> Result<Sp, TrapCode> {
         debug_assert!(usize::from(len_params) <= len_slots);
         if len_slots == 0 {
@@ -343,6 +345,7 @@ impl CallStack {
         top.ip = ip;
     }
 
+    #[inline(always)]
     fn push(
         &mut self,
         caller_ip: Option<Ip>,

Original file line number	Diff line number	Diff line change
`@@ -214,6 +214,7 @@ impl Stack {`
`214`	`214`	`self.values.capacity()`
`215`	`215`	`}`
`216`	`216`
	`217`	`+ #[inline(always)]`
`217`	`218`	`pub fn push_frame(`
`218`	`219`	`&mut self,`
`219`	`220`	`caller_ip: Option<Ip>,`
`@@ -283,6 +284,7 @@ impl ValueStack {`
`283`	`284`	`Sp::new(&mut self.cells, start)`
`284`	`285`	`}`
`285`	`286`
	`287`	`+ #[inline(always)]`
`286`	`288`	`fn push(&mut self, start: usize, len_slots: usize, len_params: u16) -> Result<Sp, TrapCode> {`
`287`	`289`	`debug_assert!(usize::from(len_params) <= len_slots);`
`288`	`290`	`if len_slots == 0 {`
`@@ -343,6 +345,7 @@ impl CallStack {`
`343`	`345`	`top.ip = ip;`
`344`	`346`	`}`
`345`	`347`
	`348`	`+ #[inline(always)]`
`346`	`349`	`fn push(`
`347`	`350`	`&mut self,`
`348`	`351`	`caller_ip: Option<Ip>,`