remove short-circuiting from wasmi_i32_and

Robbepop · Robbepop · commit cfb3f9c13bc9 · 2025-11-13T10:15:51.000+01:00
This is incorrect as demonstrated by the following example:
- `(1 &amp; 2) == 0`
- `(1 != 0) &amp;&amp; (2 != 0) == 1`
diff --git a/crates/wasmi/src/engine/executor/handler/eval.rs b/crates/wasmi/src/engine/executor/handler/eval.rs
@@ -77,7 +77,7 @@ pub fn wasmi_i64_rotr_ssi(lhs: i64, rhs: u8) -> i64 {
 }
 
 pub fn wasmi_i32_and(lhs: i32, rhs: i32) -> bool {
-    (rhs != 0) && (lhs != 0)
+    (lhs & rhs) != 0
 }
 
 pub fn wasmi_i32_not_and(lhs: i32, rhs: i32) -> bool {

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ pub fn wasmi_i64_rotr_ssi(lhs: i64, rhs: u8) -> i64 {`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`pub fn wasmi_i32_and(lhs: i32, rhs: i32) -> bool {`
`80`		`- (rhs != 0) && (lhs != 0)`
	`80`	`+ (lhs & rhs) != 0`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`pub fn wasmi_i32_not_and(lhs: i32, rhs: i32) -> bool {`