Skip to content

Commit 28145ec

Browse files
committed
Complete Phase 5: Remove legacy code and ImportResolver
This commit completes the JavaPoet migration by removing all backward compatibility code and the obsolete ImportResolver class. CHANGES: - Remove ImportResolver class (120 lines) - JavaPoet handles imports automatically - Remove deprecated PrintWriter methods from FieldMappingCodeGenerator (38 lines) - Remove deprecated PrintWriter methods from ConvenienceMethodGenerator (17 lines) - Remove deprecated PrintWriter methods from DependencyInjectionGenerator (32 lines) - Clean up unused fields and variables for better code quality BENEFITS: - Cleaner, more maintainable codebase with no legacy debt - Consistent JavaPoet-based architecture throughout - Automatic import management eliminates manual import tracking - Reduced codebase size by ~100+ lines of deprecated code All tests pass and generated code quality is maintained.
1 parent de44dde commit 28145ec

File tree

4 files changed

+0
-205
lines changed

4 files changed

+0
-205
lines changed

src/main/java/com/github/wassertim/dynamodb/toolkit/generation/ConvenienceMethodGenerator.java

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -126,21 +126,4 @@ private MethodSpec generateToDynamoDbItemsMethod(String className, ClassName dom
126126
.build();
127127
}
128128

129-
/**
130-
* @deprecated Use generateConvenienceMethods(TypeInfo) instead
131-
*/
132-
@Deprecated
133-
public void generateConvenienceMethods(java.io.PrintWriter writer, TypeInfo typeInfo) {
134-
List<MethodSpec> methods = generateConvenienceMethods(typeInfo);
135-
for (MethodSpec method : methods) {
136-
String[] lines = method.toString().split("\\n");
137-
for (String line : lines) {
138-
if (!line.trim().isEmpty()) {
139-
writer.println(" " + line);
140-
} else {
141-
writer.println();
142-
}
143-
}
144-
}
145-
}
146129
}

src/main/java/com/github/wassertim/dynamodb/toolkit/injection/DependencyInjectionGenerator.java

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ public List<FieldSpec> generateDependencyFields(Set<String> dependencies) {
4646
* Generates dependency injection constructor for a mapper class using JavaPoet.
4747
*/
4848
public MethodSpec generateConstructor(TypeInfo typeInfo, Set<String> dependencies) {
49-
String mapperClassName = typeInfo.getMapperClassName();
50-
5149
MethodSpec.Builder constructorBuilder = MethodSpec.constructorBuilder()
5250
.addModifiers(Modifier.PUBLIC);
5351

@@ -62,35 +60,5 @@ public MethodSpec generateConstructor(TypeInfo typeInfo, Set<String> dependencie
6260
return constructorBuilder.build();
6361
}
6462

65-
/**
66-
* @deprecated Use generateDependencyFields(Set<String>) instead
67-
*/
68-
@Deprecated
69-
public void generateConstructorAndFields(java.io.PrintWriter writer, TypeInfo typeInfo, Set<String> dependencies) {
70-
if (dependencies.isEmpty()) {
71-
writer.println(" // No dependencies required");
72-
writer.println();
73-
return;
74-
}
75-
76-
// Generate dependency fields
77-
List<FieldSpec> fields = generateDependencyFields(dependencies);
78-
for (FieldSpec field : fields) {
79-
writer.println(" " + field.toString());
80-
}
81-
writer.println();
82-
83-
// Generate constructor
84-
MethodSpec constructor = generateConstructor(typeInfo, dependencies);
85-
String[] lines = constructor.toString().split("\n");
86-
for (String line : lines) {
87-
if (!line.trim().isEmpty()) {
88-
writer.println(" " + line);
89-
} else {
90-
writer.println();
91-
}
92-
}
93-
writer.println();
94-
}
9563

9664
}

src/main/java/com/github/wassertim/dynamodb/toolkit/mapping/FieldMappingCodeGenerator.java

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,9 @@
1717
*/
1818
public class FieldMappingCodeGenerator {
1919

20-
private final TypeExtractor typeExtractor;
2120
private final MappingCodeGeneratorUtils utils;
2221

2322
public FieldMappingCodeGenerator(TypeExtractor typeExtractor) {
24-
this.typeExtractor = typeExtractor;
2523
this.utils = new MappingCodeGeneratorUtils(typeExtractor);
2624
}
2725

@@ -348,38 +346,4 @@ private CodeBlock generateMapDeserialization(String fieldName) {
348346
.build();
349347
}
350348

351-
// Backward compatibility methods for existing PrintWriter-based MapperGenerator
352-
// TODO: Remove these when MapperGenerator is converted to JavaPoet
353-
354-
/**
355-
* @deprecated Use generateToAttributeValueMapping(FieldInfo, String) instead
356-
*/
357-
@Deprecated
358-
public void generateToAttributeValueMapping(java.io.PrintWriter writer, FieldInfo field, String objectName) {
359-
CodeBlock code = generateToAttributeValueMapping(field, objectName);
360-
String[] lines = code.toString().split("\n");
361-
for (String line : lines) {
362-
if (!line.trim().isEmpty()) {
363-
writer.println(" " + line);
364-
} else {
365-
writer.println();
366-
}
367-
}
368-
}
369-
370-
/**
371-
* @deprecated Use generateFromAttributeValueMapping(FieldInfo) instead
372-
*/
373-
@Deprecated
374-
public void generateFromAttributeValueMapping(java.io.PrintWriter writer, FieldInfo field) {
375-
CodeBlock code = generateFromAttributeValueMapping(field);
376-
String[] lines = code.toString().split("\n");
377-
for (String line : lines) {
378-
if (!line.trim().isEmpty()) {
379-
writer.println(" " + line);
380-
} else {
381-
writer.println();
382-
}
383-
}
384-
}
385349
}

src/main/java/com/github/wassertim/dynamodb/toolkit/mapping/ImportResolver.java

Lines changed: 0 additions & 120 deletions
This file was deleted.

0 commit comments

Comments
 (0)