refactor(ssl verification): disable ssl verification if insecure

Author: mediumTaj

src/IBM.WatsonDeveloperCloud/Http/WatsonHttpClient.cs

@@ -39,16 +39,7 @@ public class WatsonHttpClient : IClient
 
         public WatsonHttpClient(string baseUri)
         {
-            if (Insecure)
-            {
-                var httpClientHandler = new HttpClientHandler();
-                httpClientHandler.ServerCertificateCustomValidationCallback = (message, cert, chain, errors) => { return true; };
-                this.BaseClient = new HttpClient(httpClientHandler);
-            }
-            else
-            {
-                this.BaseClient = new HttpClient();
-            }
+            this.BaseClient = new HttpClient();
             this.Filters = new List<IHttpFilter> { new ErrorFilter() };
             if (baseUri != null)
                 this.BaseClient.BaseAddress = new Uri(baseUri);
@@ -58,16 +49,7 @@ public WatsonHttpClient(string baseUri)
 
         public WatsonHttpClient(string baseUri, string userName, string password)
         {
-            if (Insecure)
-            {
-                var httpClientHandler = new HttpClientHandler();
-                httpClientHandler.ServerCertificateCustomValidationCallback = (message, cert, chain, errors) => { return true; };
-                this.BaseClient = new HttpClient(httpClientHandler);
-            }
-            else
-            {
-                this.BaseClient = new HttpClient();
-            }
+            this.BaseClient = new HttpClient();
             this.Filters = new List<IHttpFilter> { new ErrorFilter() };
             if (baseUri != null)
                 this.BaseClient.BaseAddress = new Uri(baseUri);
@@ -77,16 +59,7 @@ public WatsonHttpClient(string baseUri, string userName, string password)
 
         public WatsonHttpClient(string baseUri, string userName, string password, HttpClient client)
         {
-            if (Insecure)
-            {
-                var httpClientHandler = new HttpClientHandler();
-                httpClientHandler.ServerCertificateCustomValidationCallback = (message, cert, chain, errors) => { return true; };
-                this.BaseClient = new HttpClient(httpClientHandler);
-            }
-            else
-            {
-                this.BaseClient = new HttpClient();
-            }
+            this.BaseClient = new HttpClient();
             this.Filters = new List<IHttpFilter> { new ErrorFilter() };
             if (baseUri != null)
                 this.BaseClient.BaseAddress = new Uri(baseUri);
@@ -193,7 +166,18 @@ protected virtual void Dispose(bool isDisposing)
 
         public void SendAsInsecure(bool insecure)
         {
-            Insecure = insecure;
+            if (insecure)
+            {
+                var httpClientHandler = new HttpClientHandler();
+                httpClientHandler.ServerCertificateCustomValidationCallback = (message, cert, chain, errors) => { return true; };
+                this.BaseClient = new HttpClient(httpClientHandler);
+            }
+            else
+            {
+                var httpClientHandler = new HttpClientHandler();
+                httpClientHandler.ServerCertificateCustomValidationCallback = null;
+                this.BaseClient = new HttpClient(httpClientHandler);
+            }
         }
     }
 }