chore: Bump common library version, add JsonSubTypes to project

mediumTaj · mediumTaj · commit 360ac5dd43ca · 2019-11-25T11:20:40.000-06:00
diff --git a/src/IBM.Watson.Assistant.v1/IBM.Watson.Assistant.v1.csproj b/src/IBM.Watson.Assistant.v1/IBM.Watson.Assistant.v1.csproj
@@ -26,8 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/IBM.Watson.Assistant.v2/IBM.Watson.Assistant.v2.csproj b/src/IBM.Watson.Assistant.v2/IBM.Watson.Assistant.v2.csproj
@@ -26,8 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/IBM.Watson.CompareComply.v1/CompareComplyService.cs b/src/IBM.Watson.CompareComply.v1/CompareComplyService.cs
@@ -495,11 +495,11 @@ public DetailedResponse<FeedbackList> ListFeedback(string feedbackType = null, D
                 }
                 if (before != null)
                 {
-                    restRequest.WithArgument("before", before);
+                    restRequest.WithArgument("before", before?.ToString("yyyy-MM-dd"));
                 }
                 if (after != null)
                 {
-                    restRequest.WithArgument("after", after);
+                    restRequest.WithArgument("after", after?.ToString("yyyy-MM-dd"));
                 }
                 if (!string.IsNullOrEmpty(documentTitle))
                 {
diff --git a/src/IBM.Watson.CompareComply.v1/IBM.Watson.CompareComply.v1.csproj b/src/IBM.Watson.CompareComply.v1/IBM.Watson.CompareComply.v1.csproj
@@ -26,8 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/IBM.Watson.Discovery.v1/IBM.Watson.Discovery.v1.csproj b/src/IBM.Watson.Discovery.v1/IBM.Watson.Discovery.v1.csproj
@@ -26,9 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
-        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/IBM.Watson.Discovery.v2/IBM.Watson.Discovery.v2.csproj b/src/IBM.Watson.Discovery.v2/IBM.Watson.Discovery.v2.csproj
@@ -26,9 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
-        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/IBM.Watson.LanguageTranslator.v3/IBM.Watson.LanguageTranslator.v3.csproj b/src/IBM.Watson.LanguageTranslator.v3/IBM.Watson.LanguageTranslator.v3.csproj
@@ -26,8 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/IBM.Watson.NaturalLanguageClassifier.v1/IBM.Watson.NaturalLanguageClassifier.v1.csproj b/src/IBM.Watson.NaturalLanguageClassifier.v1/IBM.Watson.NaturalLanguageClassifier.v1.csproj
@@ -26,8 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/IBM.Watson.NaturalLanguageUnderstanding.v1/IBM.Watson.NaturalLanguageUnderstanding.v1.csproj b/src/IBM.Watson.NaturalLanguageUnderstanding.v1/IBM.Watson.NaturalLanguageUnderstanding.v1.csproj
@@ -26,8 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/IBM.Watson.PersonalityInsights.v3/IBM.Watson.PersonalityInsights.v3.csproj b/src/IBM.Watson.PersonalityInsights.v3/IBM.Watson.PersonalityInsights.v3.csproj
@@ -26,8 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/IBM.Watson.SpeechToText.v1/IBM.Watson.SpeechToText.v1.csproj b/src/IBM.Watson.SpeechToText.v1/IBM.Watson.SpeechToText.v1.csproj
@@ -26,8 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/IBM.Watson.TextToSpeech.v1/IBM.Watson.TextToSpeech.v1.csproj b/src/IBM.Watson.TextToSpeech.v1/IBM.Watson.TextToSpeech.v1.csproj
@@ -26,8 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/IBM.Watson.ToneAnalyzer.v3/IBM.Watson.ToneAnalyzer.v3.csproj b/src/IBM.Watson.ToneAnalyzer.v3/IBM.Watson.ToneAnalyzer.v3.csproj
@@ -26,8 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/IBM.Watson.VisualRecognition.v3/IBM.Watson.VisualRecognition.v3.csproj b/src/IBM.Watson.VisualRecognition.v3/IBM.Watson.VisualRecognition.v3.csproj
@@ -26,8 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>
diff --git a/src/IBM.Watson.VisualRecognition.v4/IBM.Watson.VisualRecognition.v4.csproj b/src/IBM.Watson.VisualRecognition.v4/IBM.Watson.VisualRecognition.v4.csproj
@@ -26,8 +26,9 @@
 
     <ItemGroup>
         <PackageReference Include="IBM.Cloud.SDK.Core" Version="1.0.1" />
-        <PackageReference Include="IBM.Watson.Common" Version="4.0.0" />
+        <PackageReference Include="IBM.Watson.Common" Version="4.1.0" />
         <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+        <PackageReference Include="JsonSubTypes" Version="1.6.0" />
     </ItemGroup>
 
 </Project>

Original file line number	Diff line number	Diff line change
`@@ -495,11 +495,11 @@ public DetailedResponse<FeedbackList> ListFeedback(string feedbackType = null, D`
`495`	`495`	`}`
`496`	`496`	`if (before != null)`
`497`	`497`	`{`
`498`		`- restRequest.WithArgument("before", before);`
	`498`	`+ restRequest.WithArgument("before", before?.ToString("yyyy-MM-dd"));`
`499`	`499`	`}`
`500`	`500`	`if (after != null)`
`501`	`501`	`{`
`502`		`- restRequest.WithArgument("after", after);`
	`502`	`+ restRequest.WithArgument("after", after?.ToString("yyyy-MM-dd"));`
`503`	`503`	`}`
`504`	`504`	`if (!string.IsNullOrEmpty(documentTitle))`
`505`	`505`	`{`