Skip to content

Commit 99c9f5c

Browse files
authored
Merge pull request #399 from watson-developer-cloud/update-visual-recognition-v4
refactor(Visual Recognition V4): Update based on the latest API definitions to remove `Base` files
2 parents cf2832d + e5c5f4f commit 99c9f5c

File tree

13 files changed

+1008
-1115
lines changed

13 files changed

+1008
-1115
lines changed

examples/IBM.Watson.VisualRecognition.v4.Examples/ServiceExample.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,9 +280,9 @@ public void AddTrainingData()
280280

281281
VisualRecognitionService service = new VisualRecognitionService("2019-02-11", authenticator);
282282

283-
List<BaseObject> objects = new List<BaseObject>()
283+
List<TrainingDataObject> objects = new List<TrainingDataObject>()
284284
{
285-
new BaseObject()
285+
new TrainingDataObject()
286286
{
287287
_Object = "2018-Fit",
288288
Location = new Location()

src/IBM.Watson.VisualRecognition.v4/IVisualRecognitionService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public partial interface IVisualRecognitionService
3636
DetailedResponse<object> DeleteImage(string collectionId, string imageId);
3737
DetailedResponse<System.IO.MemoryStream> GetJpegImage(string collectionId, string imageId, string size = null);
3838
DetailedResponse<Collection> Train(string collectionId);
39-
DetailedResponse<TrainingDataObjects> AddImageTrainingData(string collectionId, string imageId, List<BaseObject> objects = null);
39+
DetailedResponse<TrainingDataObjects> AddImageTrainingData(string collectionId, string imageId, List<TrainingDataObject> objects = null);
4040
DetailedResponse<object> DeleteUserData(string customerId);
4141
}
4242
}

src/IBM.Watson.VisualRecognition.v4/Model/AnalyzeResponse.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public class AnalyzeResponse
3434
/// Information about what might cause less than optimal output.
3535
/// </summary>
3636
[JsonProperty("warnings", NullValueHandling = NullValueHandling.Ignore)]
37-
public List<BaseError> Warnings { get; set; }
37+
public List<Warning> Warnings { get; set; }
3838
/// <summary>
3939
/// A unique identifier of the request. Included only when an error or warning is returned.
4040
/// </summary>

src/IBM.Watson.VisualRecognition.v4/Model/BaseCollection.cs

Lines changed: 0 additions & 66 deletions
This file was deleted.

src/IBM.Watson.VisualRecognition.v4/Model/BaseObject.cs

Lines changed: 0 additions & 40 deletions
This file was deleted.

src/IBM.Watson.VisualRecognition.v4/Model/Collection.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class Collection
3636
[JsonProperty("name", NullValueHandling = NullValueHandling.Ignore)]
3737
public string Name { get; set; }
3838
/// <summary>
39-
/// The descripion of the collection.
39+
/// The description of the collection.
4040
/// </summary>
4141
[JsonProperty("description", NullValueHandling = NullValueHandling.Ignore)]
4242
public string Description { get; set; }

src/IBM.Watson.VisualRecognition.v4/Model/CollectionsList.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public class CollectionsList
2929
/// The collections in this service instance.
3030
/// </summary>
3131
[JsonProperty("collections", NullValueHandling = NullValueHandling.Ignore)]
32-
public List<BaseCollection> Collections { get; set; }
32+
public List<Collection> Collections { get; set; }
3333
}
3434

3535
}

src/IBM.Watson.VisualRecognition.v4/Model/Error.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public class CodeEnumValue
6969
[JsonProperty("more_info", NullValueHandling = NullValueHandling.Ignore)]
7070
public string MoreInfo { get; set; }
7171
/// <summary>
72-
/// Details about the specfic area of the problem.
72+
/// Details about the specific area of the problem.
7373
/// </summary>
7474
[JsonProperty("target", NullValueHandling = NullValueHandling.Ignore)]
7575
public ErrorTarget Target { get; set; }

src/IBM.Watson.VisualRecognition.v4/Model/ErrorTarget.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
namespace IBM.Watson.VisualRecognition.v4.Model
2121
{
2222
/// <summary>
23-
/// Details about the specfic area of the problem.
23+
/// Details about the specific area of the problem.
2424
/// </summary>
2525
public class ErrorTarget
2626
{

src/IBM.Watson.VisualRecognition.v4/Model/ImageDetailsList.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public class ImageDetailsList
3434
/// Information about what might cause less than optimal output.
3535
/// </summary>
3636
[JsonProperty("warnings", NullValueHandling = NullValueHandling.Ignore)]
37-
public List<BaseError> Warnings { get; set; }
37+
public List<Warning> Warnings { get; set; }
3838
/// <summary>
3939
/// A unique identifier of the request. Included only when an error or warning is returned.
4040
/// </summary>

0 commit comments

Comments
 (0)