Skip to content

Commit 4d0524b

Browse files
committed
test: Update path tests for new OkHttp version
1 parent 8194ab9 commit 4d0524b

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

discovery/src/test/java/com/ibm/watson/developer_cloud/discovery/v1/DiscoveryServiceTest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,11 +142,11 @@ public class DiscoveryServiceTest extends WatsonServiceUnitTest {
142142
+ VERSION;
143143
private static final String Q1_PATH = "/v1/environments/mock_envid/collections/mock_collid/query?version="
144144
+ VERSION
145-
+ "&filter=field:1"
146-
+ "&query=field:1&count=5&return=field&offset=5";
145+
+ "&filter=field%3A1&query=field%3A1&count=5&return=field&offset=5"
146+
+ "&similar=true&similar.document_ids=doc1%2Cdoc2&similar.fields=field1%2Cfield2";
147147
private static final String Q2_PATH = "/v1/environments/mock_envid/collections/mock_collid/query?version="
148148
+ VERSION
149-
+ "&aggregation=term(field)";
149+
+ "&aggregation=term%28field%29";
150150
private static final String Q3_PATH = "/v1/environments/mock_envid/query?version="
151151
+ VERSION + "&collection_ids=mock_collid";
152152
private static final String Q4_PATH = "/v1/environments/mock_envid/notices?version="
@@ -720,8 +720,7 @@ public void queryIsSuccessful() throws InterruptedException {
720720
QueryResponse response = discoveryService.query(queryBuilder.build()).execute();
721721
RecordedRequest request = server.takeRequest();
722722

723-
assertEquals(Q1_PATH + "&similar=true&similar.document_ids=doc1,doc2&similar.fields=field1,field2",
724-
request.getPath());
723+
assertEquals(Q1_PATH, request.getPath());
725724
assertEquals(GET, request.getMethod());
726725
assertEquals(GsonSingleton.getGson().toJsonTree(queryResp), GsonSingleton.getGson().toJsonTree(response));
727726
}

speech-to-text/src/test/java/com/ibm/watson/developer_cloud/speech_to_text/v1/SpeechToTextTest.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@
7272
import com.ibm.watson.developer_cloud.speech_to_text.v1.util.MediaTypeUtils;
7373
import com.ibm.watson.developer_cloud.speech_to_text.v1.websocket.RecognizeCallback;
7474
import com.ibm.watson.developer_cloud.util.GsonSingleton;
75+
import com.ibm.watson.developer_cloud.util.RequestUtils;
7576
import com.ibm.watson.developer_cloud.util.TestUtils;
7677
import okhttp3.WebSocket;
7778
import okhttp3.internal.ws.WebSocketRecorder;
@@ -474,7 +475,7 @@ public void testCreateJob() throws InterruptedException, FileNotFoundException {
474475
+ "&base_model_version=" + version
475476
+ "&customization_weight=" + customizationWeight
476477
+ "&inactivity_timeout=" + inactivityTimeout
477-
+ "&keywords=" + StringUtils.join(keywords, ',')
478+
+ "&keywords=" + RequestUtils.encode(StringUtils.join(keywords, ','))
478479
+ "&keywords_threshold=" + keywordsThreshold
479480
+ "&word_confidence=" + wordConfidence
480481
+ "&timestamps=" + timestamps
@@ -1302,7 +1303,8 @@ public void testRegisterCallback() throws FileNotFoundException, InterruptedExce
13021303
final RecordedRequest registerRequest = server.takeRequest();
13031304

13041305
assertEquals("POST", registerRequest.getMethod());
1305-
assertEquals(String.format(REGISTER_CALLBACK, callbackUrl, secret), registerRequest.getPath());
1306+
assertEquals(String.format(REGISTER_CALLBACK, RequestUtils.encode(callbackUrl), RequestUtils.encode(secret)),
1307+
registerRequest.getPath());
13061308
assertEquals(RegisterStatus.Status.CREATED, result.getStatus());
13071309
assertEquals(callbackUrl, result.getUrl());
13081310
}
@@ -1319,7 +1321,7 @@ public void testUnregisterCallback() throws InterruptedException {
13191321
final RecordedRequest unregisterRequest = server.takeRequest();
13201322

13211323
assertEquals("POST", unregisterRequest.getMethod());
1322-
assertEquals(String.format(UNREGISTER_CALLBACK, callbackUrl), unregisterRequest.getPath());
1324+
assertEquals(String.format(UNREGISTER_CALLBACK, RequestUtils.encode(callbackUrl)), unregisterRequest.getPath());
13231325
}
13241326

13251327
@Test

tone-analyzer/src/test/java/com/ibm/watson/developer_cloud/tone_analyzer/v3/ToneAnalyzerTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import java.util.List;
2222

2323
import com.ibm.watson.developer_cloud.tone_analyzer.v3.model.UtteranceAnalyses;
24+
import com.ibm.watson.developer_cloud.util.RequestUtils;
2425
import org.apache.commons.lang3.StringUtils;
2526
import org.junit.Before;
2627
import org.junit.Test;
@@ -148,7 +149,7 @@ public void testtones() throws InterruptedException, IOException {
148149
.build();
149150
serviceResponse = service.tone(toneOptions1).execute();
150151
request = server.takeRequest();
151-
path = path + "&tones=emotion,language,social";
152+
path = path + "&tones=" + RequestUtils.encode("emotion,language,social");
152153
assertEquals(path, request.getPath());
153154
}
154155

0 commit comments

Comments
 (0)