implment update visual recognition classifier

Author: chughts

README.md

@@ -11,6 +11,8 @@ Node-RED Watson Nodes for IBM Cloud
 - Fix to defaulting name for NLU Node.
 - Allow pre-check of audio format to be disabled in Speech to Text node.
 - Migrate from deprecated getModels and getCustomizations methods in Speech to Text nodes.
+- Implement update classifier in Visual Recognition Util node.
+- In Visual Recognition Util node append 'positive_' to zip name if neither 'positive' not 'negative' not already there.
 
 ### New in version 0.6.10
 - Needed to stringify json before addDocument in Discovery node.

services/visual_recognition/v3.html

@@ -67,6 +67,7 @@
             <option value="createClassifier">Create a classifier</option>
             <option value="retrieveClassifiersList">Retrieve a list of classifiers</option>
             <option value="retrieveClassifierDetails">Retrieve Classifier Details</option>
+            <option value="updateClassifier">Update a classifier</option>
             <option value="deleteClassifier">Delete a classifier</option>
             <option value="deleteAllClassifiers">Delete all classifiers</option>
         </select>
@@ -94,7 +95,7 @@
     <p>This feature should be provided in input : </p>
     <ul>
     <li><code>msg.payload</code> : the URL or the Node.js Buffer of an image. Redirects are followed, so you can use shortened URLs. (Required)</li>
-    <li><code>msg.params["detect_mode"]</code> : A setting of "classify", "faces" or "text" indicating the visual recognition feature required. "Default" is "classify" (string) (Optional)</li>
+    <li><code>msg.params["detect_mode"]</code> : A setting of "classify" or "faces" indicating the visual recognition feature required. "Default" is "classify" (string) (Optional)</li>
     <li><code>msg.params["classifier_ids"]</code> : A comma-separated list of the classifier IDs used to classify the images. "Default" is the classifier_id of the built-in classifier. (string) (Optional)</li>
     <li><code>msg.params["owners"]</code> : A comma-separated list with the value(s) "IBM" and/or "me" to specify which classifiers to run. (string) (Optional)</li>
     <li><code>msg.params["threshold"]</code> : A floating value (in string format) that specifies the minimum score a class must have to be displayed in the response (Optional)</li>

services/visual_recognition/v3.js

@@ -273,7 +273,7 @@ module.exports = function(RED) {
   // msg.params["negative_examples"] : a Node.js binary Buffer of the ZIP
   // that contains a minimum of 10 images.(Optional)
 
-  function prepareParamsCreateClassifier(params, node, msg) {
+  function prepareParamsClassifierFiles(params, node, msg) {
     var p = new Promise(function resolver(resolve, reject) {
       var listParams = {},
         asyncTasks = [],
@@ -396,6 +396,21 @@ module.exports = function(RED) {
     return p;
   }
 
+  function invokeUpdateClassifier(node, params, msg) {
+    var p = new Promise(function resolver(resolve, reject) {
+      params['classifier_id'] = msg.params['classifier_id'];
+      node.service.updateClassifier(params, function(err, body) {
+        if (err) {
+          reject(err);
+        } else {
+          resolve(body);
+        }
+      });
+
+    });
+    return p;
+  }
+
   function invokeListClassifiers(node, params) {
     var p = new Promise(function resolver(resolve, reject) {
       node.service.listClassifiers(params, function(err, body) {
@@ -437,16 +452,26 @@ module.exports = function(RED) {
     return p;
   }
 
-
   function executeCreateClassifier(params, node, msg) {
-    var p = prepareParamsCreateClassifier(params, node, msg)
+    var p = prepareParamsClassifierFiles(params, node, msg)
       .then(function() {
         return invokeCreateClassifier(node, params);
       });
 
     return p;
   }
 
+  function executeUpdateClassifier(params, node, msg) {
+    // This is not an error, the params for create & update
+    // are essentially the same.
+    var p = prepareParamsClassifierFiles(params, node, msg)
+      .then(function() {
+        return invokeUpdateClassifier(node, params, msg);
+      });
+
+    return p;
+  }
+
   function executeUtilService(feature, params, node, msg) {
     var p = null;
     switch (feature) {
@@ -457,6 +482,13 @@ module.exports = function(RED) {
         });
       break;
 
+    case 'updateClassifier':
+      p = executeUpdateClassifier(params, node, msg)
+        .then(function(body) {
+          return processTheResponse(body, feature, node, msg);
+        });
+      break;
+
     case 'retrieveClassifiersList':
       p = invokeListClassifiers(node, params)
         .then(function(body) {