[DCS] Makes default version_date a static value

We decided to make the default version date a static value for the
experimental service. This also allows us to remove the dependency on
moment.

This commit also changes how the version date is expected to be passed
in, moving it to a top-level option to be consistent with the Visual
Recognition v2-beta API.

Author: mfulgo

README.md

@@ -294,10 +294,10 @@ var watson = require('watson-developer-cloud');
 var fs = require('fs');
 
 var document_conversion = watson.document_conversion({
-  username: '<username>',
-  password: '<password>',
-  version: 'v1-experimental',
-  qs: { version: '2015-12-01' }
+  username:     '<username>',
+  password:     '<password>',
+  version:      'v1-experimental',
+  version_date: '2015-12-01'
 });
 
 // convert a single document

package.json

@@ -72,7 +72,6 @@
     "csv-stringify": "~0.0.8",
     "extend": "~3.0.0",
     "isstream": "~0.1.2",
-    "moment": "~2.10.6",
     "object.omit": "~2.0.0",
     "object.pick": "~1.1.1",
     "request": "~2.67.0",

services/document_conversion/v1-experimental.js

@@ -20,21 +20,23 @@ var extend         = require('extend');
 var requestFactory = require('../../lib/requestwrapper');
 var isStream       = require('isstream');
 var omit           = require('object.omit');
-var moment         = require('moment');
 
 function DocumentConversion(options) {
+  // Warn if not specifying version date
+  var version_date = "2015-12-01"
+  if(options && options.version_date) {
+    version_date = options.version_date
+  } else {
+    console.warn("[DocumentConversion] WARNING: No version_date specified. Using a (possibly old) default. " +
+                 "e.g. watson.document_conversion({ version_date: '2015-12-01' })")
+  }
+
   // Default URL
   var serviceDefaults = {
     url: 'https://gateway.watsonplatform.net/document-conversion-experimental/api',
-    qs: { version: moment.utc().subtract(1, 'd').format('YYYY-MM-DD') }
+    qs: { version: version_date }
   };
 
-  // Warn if not specifying version date
-  if(!options || !options.qs || !options.qs.version) {
-    console.warn("[DocumentConversion] WARNING: Not specifying a version query parameter may result in code instability. " +
-                 "e.g. watson.document_conversion({ qs: { version: '2015-12-01' } })")
-  }
-
   // Replace default options with user provided
   this._options = extend(serviceDefaults, options);
 }

test/test.document_conversion.v1-experimental.js

@@ -91,7 +91,7 @@ describe('document_conversion', function() {
     });
 
     it('should allow the version query param to be overridden', function() {
-      var custServInstance = watson.document_conversion(extend(service_options, { qs: { version: "2015-11-30"} }));
+      var custServInstance = watson.document_conversion(extend(service_options, { version_date: "2015-11-30"}));
       var req = custServInstance.convert(payload, noop);
       assert(req.uri.query.indexOf("version=2015-11-30" > -1));
     });