Adds assistant service (#660)

* feat(assistant): assistant service added with unit tests

* test(assistant tests): updates version date for integration tests

* test(assistant): adds integration test for assistant. also updates checking for environment variable

* ci(travis): updates travis credentials

* test(conversation tests): removed nullcheck on removed field

* test(assistant tests): added unit tests verifying credentials are obtained correctly in environment

* docs(README update for assistant):

* chore(gitignore): add assistant js files to gitignore

* Fix travis build

* docs(README): readme updates removing conversation example

Author: anweshan

.gitignore

@@ -28,6 +28,7 @@ visual-recognition/*.js
 text-to-speech/*.js
 speech-to-text/*.js
 authorization/*.js
+assistant/*.js
 index.js
 .nyc_output
 **/*.d.ts

README.md

@@ -19,7 +19,7 @@ Node.js client library to use the Watson APIs.
   * [Examples](#examples)
   * [IBM Watson Services](#ibm-watson-services)
     * [Authorization](#authorization)
-    * [Conversation](#conversation)
+    * [Assistant] (#assistant)
     * [Discovery](#discovery)
     * [Language Translator](#language-translator)
     * [Natural Language Classifier](#natural-language-classifier)
@@ -137,24 +137,23 @@ function (err, token) {
 });
 ```
 
+### Assistant
 
-### Conversation
-
-Use the [Conversation][conversation] service to determine the intent of a message.
+Use the [Assistant][assistant] service to determine the intent of a message.
 
-Note: you must first create a workspace via Bluemix. See [the documentation](https://console.bluemix.net/docs/services/conversation/index.html#about) for details.
+Note: you must first create a workspace via Bluemix. See [the documentation](https://console.bluemix.net/docs/services/assistant/index.html#about) for details.
 
 ```js
-var ConversationV1 = require('watson-developer-cloud/conversation/v1');
+var AssistantV1 = require('watson-developer-cloud/assistant/v1');
 
-var conversation = new ConversationV1({
+var assistant = new AssistantV1({
   username: '<username>',
   password: '<password>',
-  url: 'https://gateway.watsonplatform.net/conversation/api/',
-  version: '2017-05-26'
+  url: 'https://gateway.watsonplatform.net/assistant/api/',
+  version: '2018-02-16'
 });
 
-conversation.message(
+assistant.message(
   {
     input: { text: "What's the weather?" },
     workspace_id: '<workspace id>'
@@ -169,6 +168,11 @@ conversation.message(
 );
 ```
 
+
+### Conversation
+
+This service has been renamed to Assistant.
+
 ### Discovery
 
 Use the [Discovery Service][discovery] to search and analyze structured and unstructured data.
@@ -483,7 +487,7 @@ By default, the library tries to use Basic Auth and will ask for `api_key` or `u
 ```javascript
 var watson = require('watson-developer-cloud');
 
-var conversation = new watson.ConversationV1({
+var assistant = new watson.AssistantV1({
   use_unauthenticated: true
 });
 ```
@@ -522,6 +526,7 @@ This library is licensed under Apache 2.0. Full license text is available in
 
 See [CONTRIBUTING](https://github.com/watson-developer-cloud/node-sdk/blob/master/.github/CONTRIBUTING.md).
 
+[assistant]: https://www.ibm.com/watson/services/assistant/
 [conversation]: https://www.ibm.com/watson/services/conversation/
 [discovery]: https://www.ibm.com/watson/services/discovery/
 [personality_insights]: https://www.ibm.com/watson/services/personality-insights/

assistant/v1-generated.js

@@ -20,6 +20,8 @@
 
 export import AuthorizationV1 = require('./authorization/v1');
 
+export import AssistantV1 = require('./assistant/v1-generated');
+
 export import ConversationV1 = require('./conversation/v1');
 
 export import DiscoveryV1 = require('./discovery/v1');

assistant/v1-generated.ts

@@ -207,7 +207,14 @@ export class BaseService {
    * @returns {Credentials}
    */
   private getCredentialsFromEnvironment(name: string): Credentials {
-    const _name: string = (name === 'watson_vision_combined' ? 'visual_recognition' : name).toUpperCase();
+    if (name === 'watson_vision_combined') {
+      return this.getCredentialsFromEnvironment('visual_recognition');
+    }
+    // Case handling for assistant - should look for assistant env variables before conversation
+    if (name === 'conversation' && process.env[`ASSISTANT_USERNAME`]) {
+       return this.getCredentialsFromEnvironment('assistant');
+    }
+    const _name: string = name.toUpperCase();
     // https://github.com/watson-developer-cloud/node-sdk/issues/605
     const _nameWithUnderscore: string = _name.replace(/-/g, '_');
     const _username: string = process.env[`${_name}_USERNAME`] || process.env[`${_nameWithUnderscore}_USERNAME`];

auth.js.enc

@@ -111,7 +111,7 @@ describe('conversation_adapter_integration', function() {
   before(function() {
     const constructorParams = assign({}, auth.conversation, {
       version: 'v1',
-      version_date: '2017-05-26',
+      version_date: '2018-02-16',
     });
     conversation = watson.conversation(constructorParams);
     nock.enableNetConnect();
@@ -992,7 +992,6 @@ describe('conversation_adapter_integration', function() {
         );
         assert.equal(result.conditions, 'true', 'conditions field has unexpected value');
         assert.equal(result.description, null, 'description field is not null');
-        assert.notEqual(result.created, null, 'created field is null');
         done();
       });
     });