Added unit tests for several services (#576)

Added unit tests for several services, fixes formatting, removes deprecated methods in conversation

Author: anweshan

.eslintignore

@@ -9,5 +9,6 @@ examples/**/node_modules/
 test/resources/auth.js
 # ignore emitted js
 **/*v*.js
+!test/**/*.js
 lib/*.js
 dialog/v1.js

.eslintrc.js

@@ -13,7 +13,7 @@ module.exports = {
     "prettier",
   ],
   "rules": {
-    "prettier/prettier": ["error", {"singleQuote": true, "printWidth": 160}],
+    "prettier/prettier": ["error", {"singleQuote": true, "printWidth": 100}],
     "prefer-const": "error",
     "prefer-rest-params": "off", // https://github.com/mysticatea/eslint-plugin-node/issues/63
     // The rest of these override rules that are enabled by one of the configs we extend but not compatible with current codebase

conversation/v1.ts

@@ -34,30 +34,12 @@ class ConversationV1 extends GeneratedConversationV1 {
     super(options);
   }
 
+  private static removedError: Error = new Error(
+    'This endpoint has been deprecated.'
+  );
+
   workspaceStatus(params, callback) {
-    const _params = extend({}, params);
-    const _callback = callback ? callback : () => {};
-    const requiredParams = ['workspace_id'];
-    const missingParams = getMissingParams(_params, requiredParams);
-    if (missingParams) {
-      return _callback(missingParams);
-    }
-    const path = {
-      workspace_id: _params.workspace_id
-    };
-    const parameters = {
-      options: {
-        url: '/v1/workspaces/{workspace_id}/status',
-        method: 'GET',
-        path: path
-      },
-      defaultOptions: extend(true, this._options, {
-        headers: {
-          accept: 'application/json'
-        }
-      })
-    };
-    return createRequest(parameters, _callback);
+    console.warn(ConversationV1.removedError);
   }
 
   getIntents(params, callback) {
@@ -221,7 +203,7 @@ class ConversationV1 extends GeneratedConversationV1 {
   }
 
   updateSynonym(params, callback) {
-    if (params && params.new_synonym) {
+    if (params && (params.new_synonym || !params.old_synonym)) {
       return super.updateSynonym(params, callback);
     }
 

examples/.eslintrc.js

@@ -1,9 +1,11 @@
 module.exports = {
+  "parserOptions": { "ecmaVersion": 5 },
   "rules": {
     "no-console": "off",
     "node/no-missing-require": "off",
     "require-jsdoc": "off",
     "valid-jsdoc": "off",
-    "no-process-exit": "off"
+    "no-process-exit": "off",
+    "prefer-const": "off"
   }
 };

examples/browserify/public/client.js

@@ -26,7 +26,7 @@ function getToken() {
 }
 
 function analyze(token) {
-  const toneAnalyzer = new ToneAnalyzerV3({
+  var toneAnalyzer = new ToneAnalyzerV3({
     token: token,
     version_date: '2016-05-19'
   });

examples/browserify/server.js

@@ -1,11 +1,11 @@
 'use strict';
-const express = require('express'); // eslint-disable-line node/no-missing-require
-const app = express();
-const expressBrowserify = require('express-browserify'); // eslint-disable-line node/no-missing-require
-const dotenv = require('dotenv');
-const watson = require('watson-developer-cloud');
+var express = require('express'); // eslint-disable-line node/no-missing-require
+var app = express();
+var expressBrowserify = require('express-browserify'); // eslint-disable-line node/no-missing-require
+var dotenv = require('dotenv');
+var watson = require('watson-developer-cloud');
 
-const isDev = app.get('env') === 'development';
+var isDev = app.get('env') === 'development';
 app.get(
   '/bundle.js',
   expressBrowserify('public/client.js', {
@@ -20,7 +20,7 @@ app.use(express.static('public/'));
 dotenv.load({ silent: true });
 
 // For local development, specify the username and password or set env properties
-const ltAuthService = new watson.AuthorizationV1({
+var ltAuthService = new watson.AuthorizationV1({
   username: process.env.TONE_ANALYZER_USERNAME || '<username>',
   password: process.env.TONE_ANALYZER_PASSWORD || '<password>',
   url: watson.ToneAnalyzerV3.URL
@@ -36,7 +36,7 @@ app.get('/api/token/tone_analyzer', function(req, res) {
   });
 });
 
-const port = process.env.PORT || process.env.VCAP_APP_PORT || 3000;
+var port = process.env.PORT || process.env.VCAP_APP_PORT || 3000;
 app.listen(port, function() {
   console.log('Watson browserify example server running at http://localhost:%s/', port);
 });

examples/conversation_tone_analyzer_integration/tone_detection.js

@@ -54,16 +54,13 @@ module.exports = {
  */
 function invokeToneAsync(conversationPayload, tone_analyzer) {
   return new Promise(function(resolve, reject) {
-    tone_analyzer.tone(
-      { text: conversationPayload.input.text },
-      (error, data) => {
-        if (error) {
-          reject(error);
-        } else {
-          resolve(data);
-        }
+    tone_analyzer.tone({ text: conversationPayload.input.text }, (error, data) => {
+      if (error) {
+        reject(error);
+      } else {
+        resolve(data);
       }
-    );
+    });
   });
 }
 
@@ -75,11 +72,7 @@ function invokeToneAsync(conversationPayload, tone_analyzer) {
  * @param toneAnalyzerPayload json object returned by the Watson Tone Analyzer Service
  * @return conversationPayload where the user object has been updated with tone information from the toneAnalyzerPayload
  */
-function updateUserTone(
-  conversationPayload,
-  toneAnalyzerPayload,
-  maintainHistory
-) {
+function updateUserTone(conversationPayload, toneAnalyzerPayload, maintainHistory) {
   var emotionTone = null;
   var languageTone = null;
   var socialTone = null;
@@ -97,9 +90,7 @@ function updateUserTone(
 
   // Extract the tones - emotion, language and social
   if (toneAnalyzerPayload && toneAnalyzerPayload.document_tone) {
-    toneAnalyzerPayload.document_tone.tone_categories.forEach(function(
-      toneCategory
-    ) {
+    toneAnalyzerPayload.document_tone.tone_categories.forEach(function(toneCategory) {
       if (toneCategory.category_id === EMOTION_TONE_LABEL) {
         emotionTone = toneCategory;
       }

examples/dialog.v1.js

@@ -1,8 +1,8 @@
 'use strict';
 
-const DialogV1 = require('watson-developer-cloud/dialog/v1');
+var DialogV1 = require('watson-developer-cloud/dialog/v1');
 
-const dialog = new DialogV1({
+var dialog = new DialogV1({
   username: 'INSERT YOUR USERNAME FOR THE SERVICE HERE',
   password: 'INSERT YOUR PASSWORD FOR THE SERVICE HERE'
 });

examples/discovery.v1.js

@@ -1,9 +1,9 @@
 'use strict';
 
-const DiscoveryV1 = require('watson-developer-cloud/discovery/v1');
-const fs = require('fs');
+var DiscoveryV1 = require('watson-developer-cloud/discovery/v1');
+var fs = require('fs');
 
-const discovery = new DiscoveryV1({
+var discovery = new DiscoveryV1({
   // if left unspecified here, the SDK will fall back to the DISCOVERY_USERNAME and DISCOVERY_PASSWORD
   // environment properties, and then Bluemix's VCAP_SERVICES environment property
   // username: 'INSERT YOUR USERNAME FOR THE SERVICE HERE',
@@ -18,7 +18,7 @@ discovery.getEnvironments({}, function(error, data) {
 });
 
 // var file = fs.readFileSync('../test/resources/sampleHtml.html');
-const file = fs.createReadStream('../test/resources/sampleWord.docx');
+var file = fs.createReadStream('../test/resources/sampleWord.docx');
 
 discovery.addDocument(
   {

examples/natural_language_understanding.v1.js

@@ -4,7 +4,7 @@ var fs = require('fs');
 var NaturalLanguageUnderstandingV1 = require('watson-developer-cloud/natural-language-understanding/v1.js');
 require('dotenv').config({ silent: true }); //  optional
 
-const nlu = new NaturalLanguageUnderstandingV1({
+var nlu = new NaturalLanguageUnderstandingV1({
   // note: if unspecified here, credentials are pulled from environment properties:
   // NATURAL_LANGUAGE_UNDERSTANDING_USERNAME &  NATURAL_LANGUAGE_UNDERSTANDING_PASSWORD
   // username: '<username>'.
@@ -17,7 +17,7 @@ fs.readFile(filename, 'utf-8', function(file_error, file_data) {
   if (file_error) {
     console.log(file_error);
   } else {
-    const options = {
+    var options = {
       html: file_data,
       features: {
         concepts: {},