Tradeoff Analytics metadata and events: tests, fixes, conform to style

guide (metadata_header instead of metadataHeader)

Author: Dolev Dotan

services/tradeoff_analytics/v1.js

@@ -18,8 +18,7 @@
 
 var extend         = require('extend');
 var requestFactory = require('../../lib/requestwrapper');
-var omit = require('object.omit');
-var pick = require('object.pick');
+var omit           = require('object.omit');
 
 function TradeoffAnalytics(options) {
   // Default URL
@@ -46,13 +45,14 @@ function TradeoffAnalytics(options) {
  */
 TradeoffAnalytics.prototype.dilemmas = function(params, callback) {
   params = params || {};
+  
   var parameters = {
     options: {
       method: 'POST',
       url: '/v1/dilemmas',
-      body: omit(params,['metadataHeader']),
+      body: omit(params,['metadata_header']),
       headers: {
-        'x-watson-metadata' : pick(params,['metadataHeader'])
+        'x-watson-metadata' : params.metadata_header
       },
       json: true
     },
@@ -71,13 +71,14 @@ TradeoffAnalytics.prototype.dilemmas = function(params, callback) {
  */
 TradeoffAnalytics.prototype.events = function(params, callback) {
   params = params || {};
+  
   var parameters = {
     options: {
       method: 'POST',
       url: '/v1/events',
-      body: omit(params,['metadataHeader']),
+      body: omit(params,['metadata_header']),
       headers: {
-        'x-watson-metadata' : pick(params,['metadataHeader'])
+        'x-watson-metadata' : params.metadata_header
       },
       json: true
     },

test/resources/ta_events.js

@@ -0,0 +1,28 @@
+[{
+	"widget_instance_uuid" : "e8d263d9-a0a7-43f4-81cf-2767ad246cb5",
+	"widget_show_uuid" : null,
+	"dilemma_call_uuid" : null,
+	"event_number" : 0,
+	"category" : "widget",
+	"action" : "started",
+	"object" : "basic",
+	"value" : {
+		"optionHighlighting" : false,
+		"favorites" : true,
+		"favoritesTab" : false,
+		"optionDetails" : true,
+		"filters" : true,
+		"filterHistogram" : false,
+		"objectivesOnly" : true,
+		"optimalsList" : true,
+		"autoExcludedList" : true,
+		"incompleteList" : true,
+		"tradeoffAnalyzer" : true,
+		"undoRedo" : false,
+		"exploreViz" : "both",
+		"questionEditor" : "editableNoToggle",
+		"bidiTextDir" : "auto",
+		"analytics" : "MetadataAndEvents"
+	},
+	"timestamp" : 1442414658641
+}]

test/test.tradeoff_analytics.v1.js

@@ -3,17 +3,20 @@
 var assert = require('assert');
 var watson = require('../lib/index');
 var nock   = require('nock');
+var extend = require('extend');
 
 describe('tradeoff_analytics', function() {
 
   var noop = function() {};
 
   var service_request = require('./resources/dilemma_problem');
+  var events_request = require('./resources/ta_events');
 
   var service_response = {};
 
   var service_path = '/v1/dilemmas';
-
+  var events_path = '/v1/events';
+  
   var service = {
     username: 'batman',
     password: 'bruce-wayne',
@@ -27,6 +30,11 @@ describe('tradeoff_analytics', function() {
       .persist()
       .post(service_path, service_request)
       .reply(200, service_response);
+   nock(service.url)
+      .persist()
+      .post(events_path, events_request)
+      .reply(200);
+ 
   });
 
   after(function() {
@@ -43,13 +51,33 @@ describe('tradeoff_analytics', function() {
     tradeoff_analytics.dilemmas({}, missingParameter);
     tradeoff_analytics.dilemmas(null, missingParameter);
     tradeoff_analytics.dilemmas(undefined, missingParameter);
+    
+    tradeoff_analytics.events({}, missingParameter);
+    tradeoff_analytics.events(null, missingParameter);
+    tradeoff_analytics.events(undefined, missingParameter);
   });
-
+  
   it('should generate a valid payload', function() {
-      var req = tradeoff_analytics.dilemmas(service_request, noop);
+	  var params = extend({}, service_request);
+	  params.metadata_header = 'test_header_content';
+      var req = tradeoff_analytics.dilemmas(params, noop);
       var body = new Buffer(req.body).toString('ascii');
       assert.equal(req.uri.href, service.url + service_path);
       assert.equal(body, JSON.stringify(service_request));
+      assert.notEqual(body, JSON.stringify(params));
+      assert.equal(req.headers['x-watson-metadata'], params.metadata_header);
+      assert.equal(req.method, 'POST');
+  });
+  
+  it('should forward the events correctly', function() {
+	  var params = extend({}, events_request);
+	  params.metadata_header = 'test_header_content';
+      var req = tradeoff_analytics.events(params, noop);
+      var body = new Buffer(req.body).toString('ascii');
+      assert.equal(req.uri.href, service.url + events_path);
+      assert.equal(body, JSON.stringify(events_request));
+      assert.notEqual(body, JSON.stringify(params));
+      assert.equal(req.headers['x-watson-metadata'], params.metadata_header);
       assert.equal(req.method, 'POST');
   });