refactor: add option for disabling ssl (for icp)

Author: dpopp07

lib/base_service.ts

@@ -43,13 +43,15 @@ export interface UserOptions {
   iam_access_token?: string;
   iam_apikey?: string;
   iam_url?: string;
+  allow_unauthorized?: boolean;
 }
 
 export interface BaseServiceOptions extends UserOptions {
   headers: HeaderOptions;
   url: string;
   jar?: request.CookieJar;
   qs: any;
+  rejectUnauthorized?: boolean;
 }
 
 export interface Credentials {
@@ -149,6 +151,9 @@ export class BaseService {
     } else {
       this.tokenManager = null;
     }
+    // rejectUnauthorized should only be false if allow_unauthorized is true
+    // used to disable ssl checking for icp
+    this._options.rejectUnauthorized = !options.allow_unauthorized;
   }
 
   /**

test/unit/test.base_service.js

@@ -264,4 +264,30 @@ describe('BaseService', function() {
     assert.equal(instance.tokenManager, null);
     assert(authHeader.startsWith('Basic'));
   });
+
+  it('should set rejectUnauthorized to `false` if allow_unauthorized is `true`', function() {
+    const instance = new TestService({
+      username: 'apikey',
+      password: 'icp-1234',
+      allow_unauthorized: true,
+    });
+    assert.equal(instance._options.rejectUnauthorized, false);
+  });
+
+  it('should set rejectUnauthorized to `true` if allow_unauthorized is `false`', function() {
+    const instance = new TestService({
+      username: 'apikey',
+      password: 'icp-1234',
+      allow_unauthorized: false,
+    });
+    assert(instance._options.rejectUnauthorized);
+  });
+
+  it('should set rejectUnauthorized to `true` if allow_unauthorized is not set', function() {
+    const instance = new TestService({
+      username: 'apikey',
+      password: 'icp-1234',
+    });
+    assert(instance._options.rejectUnauthorized);
+  });
 });