chore: fix typo on ending bracket

Author: dpopp07

lib/base_service.ts

@@ -92,7 +92,7 @@ function usesBasicForIam(obj: any): boolean {
 // returns true if the string has a curly bracket or quote as the first or last character
 // these are common user-issues that we should handle before they get a network error
 function badCharAtAnEnd(value: string): boolean {
-  return value.startsWith('{') || value.startsWith('"') || value.endsWith('{') || value.endsWith('"');
+  return value.startsWith('{') || value.startsWith('"') || value.endsWith('}') || value.endsWith('"');
 }
 
 // checks credentials for common user mistakes of copying {, }, or " characters from the documentation

test/unit/baseService.test.js

@@ -340,7 +340,9 @@ describe('BaseService', function() {
     function assertConstructorThrows(params) {
       expect(() => {
         new TestService(params);
-      }).toThrowError('Revise these credentials - they should not start with a { or "');
+      }).toThrowError(
+        'Revise these credentials - they should not start or end with curly brackets or quotes.'
+      );
     }
 
     it('should throw when username starts with {', function() {
@@ -391,6 +393,14 @@ describe('BaseService', function() {
       });
     });
 
+    it('should throw when url ends with }', function() {
+      assertConstructorThrows({
+        username: 'batman',
+        password: 'goodpass',
+        url: 'watson-url.com/some-api/v1/endpoint}',
+      });
+    });
+
     it('should throw when url starts with "', function() {
       assertConstructorThrows({
         username: 'batman',