😒 fix linting issues

Author: Ammar Dodin

examples/.eslintrc.js

@@ -6,6 +6,7 @@ module.exports = {
     "require-jsdoc": "off",
     "valid-jsdoc": "off",
     "no-process-exit": "off",
-    "prefer-const": "off"
+    "prefer-const": "off",
+    "no-var": "off"
   }
 };

examples/conversation_tone_analyzer_integration/tone_detection.js

@@ -54,7 +54,7 @@ module.exports = {
  */
 function invokeToneAsync(conversationPayload, tone_analyzer) {
   return new Promise(function(resolve, reject) {
-    tone_analyzer.tone({ text: conversationPayload.input.text }, (error, data) => {
+    tone_analyzer.tone({ text: conversationPayload.input.text }, function(error, data) {
       if (error) {
         reject(error);
       } else {

test/integration/test.tone_analyzer.js

@@ -35,11 +35,14 @@ describe('tone_analyzer_integration', function() {
   it('failing tone()', function(done) {
     // this is a failing test
     const mobydick = fs.readFileSync(path.join(__dirname, '../resources/mobydick.txt'), 'utf8');
-    tone_analyzer.tone({ tone_input: mobydick, content_type: 'invalid content type' }, (err, res) => {
-      assert(err);
-      assert(err['x-global-transaction-id']);
-      assert(typeof err['x-global-transaction-id'] === 'string');
-    });
+    tone_analyzer.tone(
+      { tone_input: mobydick, content_type: 'invalid content type' },
+      (err, res) => {
+        assert(err);
+        assert(err['x-global-transaction-id']);
+        assert(typeof err['x-global-transaction-id'] === 'string');
+      }
+    );
     done();
   });
 

test/unit/test.adapter.tone_analyzer.v3.js

@@ -141,9 +141,7 @@ describe('tone_analyzer.v3', function() {
   });
 
   // Tone Chat Endpoint API - test for valid payload
-  it('tone-chat API endpoint should generate a valid payload with utterances json payload', function(
-    done
-  ) {
+  it('tone-chat API endpoint should generate a valid payload with utterances json payload', function(done) {
     const tone_chat_path = '/v3/tone_chat';
     const tone_chat_request = {
       utterances: [

test/unit/test.contentType.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const contentType = require('../../lib/content-type');
 const assert = require('assert');
 const fs = require('fs');

test/unit/test.personality_insights.v3.js

@@ -3,7 +3,6 @@
 const assert = require('assert');
 const watson = require('../../index');
 const nock = require('nock');
-const extend = require('extend');
 
 describe('personality_insights_v3', function() {
   const noop = function() {};

test/unit/test.requestWrapper.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const createRequest = require('../../lib/requestwrapper').createRequest;
 const formatError = require('../../lib/requestwrapper').formatErrorIfExists;
 const assert = require('assert');

test/unit/test.toPromise.js

@@ -1,5 +1,6 @@
+'use strict';
+
 const toPromise = require('../../lib/to-promise');
-const stream = require('stream');
 const fs = require('fs');
 const assert = require('assert');
 const path = require('path');
@@ -12,7 +13,6 @@ describe('toPromise()', () => {
         assert(typeof res === 'string');
       })
       .catch(err => {
-        console.log(err);
         assert(false);
       });
   });

test/unit/test.tone_analyzer.v3.js

@@ -137,9 +137,7 @@ describe('tone_analyzer.v3', function() {
   });
 
   // Tone Chat Endpoint API - test for valid payload
-  it('tone-chat API endpoint should generate a valid payload with utterances json payload', function(
-    done
-  ) {
+  it('tone-chat API endpoint should generate a valid payload with utterances json payload', function(done) {
     const tone_chat_path = '/v3/tone_chat';
     const tone_chat_request = {
       utterances: [

test/unit/test.visual_recognition.v3.js

@@ -566,7 +566,8 @@ describe('visual_recognition', function() {
       'getImageData',
       'deleteImageData',
       'findSimilar'
-    ].forEach(function(method) {
+    ];
+    deprecatedMethods.forEach(function(method) {
       it(`${method} should print a warning message`, function() {
         visual_recognition[method]({}, noop);
         assert(spy.calledOnce);