Skip to content

Commit 9d56d5b

Browse files
dpopp07dpopp07
authored
Merge pull request #841 from watson-developer-cloud/no-stream-return-type
refactor: remove ReadableStream as a return type for all generated me…
2 parents 8466043 + 5cff833 commit 9d56d5b

File tree

14 files changed

+219
-205
lines changed

14 files changed

+219
-205
lines changed

‎assistant/v1.ts‎

Lines changed: 45 additions & 45 deletions
Large diffs are not rendered by default.

‎assistant/v2.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class AssistantV2 extends BaseService {
7777
* @param {Function} [callback] - The callback that handles the response.
7878
* @returns {NodeJS.ReadableStream|void}
7979
*/
80-
public createSession(params: AssistantV2.CreateSessionParams, callback?: AssistantV2.Callback<AssistantV2.SessionResponse>): NodeJS.ReadableStream | Promise<any> | void {
80+
public createSession(params: AssistantV2.CreateSessionParams, callback?: AssistantV2.Callback<AssistantV2.SessionResponse>): Promise<any> | void {
8181
const _params = extend({}, params);
8282
const _callback = callback;
8383
const requiredParams = ['assistant_id'];
@@ -134,7 +134,7 @@ class AssistantV2 extends BaseService {
134134
* @param {Function} [callback] - The callback that handles the response.
135135
* @returns {NodeJS.ReadableStream|void}
136136
*/
137-
public deleteSession(params: AssistantV2.DeleteSessionParams, callback?: AssistantV2.Callback<AssistantV2.Empty>): NodeJS.ReadableStream | Promise<any> | void {
137+
public deleteSession(params: AssistantV2.DeleteSessionParams, callback?: AssistantV2.Callback<AssistantV2.Empty>): Promise<any> | void {
138138
const _params = extend({}, params);
139139
const _callback = callback;
140140
const requiredParams = ['assistant_id', 'session_id'];
@@ -199,7 +199,7 @@ class AssistantV2 extends BaseService {
199199
* @param {Function} [callback] - The callback that handles the response.
200200
* @returns {NodeJS.ReadableStream|void}
201201
*/
202-
public message(params: AssistantV2.MessageParams, callback?: AssistantV2.Callback<AssistantV2.MessageResponse>): NodeJS.ReadableStream | Promise<any> | void {
202+
public message(params: AssistantV2.MessageParams, callback?: AssistantV2.Callback<AssistantV2.MessageResponse>): Promise<any> | void {
203203
const _params = extend({}, params);
204204
const _callback = callback;
205205
const requiredParams = ['assistant_id', 'session_id'];

‎compare-comply/v1.ts‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class CompareComplyV1 extends BaseService {
7777
* @param {Function} [callback] - The callback that handles the response.
7878
* @returns {NodeJS.ReadableStream|void}
7979
*/
80-
public convertToHtml(params: CompareComplyV1.ConvertToHtmlParams, callback?: CompareComplyV1.Callback<CompareComplyV1.HTMLReturn>): NodeJS.ReadableStream | Promise<any> | void {
80+
public convertToHtml(params: CompareComplyV1.ConvertToHtmlParams, callback?: CompareComplyV1.Callback<CompareComplyV1.HTMLReturn>): Promise<any> | void {
8181
const _params = extend({}, params);
8282
const _callback = callback;
8383
const requiredParams = ['file'];
@@ -153,7 +153,7 @@ class CompareComplyV1 extends BaseService {
153153
* @param {Function} [callback] - The callback that handles the response.
154154
* @returns {NodeJS.ReadableStream|void}
155155
*/
156-
public classifyElements(params: CompareComplyV1.ClassifyElementsParams, callback?: CompareComplyV1.Callback<CompareComplyV1.ClassifyReturn>): NodeJS.ReadableStream | Promise<any> | void {
156+
public classifyElements(params: CompareComplyV1.ClassifyElementsParams, callback?: CompareComplyV1.Callback<CompareComplyV1.ClassifyReturn>): Promise<any> | void {
157157
const _params = extend({}, params);
158158
const _callback = callback;
159159
const requiredParams = ['file'];
@@ -224,7 +224,7 @@ class CompareComplyV1 extends BaseService {
224224
* @param {Function} [callback] - The callback that handles the response.
225225
* @returns {NodeJS.ReadableStream|void}
226226
*/
227-
public extractTables(params: CompareComplyV1.ExtractTablesParams, callback?: CompareComplyV1.Callback<CompareComplyV1.TableReturn>): NodeJS.ReadableStream | Promise<any> | void {
227+
public extractTables(params: CompareComplyV1.ExtractTablesParams, callback?: CompareComplyV1.Callback<CompareComplyV1.TableReturn>): Promise<any> | void {
228228
const _params = extend({}, params);
229229
const _callback = callback;
230230
const requiredParams = ['file'];
@@ -300,7 +300,7 @@ class CompareComplyV1 extends BaseService {
300300
* @param {Function} [callback] - The callback that handles the response.
301301
* @returns {NodeJS.ReadableStream|void}
302302
*/
303-
public compareDocuments(params: CompareComplyV1.CompareDocumentsParams, callback?: CompareComplyV1.Callback<CompareComplyV1.CompareReturn>): NodeJS.ReadableStream | Promise<any> | void {
303+
public compareDocuments(params: CompareComplyV1.CompareDocumentsParams, callback?: CompareComplyV1.Callback<CompareComplyV1.CompareReturn>): Promise<any> | void {
304304
const _params = extend({}, params);
305305
const _callback = callback;
306306
const requiredParams = ['file_1', 'file_2'];
@@ -376,7 +376,7 @@ class CompareComplyV1 extends BaseService {
376376
* @param {Function} [callback] - The callback that handles the response.
377377
* @returns {NodeJS.ReadableStream|void}
378378
*/
379-
public addFeedback(params: CompareComplyV1.AddFeedbackParams, callback?: CompareComplyV1.Callback<CompareComplyV1.FeedbackReturn>): NodeJS.ReadableStream | Promise<any> | void {
379+
public addFeedback(params: CompareComplyV1.AddFeedbackParams, callback?: CompareComplyV1.Callback<CompareComplyV1.FeedbackReturn>): Promise<any> | void {
380380
const _params = extend({}, params);
381381
const _callback = callback;
382382
const requiredParams = ['feedback_data'];
@@ -433,7 +433,7 @@ class CompareComplyV1 extends BaseService {
433433
* @param {Function} [callback] - The callback that handles the response.
434434
* @returns {NodeJS.ReadableStream|void}
435435
*/
436-
public deleteFeedback(params: CompareComplyV1.DeleteFeedbackParams, callback?: CompareComplyV1.Callback<CompareComplyV1.FeedbackDeleted>): NodeJS.ReadableStream | Promise<any> | void {
436+
public deleteFeedback(params: CompareComplyV1.DeleteFeedbackParams, callback?: CompareComplyV1.Callback<CompareComplyV1.FeedbackDeleted>): Promise<any> | void {
437437
const _params = extend({}, params);
438438
const _callback = callback;
439439
const requiredParams = ['feedback_id'];
@@ -492,7 +492,7 @@ class CompareComplyV1 extends BaseService {
492492
* @param {Function} [callback] - The callback that handles the response.
493493
* @returns {NodeJS.ReadableStream|void}
494494
*/
495-
public getFeedback(params: CompareComplyV1.GetFeedbackParams, callback?: CompareComplyV1.Callback<CompareComplyV1.GetFeedback>): NodeJS.ReadableStream | Promise<any> | void {
495+
public getFeedback(params: CompareComplyV1.GetFeedbackParams, callback?: CompareComplyV1.Callback<CompareComplyV1.GetFeedback>): Promise<any> | void {
496496
const _params = extend({}, params);
497497
const _callback = callback;
498498
const requiredParams = ['feedback_id'];
@@ -585,7 +585,7 @@ class CompareComplyV1 extends BaseService {
585585
* @param {Function} [callback] - The callback that handles the response.
586586
* @returns {NodeJS.ReadableStream|void}
587587
*/
588-
public listFeedback(params?: CompareComplyV1.ListFeedbackParams, callback?: CompareComplyV1.Callback<CompareComplyV1.FeedbackList>): NodeJS.ReadableStream | Promise<any> | void {
588+
public listFeedback(params?: CompareComplyV1.ListFeedbackParams, callback?: CompareComplyV1.Callback<CompareComplyV1.FeedbackList>): Promise<any> | void {
589589
const _params = (typeof params === 'function' && !callback) ? {} : extend({}, params);
590590
const _callback = (typeof params === 'function' && !callback) ? params : callback;
591591

@@ -674,7 +674,7 @@ class CompareComplyV1 extends BaseService {
674674
* @param {Function} [callback] - The callback that handles the response.
675675
* @returns {NodeJS.ReadableStream|void}
676676
*/
677-
public createBatch(params: CompareComplyV1.CreateBatchParams, callback?: CompareComplyV1.Callback<CompareComplyV1.BatchStatus>): NodeJS.ReadableStream | Promise<any> | void {
677+
public createBatch(params: CompareComplyV1.CreateBatchParams, callback?: CompareComplyV1.Callback<CompareComplyV1.BatchStatus>): Promise<any> | void {
678678
const _params = extend({}, params);
679679
const _callback = callback;
680680
const requiredParams = ['_function', 'input_credentials_file', 'input_bucket_location', 'input_bucket_name', 'output_credentials_file', 'output_bucket_location', 'output_bucket_name'];
@@ -745,7 +745,7 @@ class CompareComplyV1 extends BaseService {
745745
* @param {Function} [callback] - The callback that handles the response.
746746
* @returns {NodeJS.ReadableStream|void}
747747
*/
748-
public getBatch(params: CompareComplyV1.GetBatchParams, callback?: CompareComplyV1.Callback<CompareComplyV1.BatchStatus>): NodeJS.ReadableStream | Promise<any> | void {
748+
public getBatch(params: CompareComplyV1.GetBatchParams, callback?: CompareComplyV1.Callback<CompareComplyV1.BatchStatus>): Promise<any> | void {
749749
const _params = extend({}, params);
750750
const _callback = callback;
751751
const requiredParams = ['batch_id'];
@@ -796,7 +796,7 @@ class CompareComplyV1 extends BaseService {
796796
* @param {Function} [callback] - The callback that handles the response.
797797
* @returns {NodeJS.ReadableStream|void}
798798
*/
799-
public listBatches(params?: CompareComplyV1.ListBatchesParams, callback?: CompareComplyV1.Callback<CompareComplyV1.Batches>): NodeJS.ReadableStream | Promise<any> | void {
799+
public listBatches(params?: CompareComplyV1.ListBatchesParams, callback?: CompareComplyV1.Callback<CompareComplyV1.Batches>): Promise<any> | void {
800800
const _params = (typeof params === 'function' && !callback) ? {} : extend({}, params);
801801
const _callback = (typeof params === 'function' && !callback) ? params : callback;
802802

@@ -843,7 +843,7 @@ class CompareComplyV1 extends BaseService {
843843
* @param {Function} [callback] - The callback that handles the response.
844844
* @returns {NodeJS.ReadableStream|void}
845845
*/
846-
public updateBatch(params: CompareComplyV1.UpdateBatchParams, callback?: CompareComplyV1.Callback<CompareComplyV1.BatchStatus>): NodeJS.ReadableStream | Promise<any> | void {
846+
public updateBatch(params: CompareComplyV1.UpdateBatchParams, callback?: CompareComplyV1.Callback<CompareComplyV1.BatchStatus>): Promise<any> | void {
847847
const _params = extend({}, params);
848848
const _callback = callback;
849849
const requiredParams = ['batch_id', 'action'];

0 commit comments

Comments
 (0)