fix bug that prevented reading iam apikey from env (#711)

* fix bug that prevented reading iam apikey from env

* add tests for reading iam creds from env and vcap

Author: dpopp07

lib/base_service.ts

@@ -125,11 +125,12 @@ export class BaseService {
       options,
       _options
     );
-     if (options.iam_apikey || options.iam_access_token) {
+
+    if (_options.iam_apikey || _options.iam_access_token) {
       this.tokenManager = new IamTokenManagerV1({
-        iamApikey: options.iam_apikey,
-        iamAccessToken: options.iam_access_token,
-        iamUrl: options.iam_url
+        iamApikey: _options.iam_apikey,
+        iamAccessToken: _options.iam_access_token,
+        iamUrl: _options.iam_url
       });
     } else {
       this.tokenManager = null;

test/unit/test.base_service.js

@@ -112,6 +112,7 @@ describe('BaseService', function() {
       url: 'https://gateway.watsonplatform.net/test/api',
     };
     assert.deepEqual(actual, expected);
+    assert.notEqual(instance.tokenManager, null);
   });
 
   it('should prefer hard-coded credentials over environment properties', function() {
@@ -218,4 +219,16 @@ describe('BaseService', function() {
     instance.setAccessToken('abcd-1234');
     assert.notEqual(instance.tokenManager, null);
   });
+
+  it('should create a token manager instance if env variables specify iam credentials', function() {
+    process.env.TEST_IAM_APIKEY = 'test1234';
+    const instance = new TestService();
+    const actual = instance.getCredentials();
+    const expected = {
+      iam_apikey: 'test1234',
+      url: 'https://gateway.watsonplatform.net/test/api',
+    };
+    assert.deepEqual(actual, expected);
+    assert.notEqual(instance.tokenManager, null);
+  });
 });