Merge pull request #24 from watson-developer-cloud/fix-integration-tests-optional-credentials

Fix issue when integration credentials are not provided

Author: maxnussbaum

.rubocop.yml

@@ -1584,6 +1584,9 @@ Lint/UnusedMethodArgument:
 Lint/Void:
   CheckForMethodsWithNoSideEffects: false
 
+Rails:
+  Enabled: false
+
 #################### Performance ###########################
 
 Performance/DoubleStartEndWith:

test/integration/test_assistant_v1.rb

@@ -3,7 +3,7 @@
 require_relative("./../test_helper.rb")
 SimpleCov.command_name "test:integration"
 
-unless ENV["ASSISTANT_USERNAME"].nil? || ENV["ASSISTANT_PASSWORD"].nil?
+if !ENV["ASSISTANT_USERNAME"].nil? && !ENV["ASSISTANT_PASSWORD"].nil?
   # Integration tests for the Watson Assistant V1 Service
   class AssistantV1Test < Minitest::Test
     def test_create_update_delete_workspace
@@ -652,4 +652,10 @@ def test_delete_user_data
       assert(service_response.nil?)
     end
   end
+else
+  class AssistantV1Test < Minitest::Test
+    def test_missing_credentials_skip_integration
+      skip "Skip assistant integration tests because credentials have not been provided"
+    end
+  end
 end

test/integration/test_discovery_v1.rb

@@ -3,7 +3,7 @@
 require_relative("./../test_helper.rb")
 require("minitest/hooks/test")
 
-unless ENV["DISCOVERY_USERNAME"].nil? || ENV["DISCOVERY_PASSWORD"].nil?
+if !ENV["DISCOVERY_USERNAME"].nil? && !ENV["DISCOVERY_PASSWORD"].nil?
   # Integration tests for the Discovery V1 Service
   class DiscoveryV1Test < Minitest::Test
     include Minitest::Hooks
@@ -208,4 +208,10 @@ def test_list_credentials
       refute(credentials.nil?)
     end
   end
+else
+  class DiscoveryV1Test < Minitest::Test
+    def test_missing_credentials_skip_integration
+      skip "Skip discovery integration tests because credentials have not been provided"
+    end
+  end
 end

test/integration/test_iam_assistant_v1.rb

@@ -2,7 +2,7 @@
 
 require_relative("./../test_helper.rb")
 
-unless ENV["ASSISTANT_IAM_URL"].nil? || ENV["ASSISTANT_IAM_APIKEY"].nil?
+if !ENV["ASSISTANT_IAM_URL"].nil? && !ENV["ASSISTANT_IAM_APIKEY"].nil?
   # Integration tests for the Watson Assistant V1 Service
   class IAMAssistantV1Test < Minitest::Test
     def test_create_update_delete_workspace
@@ -715,4 +715,10 @@ def test_receive_error
       assert(error_received)
     end
   end
+else
+  class IAMAssistantV1Test < Minitest::Test
+    def test_missing_credentials_skip_integration
+      skip "Skip iam assistant integration tests because credentials have not been provided"
+    end
+  end
 end

test/integration/test_language_translator_v3.rb

@@ -4,7 +4,7 @@
 require_relative("./../test_helper.rb")
 require("minitest/hooks/test")
 
-unless ENV["LANGUAGE_TRANSLATOR_V3_USERNAME"].nil? || ENV["LANGUAGE_TRANSLATOR_V3_PASSWORD"].nil?
+if !ENV["LANGUAGE_TRANSLATOR_V3_USERNAME"].nil? && !ENV["LANGUAGE_TRANSLATOR_V3_PASSWORD"].nil?
   # Integration tests for the Language Translator V3 Service
   class LanguageTranslatorV3Test < Minitest::Test
     include Minitest::Hooks
@@ -80,4 +80,10 @@ def test_create_delete_model
       assert_equal("OK", service_response["status"])
     end
   end
+else
+  class LanguageTranslatorV3Test < Minitest::Test
+    def test_missing_credentials_skip_integration
+      skip "Skip language translator integration tests because credentials have not been provided"
+    end
+  end
 end

test/integration/test_natural_language_classifier_v1.rb

@@ -4,7 +4,7 @@
 require_relative("./../test_helper.rb")
 require("minitest/hooks/test")
 
-unless ENV["NATURAL_LANGUAGE_CLASSIFIER_USERNAME"].nil? || ENV["NATURAL_LANGUAGE_CLASSIFIER_PASSWORD"].nil?
+if !ENV["NATURAL_LANGUAGE_CLASSIFIER_USERNAME"].nil? && !ENV["NATURAL_LANGUAGE_CLASSIFIER_PASSWORD"].nil?
   # Integration tests for the Natural Language Classifier V1 Service
   class NaturalLanguageClassifierV1Test < Minitest::Test
     include Minitest::Hooks
@@ -68,4 +68,10 @@ def test_classify_text
       )
     end
   end
+else
+  class NaturalLanguageClassifierV1Test < Minitest::Test
+    def test_missing_credentials_skip_integration
+      skip "Skip natural language classifier integration tests because credentials have not been provided"
+    end
+  end
 end

test/integration/test_natural_language_understanding_v1.rb

@@ -3,7 +3,7 @@
 require("json")
 require_relative("./../test_helper.rb")
 
-unless ENV["NATURAL_LANGUAGE_UNDERSTANDING_USERNAME"].nil? || ENV["NATURAL_LANGUAGE_UNDERSTANDING_PASSWORD"].nil?
+if !ENV["NATURAL_LANGUAGE_UNDERSTANDING_USERNAME"].nil? && !ENV["NATURAL_LANGUAGE_UNDERSTANDING_PASSWORD"].nil?
   # Integration tests for the Natural Language Understanding V1 Service
   class NaturalLanguageUnderstandingV1Test < Minitest::Test
     def test_text_analyze
@@ -98,4 +98,10 @@ def test_list_models
       assert((200..299).cover?(service_response.status))
     end
   end
+else
+  class NaturalLanguageUnderstandingV1Test < Minitest::Test
+    def test_missing_credentials_skip_integration
+      skip "Skip natural language understanding integration tests because credentials have not been provided"
+    end
+  end
 end

test/integration/test_personality_insights_v3.rb

@@ -3,7 +3,7 @@
 require("json")
 require_relative("./../test_helper.rb")
 
-unless ENV["PERSONALITY_INSIGHTS_USERNAME"].nil? || ENV["PERSONALITY_INSIGHTS_PASSWORD"].nil?
+if !ENV["PERSONALITY_INSIGHTS_USERNAME"].nil? && !ENV["PERSONALITY_INSIGHTS_PASSWORD"].nil?
   # Integration tests for the Personality Insights V3 Service
   class PersonalityInsightsV3Test < Minitest::Test
     def test_plain_to_json
@@ -94,4 +94,10 @@ def test_plain_to_json_es
       assert((200..299).cover?(service_response.status))
     end
   end
+else
+  class PersonalityInsightsV3Test < Minitest::Test
+    def test_missing_credentials_skip_integration
+      skip "Skip personality insights integration tests because credentials have not been provided"
+    end
+  end
 end

test/integration/test_speech_to_text_v1.rb

@@ -22,7 +22,7 @@ def on_inactivity_timeout(*)
   end
 end
 
-unless ENV["SPEECH_TO_TEXT_USERNAME"].nil? || ENV["SPEECH_TO_TEXT_PASSWORD"].nil?
+if !ENV["SPEECH_TO_TEXT_USERNAME"].nil? && !ENV["SPEECH_TO_TEXT_PASSWORD"].nil?
   # Integration tests for the Speech to Text V1 Service
   class SpeechToTextV1Test < Minitest::Test
     include Minitest::Hooks
@@ -250,4 +250,10 @@ def test_add_word
       )
     end
   end
+else
+  class SpeechToTextV1Test < Minitest::Test
+    def test_missing_credentials_skip_integration
+      skip "Skip speech to text integration tests because credentials have not been provided"
+    end
+  end
 end

test/integration/test_text_to_speech_v1.rb

@@ -3,7 +3,7 @@
 require_relative("./../test_helper.rb")
 require("minitest/hooks/test")
 
-unless ENV["TEXT_TO_SPEECH_USERNAME"].nil? || ENV["TEXT_TO_SPEECH_PASSWORD"].nil?
+if !ENV["TEXT_TO_SPEECH_USERNAME"].nil? && !ENV["TEXT_TO_SPEECH_PASSWORD"].nil?
   # Integration tests for the Text to Speech V1 Service
   class TextToSpeechV1Test < Minitest::Test
     include Minitest::Hooks
@@ -81,4 +81,10 @@ def test_custom_words
       )
     end
   end
+else
+  class TextToSpeechV1Test < Minitest::Test
+    def test_missing_credentials_skip_integration
+      skip "Skip text to speech integration tests because credentials have not been provided"
+    end
+  end
 end