extract noTimestamps function, give error a name

Author: nfriedly

speech-to-text/no-timestamps.js

@@ -0,0 +1,13 @@
+/**
+ * Returns true if the result is missing it's timestamps
+ * @param {Object} data
+ * @returns {Boolean}
+ */
+module.exports = function noTimestamps(data) {
+  return data.results.some(function(result) {
+    var alt = result.alternatives && result.alternatives[0];
+    return !!(alt && (alt.transcript.trim() && !alt.timestamps || !alt.timestamps.length));
+  });
+};
+
+module.exports.ERROR_NO_TIMESTAMPS = 'NO_TIMESTAMPS';

speech-to-text/timing-stream.js

@@ -4,6 +4,7 @@ var Duplex = require('stream').Duplex;
 var util = require('util');
 var clone = require('clone');
 var defaults = require('defaults');
+var noTimestamps = require('./no-timestamps');
 
 /**
  * Slows results down to no faster than real time.
@@ -234,17 +235,6 @@ TimingStream.prototype.checkForEnd = function() {
   }
 };
 
-/**
- * Returns true if the result is missing it's timestamps
- * @param {Object} data
- * @returns {Boolean}
- */
-function noTimestamps(data) {
-  return data.results.some(function(result) {
-    var alt = result.alternatives && result.alternatives[0];
-    return !!(alt && (alt.transcript.trim() && !alt.timestamps || !alt.timestamps.length));
-  });
-}
 
 /**
  * Creates a new result with all transcriptions formatted
@@ -253,8 +243,9 @@ function noTimestamps(data) {
  */
 TimingStream.prototype.handleResult = function handleResult(data) {
   if (noTimestamps(data)) {
-    this.emit('error', new Error('TimingStream requires timestamps'));
-    return;
+    var err = new Error('TimingStream requires timestamps');
+    err.name = noTimestamps.ERROR_NO_TIMESTAMPS;
+    return this.emit('error', err);
   }
 
   // http://www.ibm.com/watson/developercloud/speech-to-text/api/v1/#SpeechRecognitionEvent

test/timing-stream-spec.js

@@ -3,7 +3,7 @@
 var assert = require('assert');
 var sinon = require('sinon');
 var PassThrough = require('stream').PassThrough;
-
+var clone = require('clone');
 var TimingStream = require('../speech-to-text/timing-stream.js');
 
 var results = require('./resources/results.json');
@@ -273,4 +273,20 @@ describe('TimingStream', function() {
     });
   });
 
+  it('should error if given results with no timestamps', function(done) {
+    var noTimestamps = require('../speech-to-text/no-timestamps');
+    assert(noTimestamps.ERROR_NO_TIMESTAMPS, 'noTimestamps.ERROR_NO_TIMESTAMPS should be defined');
+    var stream = new TimingStream({objectMode: true});
+    var data = clone(require('./resources/results.json'));
+    delete data.results[0].alternatives[0].timestamps;
+    stream.on('data', function(data) {
+      assert.fail(data, undefined, "data emitted")
+    });
+    stream.on('error', function(err) {
+      assert.equal(err.name, noTimestamps.ERROR_NO_TIMESTAMPS);
+      done();
+    });
+    stream.end(data);
+  });
+
 });