fixing a bug where timing stream would loose the result_index

Author: nfriedly

speech-to-text/timing-stream.js

@@ -182,7 +182,7 @@ function getEnd(msg) {
 
 TimingStream.prototype.tickSpeakerLables = function tickSpeakerLabels() {
   clearTimeout(this.nextSpeakerLabelsTick);
-  if (getEnd(this.speakerLabels[0]) <= this.cutoff()) {
+  while (this.speakerLabels.length && getEnd(this.speakerLabels[0]) <= this.cutoff()) {
     this.push(this.speakerLabels.shift());
   }
   if (this.speakerLabels.length) {
@@ -253,7 +253,7 @@ TimingStream.prototype.handleResult = function handleResult(data) {
   }
 
   // http://www.ibm.com/watson/developercloud/speech-to-text/api/v1/#SpeechRecognitionEvent
-  var index = data.results[0].result_index;
+  var index = data.result_index;
 
   // process each result individually
   data.results.forEach(function(result) {
@@ -268,9 +268,12 @@ TimingStream.prototype.handleResult = function handleResult(data) {
     }
 
     // in case this data object had multiple results in it
-    var newData = clone(data);
-    data.results = [result];
-    data.result_index = index;
+    var newData = {
+      results: [result],
+      result_index: index
+    };
+
+    index++;
 
     if (result.final) {
       // then add it to the final results array
@@ -281,7 +284,6 @@ TimingStream.prototype.handleResult = function handleResult(data) {
       this.interim.push(newData);
     }
 
-    index++;
   }, this);
 
   this.tick();

test/timing-stream-spec.js

@@ -7,7 +7,7 @@ var clone = require('clone');
 var TimingStream = require('../speech-to-text/timing-stream.js');
 
 var results = require('./resources/results.json');
-var messageStream = require('./resources/car_loan_stream.json');
+var messages = require('./resources/car_loan_stream.json');
 
 describe('TimingStream', function() {
 
@@ -171,22 +171,19 @@ describe('TimingStream', function() {
     });
     stream.on('error', done);
 
-    messageStream.forEach(function(msg) {
+    messages.forEach(function(msg) {
       if (msg.results) {
         stream.write(msg);
       }
     });
+    stream.end();
 
-    var numTicks = 37.26 * 1000;
-
-    for (var i = 0; i < numTicks; i++) {
-      clock.tick(1);
-    }
+    clock.tick(37.26 * 1000);
 
     nextTick(function() { // write is always async (?)
-
+      assert(actual.length);
       actual.reduce(function(lastIndex, msg) {
-        assert.equal(msg.result_index, lastIndex);
+        assert.equal(msg.result_index, lastIndex, "wrong index on result, expecting " + lastIndex + " got " + JSON.stringify(msg, null, 2));
         // index should always increment after a final message
         return (msg.results[0].final) ? lastIndex + 1 : lastIndex;
       }, 0);
@@ -203,15 +200,12 @@ describe('TimingStream', function() {
     });
     stream.on('error', done);
 
-    messageStream.forEach(function(msg) {
+    messages.forEach(function(msg) {
       stream.write(msg);
     });
+    stream.end();
 
-    var numTicks = 37.26 * 1000;
-
-    for (var i = 0; i < numTicks; i++) {
-      clock.tick(1);
-    }
+    clock.tick(37.26 * 1000);
 
     nextTick(function() { // write is always async (?)
 
@@ -245,17 +239,13 @@ describe('TimingStream', function() {
     });
     stream.on('error', done);
 
-    messageStream.forEach(function(msg) {
+    messages.forEach(function(msg) {
       if (msg.results) {
         stream.write(msg);
       }
     });
 
-    var numTicks = 37.26 * 1000;
-
-    for (var i = 0; i < numTicks; i++) {
-      clock.tick(1);
-    }
+    clock.tick(37.26 * 1000);
 
     nextTick(function() { // write is always async (?)