Skip to content

Commit 82722d5

Browse files
committed
add delete timeout, restructure integration tests
1 parent 0c4a062 commit 82722d5

File tree

2 files changed

+233
-165
lines changed

2 files changed

+233
-165
lines changed

Scripts/Services/Discovery/v1/Discovery.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ public class Discovery : IWatsonService
4444
private const string SERVICE_ENVIRONMENT_COLLECTION_DOCUMENTS = "/v1/environments/{0}/collections/{1}/documents";
4545
private const string SERVICE_ENVIRONMENT_COLLECTION_DOCUMENT = "/v1/environments/{0}/collections/{1}/documents/{2}";
4646
private const string SERVICE_ENVIRONMENT_COLLECTION_QUERY = "/v1/environments/{0}/collections/{1}/query";
47+
48+
private const float DELETE_TIMEOUT = 30f;
4749
#endregion
4850

4951
#region Public Types
@@ -271,6 +273,7 @@ private void OnGetEnvironmentResponse(RESTConnector.Request req, RESTConnector.R
271273
req.Parameters["version"] = DiscoveryVersion.Version;
272274
req.OnResponse = OnDeleteEnvironmentResponse;
273275
req.Delete = true;
276+
req.Timeout = DELETE_TIMEOUT;
274277

275278
RESTConnector connector = RESTConnector.GetConnector(SERVICE_ID, string.Format(SERVICE_ENVIRONMENT, environmentID));
276279
if (connector == null)
@@ -542,6 +545,7 @@ private void OnGetConfigurationResponse(RESTConnector.Request req, RESTConnector
542545
req.Parameters["version"] = DiscoveryVersion.Version;
543546
req.OnResponse = OnDeleteConfigurationResponse;
544547
req.Delete = true;
548+
req.Timeout = DELETE_TIMEOUT;
545549

546550
RESTConnector connector = RESTConnector.GetConnector(SERVICE_ID, string.Format(SERVICE_ENVIRONMENT_CONFIGURATION, environmentID, configurationID));
547551
if (connector == null)
@@ -946,6 +950,7 @@ private void OnGetCollectionResponse(RESTConnector.Request req, RESTConnector.Re
946950
req.Parameters["version"] = DiscoveryVersion.Version;
947951
req.OnResponse = OnDeleteCollectionResponse;
948952
req.Delete = true;
953+
req.Timeout = DELETE_TIMEOUT;
949954

950955
RESTConnector connector = RESTConnector.GetConnector(SERVICE_ID, string.Format(SERVICE_ENVIRONMENT_COLLECTION, environmentID, collectionID));
951956
if (connector == null)
@@ -1271,6 +1276,7 @@ private void OnAddDocumentResponse(RESTConnector.Request req, RESTConnector.Resp
12711276
req.Parameters["version"] = DiscoveryVersion.Version;
12721277
req.OnResponse = OnDeleteDocumentResponse;
12731278
req.Delete = true;
1279+
req.Timeout = DELETE_TIMEOUT;
12741280

12751281
RESTConnector connector = RESTConnector.GetConnector(SERVICE_ID, string.Format(SERVICE_ENVIRONMENT_COLLECTION_DOCUMENT, environmentID, collectionID, documentID));
12761282
if (connector == null)

0 commit comments

Comments
 (0)