refactor: hand written changes and more integration tests

Author: mamoonraja

Scripts/Services/LanguageTranslator/V3/LanguageTranslatorService.cs

@@ -795,6 +795,8 @@ public bool TranslateDocument(Callback<DocumentStatus> callback, System.IO.Memor
                 throw new ArgumentNullException("`callback` is required for `TranslateDocument`");
             if (file == null)
                 throw new ArgumentNullException("`file` is required for `TranslateDocument`");
+            if (filename == null)
+                throw new ArgumentNullException("`filename` is required for `TranslateDocument`");
 
             RequestObject<DocumentStatus> req = new RequestObject<DocumentStatus>
             {

Scripts/Services/SpeechToText/V1/Model/SpeechRecognitionAlternative.cs

@@ -42,14 +42,14 @@ public class SpeechRecognitionAlternative
         /// `[[\"hello\",0.0,1.2],[\"world\",1.2,2.5]]`. Timestamps are returned only for the best alternative.
         /// </summary>
         [JsonProperty("timestamps", NullValueHandling = NullValueHandling.Ignore)]
-        public List<string> Timestamps { get; set; }
+        public string[][] Timestamps { get; set; }
         /// <summary>
         /// A confidence score for each word of the transcript as a list of lists. Each inner list consists of two
         /// elements: the word and its confidence score in the range of 0.0 to 1.0, for example:
         /// `[[\"hello\",0.95],[\"world\",0.866]]`. Confidence scores are returned only for the best alternative and
         /// only with results marked as final.
         /// </summary>
         [JsonProperty("word_confidence", NullValueHandling = NullValueHandling.Ignore)]
-        public List<string> WordConfidence { get; set; }
+        public string[][] WordConfidence { get; set; }
     }
 }

Tests/LanguageTranslatorV3IntegrationTests.cs

@@ -33,6 +33,7 @@ public class LanguageTranslatorV3IntegrationTests
         private string versionDate = "2019-02-13";
         private string forcedGlossaryFilepath;
         private string translateDocumentPath;
+        private string documentId;
         private string englishText = "Where is the library?";
         private string spanishText = "¿Dónde está la biblioteca?";
         private string englishToSpanishModel = "en-es";
@@ -266,14 +267,15 @@ public IEnumerator TestTranslateDocument()
                     service.TranslateDocument(
                         callback: (DetailedResponse<DocumentStatus> response, IBMError error) =>
                         {
-                            Log.Debug("LanguageTranslatorServiceV3IntegrationTests", "Translate result: {0}", response.Response);
+                            Log.Debug("LanguageTranslatorServiceV3IntegrationTests", "Translate Document result: {0}", response.Response);
                             documentStatus = response.Result;
                             Assert.IsNotNull(documentStatus);
                             Assert.IsNotNull(documentStatus.DocumentId);
+                            documentId = documentStatus.DocumentId;
                             Assert.IsNull(error);
                         },
                         file: ms,
-                        filename: "trabslate-document.txt",
+                        filename: "translate-document.txt",
                         modelId: "en-fr"
                     );
 
@@ -285,32 +287,71 @@ public IEnumerator TestTranslateDocument()
         #endregion
 
         #region List Documents
-        [UnityTest, Order(99)]
+        [UnityTest, Order(9)]
         public IEnumerator TestListDocuments()
         {
-            Log.Debug("LanguageTranslatorServiceV3IntegrationTests", "Attempting to Translate...");
+            Log.Debug("LanguageTranslatorServiceV3IntegrationTests", "Getting the document list...");
             DocumentList documents = null;
 
-            using (FileStream fs = File.OpenRead(translateDocumentPath))
-            {
-                using (MemoryStream ms = new MemoryStream())
+            service.ListDocuments(
+                callback: (DetailedResponse<DocumentList> response, IBMError error) =>
                 {
-                    fs.CopyTo(ms);
-                    service.ListDocuments(
-                        callback: (DetailedResponse<DocumentList> response, IBMError error) =>
-                        {
-                            Log.Debug("LanguageTranslatorServiceV3IntegrationTests", "Translate result: {0}", response.Response);
-                            documents = response.Result;
-                            Assert.IsNotNull(documents);
-                            Assert.IsNull(error);
-                        }
-                    );
-
-                    while (documents == null)
-                        yield return null;
+                    Log.Debug("LanguageTranslatorServiceV3IntegrationTests", "List Documents result: {0}", response.Response);
+                    documents = response.Result;
+                    Assert.IsNotNull(documents);
+                    Assert.IsNull(error);
                 }
-            }
+            );
+
+            while (documents == null)
+                yield return null;
         }
         #endregion
+
+        #region Get Document Status
+        [UnityTest, Order(10)]
+        public IEnumerator TestGetDocumentStatus()
+        {
+            Log.Debug("LanguageTranslatorServiceV3IntegrationTests", "Getting document status...");
+            DocumentStatus documentStatus = null;
+
+            service.GetDocumentStatus(
+                callback: (DetailedResponse<DocumentStatus> response, IBMError error) =>
+                {
+                    Log.Debug("LanguageTranslatorServiceV3IntegrationTests", "Get Document Status: {0}", response.Response);
+                    documentStatus = response.Result;
+                    Assert.IsNotNull(documentStatus);
+                    Assert.IsNull(error);
+                },
+                documentId: documentId
+            );
+
+            while (documentStatus == null)
+                yield return null;
         }
-    }
+        #endregion
+
+        #region Delete Document
+        [UnityTest, Order(99)]
+        public IEnumerator TestDeletetDocument()
+        {
+            Log.Debug("LanguageTranslatorServiceV3IntegrationTests", "Deleteing the Document...");
+            object deleteResponse = null;
+
+            service.DeleteDocument(
+                callback: (DetailedResponse<object> response, IBMError error) =>
+                {
+                    Log.Debug("LanguageTranslatorServiceV3IntegrationTests", "Delete Document result: {0}", response.Response);
+                    deleteResponse = response.Result;
+                    Assert.IsTrue(response.StatusCode == 204);
+                    Assert.IsNull(error);
+                },
+                documentId: documentId
+            );
+
+            while (deleteResponse == null)
+                yield return null;
+        }
+        #endregion
+    }
+}