Preconditions implemented with tests

Author: cardil

.gitignore

@@ -21,14 +21,9 @@ coverage
 
 # Compiled binary addons (http://nodejs.org/api/addons.html)
 build/Release
-dist
 
 # Dependency directory
 # https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git
 node_modules
-
-# Coverage
-.coverrun
-.coverdata
-reports
-debug
+target/
+dist/

LICENSE

@@ -186,7 +186,7 @@
       same "printed page" as the copyright notice for easier
       identification within third-party archives.
 
-   Copyright {yyyy} {name of copyright owner}
+   Copyright 2016 Wave Software
 
    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.
@@ -199,4 +199,3 @@
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.
-

gulpfile.js

@@ -14,36 +14,67 @@ var gutil = require('gulp-util');
 var through = require('through2');
 var globby = require('globby');
 
-var sources = ['./lib/**/*.js'];
-var testSources = ['./test/**/*.js'];
+var sources = ['lib/**/*.js'];
+var testSources = ['test/**/*.js'];
 
 gulp.task('lint', function () {
   return gulp.src(sources)
     .pipe(eslint({
       extends: 'eslint:recommended',
-      ecmaFeatures: {
-        'modules': true
-      }
+      rules: {
+        strict: 2
+      },
+      env: {
+    		node: true
+    	}
     }))
     .pipe(eslint.format())
     .pipe(eslint.failAfterError());
 });
 
-gulp.task('test', [], function (done) {
-  return gulp.src(testSources, { read: false })
+gulp.task('test', ['lint'], function (done) {
+  var prependToAll = function(path, globs) {
+    var ret = [];
+    for (var v of globs) {
+      ret.push(path + '/' + v);
+    }
+    return ret;
+  };
+  var fs = require('fs');
+  var target = 'target';
+  if (!fs.existsSync(target)) {
+    fs.mkdirSync(target);
+  }
+  var pwd = process.cwd();
+  process.chdir(target);
+  var testSrc = prependToAll('..', testSources);
+  var src = prependToAll('..', sources);
+  return gulp.src(testSrc, { read: false })
     .pipe(cover.instrument({
-        pattern: sources,
-        debugDirectory: 'debug'
+      pattern: src,
+      debugDirectory: 'debug'
     }))
     .pipe(mocha())
     .pipe(cover.gather())
-    .pipe(cover.format())
-    .pipe(gulp.dest('reports'));
+    .pipe(cover.enforce({
+      statements: 98,
+      blocks: 98,
+      lines: 98,
+    }))
+    .pipe(cover.format([
+      { reporter: 'html', outFile: 'coverage.html' },
+      { reporter: 'json', outFile: 'coverage.json' },
+      { reporter: 'lcov', outFile: 'coverage.lcov' },
+    ]))
+    .pipe(gulp.dest('reports'))
+    .on('end', function() {
+      process.chdir(pwd);
+    });
 });
 gulp.task('watch', function() {
   gulp.watch(sources.concat(testSources), ['test']);
 });
-gulp.task('build', function() {
+gulp.task('build-browser', ['test'], function() {
   // gulp expects tasks to return a stream, so we create one here.
   var bundledStream = through();
 
@@ -53,13 +84,47 @@ gulp.task('build', function() {
     .pipe(source('eid.js'))
     // the rest of the gulp task, as you would normally write it.
     // here we're copying from the Browserify + Uglify2 recipe.
+    .pipe(buffer())
+      .on('error', gutil.log)
+    .pipe(gulp.dest('dist/browser/js/'));
+
+  // "globby" replaces the normal "gulp.src" as Browserify
+  // creates it's own readable stream.
+  globby(['./lib/**/*.js']).then(function(entries) {
+    // create the Browserify instance.
+    var b = browserify({
+      entries: entries,
+      debug: true
+    });
+
+    // pipe the Browserify stream into the stream we created earlier
+    // this starts our gulp pipeline.
+    b.bundle().pipe(bundledStream);
+  }).catch(function(err) {
+    // ensure any errors from globby are handled
+    bundledStream.emit('error', err);
+  });
+
+  // finally, we return the stream, so gulp knows when this task is done.
+  return bundledStream;
+});
+gulp.task('build-minified', ['test'], function() {
+  // gulp expects tasks to return a stream, so we create one here.
+  var bundledStream = through();
+
+  bundledStream
+    // turns the output bundle stream into a stream containing
+    // the normal attributes gulp plugins expect.
+    .pipe(source('eid.min.js'))
+    // the rest of the gulp task, as you would normally write it.
+    // here we're copying from the Browserify + Uglify2 recipe.
     .pipe(buffer())
     .pipe(sourcemaps.init({loadMaps: true}))
       // Add gulp plugins to the pipeline here.
       .pipe(uglify())
       .on('error', gutil.log)
     .pipe(sourcemaps.write('./'))
-    .pipe(gulp.dest('./dist/js/'));
+    .pipe(gulp.dest('dist/browser/js/'));
 
   // "globby" replaces the normal "gulp.src" as Browserify
   // creates it's own readable stream.
@@ -81,4 +146,5 @@ gulp.task('build', function() {
   // finally, we return the stream, so gulp knows when this task is done.
   return bundledStream;
 });
+gulp.task('build', ['build-minified', 'build-browser']);
 gulp.task('default', ['lint', 'test', 'build']);

lib/eid.js

@@ -1,6 +1,21 @@
-'use strict';
+/*
+ * Copyright 2016 Wave Software
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 
-var Eid = (function() {
+(function(module) {
+'use strict';
 
 function JFormatter(format) {
   this.format = function(arr) {
@@ -235,7 +250,6 @@ Eid.getMessageFormat = function() {
   return EidInternal.messageFormat;
 };
 
-return Eid;
-})();
-
 module.exports = Eid;
+
+})(module);

lib/eid/exceptions.js

@@ -1,14 +1,31 @@
-'use strict';
+/*
+ * Copyright 2016 Wave Software
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 
-var Eid = require('../eid');
-var commonExConstructor = function(eid, message) {
-  if (!(eid instanceof Eid)) {
-    eid = new Eid(eid.toString());
+(function(exports) {
+  'use strict';
+
+  var Eid = require('../eid');
+  var commonExConstructor = function(eid, message) {
+    if (!(eid instanceof Eid)) {
+      eid = new Eid(eid.toString());
+    }
+    this.message = message !== undefined ? (eid + " " + message) : eid;
+    this.eid = eid;
   }
-  this.message = message !== undefined ? (eid + " " + message) : eid;
-  this.eid = eid;
-}
-var EidRuntimeException = (function() {
+
   /**
    * <strong>This class shouldn't be used in any public API or library.</strong> It is designed to be used for in-house development
    * of end user applications which will report Bugs in standardized error pages or post them to issue tracker.
@@ -32,10 +49,7 @@ var EidRuntimeException = (function() {
     commonExConstructor.apply(this, [eid, message]);
   }
   EidRuntimeException.prototype = new Error();
-  return EidRuntimeException;
-})();
 
-var EidNullPointerException = (function() {
   /**
    * <strong>This class shouldn't be used in any public API or library.</strong> It is designed to be used for in-house development
    * of end user applications which will report Bugs in standardized error pages or post them to issue tracker.
@@ -54,10 +68,7 @@ var EidNullPointerException = (function() {
     commonExConstructor.apply(this, [eid, message]);
   }
   EidNullPointerException.prototype = EidRuntimeException.prototype;
-  return EidNullPointerException;
-})();
 
-var EidIllegalArgumentException = (function() {
   /**
    * <strong>This class shouldn't be used in any public API or library.</strong> It is designed to be used for in-house development
    * of end user applications which will report Bugs in standardized error pages or post them to issue tracker.
@@ -76,10 +87,7 @@ var EidIllegalArgumentException = (function() {
     commonExConstructor.apply(this, [eid, message]);
   }
   EidIllegalArgumentException.prototype = EidRuntimeException.prototype;
-  return EidIllegalArgumentException;
-})();
 
-var EidIllegalStateException = (function() {
   /**
    * <strong>This class shouldn't be used in any public API or library.</strong> It is designed to be used for in-house development
    * of end user applications which will report Bugs in standardized error pages or post them to issue tracker.
@@ -98,10 +106,7 @@ var EidIllegalStateException = (function() {
     commonExConstructor.apply(this, [eid, message]);
   }
   EidIllegalStateException.prototype = EidRuntimeException.prototype;
-  return EidIllegalStateException;
-})();
 
-var EidIndexOfOfBoundsException = (function() {
   /**
    * <strong>This class shouldn't be used in any public API or library.</strong> It is designed to be used for in-house development
    * of end user applications which will report Bugs in standardized error pages or post them to issue tracker.
@@ -115,16 +120,16 @@ var EidIndexOfOfBoundsException = (function() {
    * @see EidRuntimeException
    * @author Krzysztof Suszyński <[email protected]>
    */
-  function EidIndexOfOfBoundsException(eid, message) {
-    this.name = 'EidIndexOfOfBoundsException';
+  function EidIndexOutOfBoundsException(eid, message) {
+    this.name = 'EidIndexOutOfBoundsException';
     commonExConstructor.apply(this, [eid, message]);
   }
-  EidIndexOfOfBoundsException.prototype = EidRuntimeException.prototype;
-  return EidIndexOfOfBoundsException;
-})();
+  EidIndexOutOfBoundsException.prototype = EidRuntimeException.prototype;
+
+  exports.EidRuntimeException = EidRuntimeException;
+  exports.EidNullPointerException = EidNullPointerException;
+  exports.EidIllegalArgumentException = EidIllegalArgumentException;
+  exports.EidIllegalStateException = EidIllegalStateException;
+  exports.EidIndexOutOfBoundsException = EidIndexOutOfBoundsException;
 
-exports.EidRuntimeException = EidRuntimeException;
-exports.EidNullPointerException = EidNullPointerException;
-exports.EidIllegalArgumentException = EidIllegalArgumentException;
-exports.EidIllegalStateException = EidIllegalStateException;
-exports.EidIndexOfOfBoundsException = EidIndexOfOfBoundsException;
+})(exports);