Skip to content

Commit 71f6306

Browse files
Resolve tests
1 parent 4925046 commit 71f6306

File tree

2 files changed

+26
-9
lines changed

2 files changed

+26
-9
lines changed

src/class-tiny-image.php

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,18 @@ public function mark_as_compressed() {
487487

488488
$conversion_enabled = $this->settings->get_conversion_enabled();
489489

490-
foreach ( $this->sizes as $size ) {
490+
$active_tinify_sizes = $this->settings->get_active_tinify_sizes();
491+
492+
if ( $this->settings->get_conversion_enabled() ) {
493+
$uncompressed_sizes = $this->filter_image_sizes( 'uncompressed', $active_tinify_sizes );
494+
$unconverted_sizes = $this->filter_image_sizes( 'unconverted', $active_tinify_sizes );
495+
496+
$unprocessed_sizes = $uncompressed_sizes + $unconverted_sizes;
497+
} else {
498+
$unprocessed_sizes = $this->filter_image_sizes( 'uncompressed', $active_tinify_sizes );
499+
}
500+
501+
foreach ( $unprocessed_sizes as $size ) {
491502
$size->mark_as_compressed( $conversion_enabled );
492503
}
493504

test/integration/compression.spec.ts

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,11 @@ test.describe('compression', () => {
142142

143143
test('button in edit screen should compress images', async () => {
144144
await setAPIKey(page, '');
145-
await setCompressionTiming(page, 'auto');
145+
await setCompressionTiming(page, 'manual');
146146
await enableCompressionSizes(page, ['medium', 'large']);
147-
await uploadMedia(page, 'input-example.jpg');
148147
await setAPIKey(page, 'JPG123');
148+
149+
await uploadMedia(page, 'input-example.jpg');
149150

150151
await page.goto('/wp-admin/upload.php');
151152

@@ -494,27 +495,32 @@ test.describe('compression', () => {
494495
});
495496

496497
test('will mark a single attachment as compressed', async () => {
497-
await uploadMedia(page, 'input-example.jpg');
498+
await setAPIKey(page, 'JPG123');
498499
await setCompressionTiming(page, 'manual');
500+
await enableCompressionSizes(page, ['0', 'medium']);
501+
await uploadMedia(page, 'input-example.jpg');
499502

500503
await page.goto('/wp-admin/upload.php');
501504

502505
await page.getByRole('button', { name: 'Mark as Compressed' }).click();
503-
await expect(page.getByText('5 sizes compressed')).toBeVisible();
504-
await expect(page.getByText('5 sizes converted')).toBeVisible();
506+
await expect(page.getByText('2 sizes compressed')).toBeVisible();
507+
await expect(page.getByText('2 sizes converted')).toBeVisible();
505508
});
506509

507510
test('will mark multiple attachments as compressed', async () => {
511+
await setAPIKey(page, 'JPG123');
512+
await setCompressionTiming(page, 'manual');
513+
await enableCompressionSizes(page, ['0', 'medium']);
514+
508515
await uploadMedia(page, 'input-example.jpg');
509516
await uploadMedia(page, 'input-example.png');
510-
await setCompressionTiming(page, 'manual');
511517

512518
await page.goto('/wp-admin/upload.php');
513519

514520
await page.locator('#cb-select-all-1').check();
515521
await page.locator('#bulk-action-selector-top').selectOption('tiny_bulk_mark_compressed');
516522
await page.locator('#doaction').click();
517-
await expect(page.getByText('5 sizes compressed')).toBeVisible();
518-
await expect(page.getByText('5 sizes converted')).toBeVisible();
523+
await expect(page.getByText('2 sizes compressed')).toBeVisible();
524+
await expect(page.getByText('2 sizes converted')).toBeVisible();
519525
});
520526
});

0 commit comments

Comments
 (0)