Skip to content

Commit 1ac04c7

Browse files
authored
Demos - Enable lint in CI (DevExpress#31014)
1 parent ba99766 commit 1ac04c7

File tree

6 files changed

+4
-97
lines changed

6 files changed

+4
-97
lines changed

.github/workflows/demos_visual_tests_frameworks.yml

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -234,30 +234,14 @@ jobs:
234234
# run: pnpm run ts-check-react
235235

236236
lint:
237-
name: ${{ matrix.name }}
237+
name: Lint code base
238238
needs:
239239
- build-devextreme
240240
- get-changes
241241

242242
runs-on: ubuntu-22.04
243243
timeout-minutes: 60
244244

245-
strategy:
246-
fail-fast: false
247-
matrix:
248-
include:
249-
- name: Lint code base (excluding demos)
250-
command: pnpx nx lint-non-demos
251-
# NOTE: skipped due to enormous number of errors
252-
# - name: Lint demos (1/4)
253-
# command: CONSTEL=1/4 npm run lint-demos
254-
# - name: Lint demos (2/4)
255-
# command: CONSTEL=2/4 npm run lint-demos
256-
# - name: Lint demos (3/4)
257-
# command: CONSTEL=3/4 npm run lint-demos
258-
# - name: Lint demos (4/4)
259-
# command: CONSTEL=4/4 npm run lint-demos
260-
261245
steps:
262246
- name: Get sources
263247
uses: actions/checkout@v4
@@ -319,7 +303,7 @@ jobs:
319303
env:
320304
CHANGEDFILEINFOSPATH: changed-files.json
321305
DEBUG: 'eslint:cli-engine,stylelint:standalone'
322-
run: ${{ matrix.command }}
306+
run: pnpx nx lint
323307

324308
check_generated_demos:
325309
name: ${{ matrix.name }}

apps/demos/Demos/SelectBox/Overview/React/Field.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
import React from 'react';
2-
import TextBox from 'devextreme-react/text-box';
3-
4-
const nameLabel = { 'aria-label': 'Name' };
52

63
export default function Field(data: { ImageSrc: any; Name: any }) {
74
return (

apps/demos/Demos/SelectBox/Overview/ReactJs/Field.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import React from 'react';
22

3-
const nameLabel = { 'aria-label': 'Name' };
43
export default function Field(data) {
54
return (
65
<div className="custom-addon">

apps/demos/Demos/SelectBox/Overview/jQuery/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ $(() => {
4848
const result = $(`<div class="custom-addon"><img alt="Product name" src="${src}"/></div>`);
4949

5050
return result;
51-
}
51+
},
5252
},
5353
itemTemplate(data) {
5454
return `<div class='custom-item'><img alt='Product name' src='${

apps/demos/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@
164164
"prepare-shared": "pnpm run prepare-ts && gulp shared",
165165
"lint-html": "prettier --check .",
166166
"lint-js": "eslint . --ignore-pattern 'Demos'",
167-
"lint-demos": "ts-node utils/eslint-runner",
167+
"lint-demos": "eslint ./Demos",
168168
"lint-css": "stylelint **/*.{css,vue}",
169169
"lint-non-demos": "pnpx nx run-many -t lint-js lint-css lint-html -p devextreme-demos",
170170
"lint": "pnpm run lint-non-demos && pnpm run lint-demos",

apps/demos/utils/eslint-runner.ts

Lines changed: 0 additions & 73 deletions
This file was deleted.

0 commit comments

Comments
 (0)