Skip to content

Commit 58744d1

Browse files
authored
CardView - Card cover is not displayed even if a custom template is specified (T1298662) (DevExpress#30284)
1 parent 588f33f commit 58744d1

File tree

3 files changed

+19
-4
lines changed

3 files changed

+19
-4
lines changed

packages/devextreme/js/__internal/grids/new/card_view/content_view/content/card/card.test.tsx

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,15 +107,30 @@ describe('Card Header', () => {
107107
});
108108
});
109109

110-
describe('Image', () => {
111-
it('should render the image correctly', () => {
110+
describe('Cover', () => {
111+
it('should be rendered', () => {
112112
const container = document.createElement('div');
113113
// @ts-expect-error
114114
render(<Card {...props} />, container);
115115

116116
const image = container.querySelector('img');
117117
expect(image).not.toBeNull();
118118
});
119+
120+
it('should be rendered if imageExpr is not defined but template is defined', () => {
121+
const container = document.createElement('div');
122+
const localProps = {
123+
...props,
124+
cover: {
125+
template: () => <img className='myTemplate'/>,
126+
},
127+
};
128+
129+
// @ts-expect-error
130+
render(<Card {...localProps} />, container);
131+
132+
expect(container.querySelector('.myTemplate')).toBeTruthy();
133+
});
119134
});
120135

121136
describe('Field Template', () => {

packages/devextreme/js/__internal/grids/new/card_view/content_view/content/card/card.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ export class Card extends Component<CardProps> {
144144
[CLASSES.selectCard]: !!card.isSelected,
145145
});
146146

147-
const hasCover = !!cover?.imageExpr;
147+
const hasCover = !!cover?.imageExpr || !!cover?.template;
148148

149149
const imageSrc = cover?.imageExpr?.(this.props.card.data);
150150
const alt = cover?.altExpr?.(this.props.card.data);

packages/devextreme/js/__internal/grids/new/card_view/content_view/content/card/cover.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export class Cover extends Component<CoverProps> {
2828

2929
const containerClasses = combineClasses({
3030
[CLASSES.cover]: true,
31-
[CLASSES.noImage]: !src,
31+
[CLASSES.noImage]: !src && !Template,
3232
});
3333

3434
return (

0 commit comments

Comments
 (0)