The toggle() renderer method must accept a boolean value as an argument (DevExpress#30687) (DevExpress#30696)

Author: EugeniyKiyashko

packages/devextreme/js/__internal/m_sortable.ts

@@ -852,7 +852,6 @@ class Sortable extends Draggable {
       that._move(position, $placeholderElement);
     }
 
-    // @ts-expect-error bad toggle type
     $placeholderElement.toggle(!!position);
   }
 

packages/devextreme/js/__internal/ui/list/list.edit.decorator.switchable.ts

@@ -56,9 +56,7 @@ abstract class SwitchableEditDecorator extends EditDecorator {
     );
 
     this._list.$element()
-      // @ts-expect-error ts-error
       .append(this._$topShield.toggle(false))
-      // @ts-expect-error ts-error
       .append(this._$bottomShield.toggle(false));
   }
 
@@ -89,16 +87,13 @@ abstract class SwitchableEditDecorator extends EditDecorator {
     this._animateToggleDelete($itemElement, isReadyToDelete);
   }
 
-  // eslint-disable-next-line class-methods-use-this
   _isReadyToDelete($itemElement: dxElementWrapper): boolean {
     return $itemElement.hasClass(SWITCHABLE_DELETE_READY_CLASS);
   }
 
   _toggleShields($itemElement: dxElementWrapper, enabled: boolean): void {
     this._list.$element().toggleClass(SWITCHABLE_MENU_SHIELD_POSITIONING_CLASS, enabled);
-    // @ts-expect-error ts-error
     this._$topShield.toggle(enabled);
-    // @ts-expect-error ts-error
     this._$bottomShield.toggle(enabled);
     if (enabled) {
       this._updateShieldsHeight($itemElement);

packages/devextreme/js/__internal/ui/m_progress_bar.ts

@@ -153,10 +153,8 @@ class ProgressBar extends TrackBar<ProgressBarProperties> {
   _toggleIndeterminateState(value: boolean): void {
     if (value) {
       this._renderIndeterminateState();
-      // @ts-expect-error ts-error
       this._$bar.toggle(false);
     } else {
-      // @ts-expect-error ts-error
       this._$bar.toggle(true);
       this._$segmentContainer?.remove();
       delete this._$segmentContainer;

packages/devextreme/js/__internal/ui/menu/menu.ts

@@ -443,9 +443,7 @@ class Menu extends MenuBase<MenuProperties> {
     }
 
     this._setAriaRole(isAdaptive);
-    // @ts-expect-error ts-error
     $menuItemsContainer.toggle(!isAdaptive);
-    // @ts-expect-error ts-error
     $adaptiveElements.toggle(isAdaptive);
   }
 

packages/devextreme/js/__internal/ui/scroll_view/scroll_view.native.swipe_down.ts

@@ -265,7 +265,6 @@ class SwipeDownNativeScrollViewStrategy<
   }
 
   pullDownEnable(enabled: boolean): void {
-    // @ts-expect-error ts-error
     this._$topPocket.toggle(enabled);
     this._pullDownEnabled = enabled;
   }

packages/devextreme/js/__internal/ui/scroll_view/scroll_view.ts

@@ -260,7 +260,6 @@ export class ScrollView extends Scrollable<ScrollViewProperties> {
     }
 
     if (this._$pullDown && this._strategy) {
-      // @ts-expect-error ts-error
       this._$pullDown.toggle(enabled);
       this._strategy.pullDownEnable(enabled);
       this._pullDownEnabled = enabled;
@@ -274,7 +273,6 @@ export class ScrollView extends Scrollable<ScrollViewProperties> {
     }
 
     if (this._$reachBottom && this._strategy) {
-      // @ts-expect-error ts-error
       this._$reachBottom.toggle(enabled);
       this._strategy.reachBottomEnable(enabled);
       this._reachBottomEnabled = enabled;

packages/devextreme/js/__internal/ui/tree_view/tree_view.base.ts

@@ -1258,9 +1258,7 @@ class TreeViewBase extends HierarchicalCollectionWidget<TreeViewBaseProperties,
     $collapseIcon: dxElementWrapper,
     isNodeExpanded: boolean | undefined,
   ): void {
-    // @ts-expect-error ts-error
     $collapseIcon.toggle(isNodeExpanded);
-    // @ts-expect-error ts-error
     $expandIcon.toggle(!isNodeExpanded);
   }
 

packages/devextreme/js/core/renderer.d.ts

@@ -116,7 +116,7 @@ export interface dxElementWrapper {
 
   toArray(): Element[];
 
-  toggle(value: string | undefined): this;
+  toggle(value?: boolean | string): this;
 
   toggleClass(className: string, value?: boolean): this;
 

packages/devextreme/ts/dx.all.d.ts

@@ -6899,7 +6899,7 @@ declare module DevExpress.core {
 
     toArray(): Element[];
 
-    toggle(value: string | undefined): this;
+    toggle(value?: boolean | string): this;
 
     toggleClass(className: string, value?: boolean): this;