fix(localization): correctly format number with escaped semicolon (T1275922) (DevExpress#29020)

Author: chaosmirage

packages/devextreme/js/common/core/localization/intl/number.js

@@ -90,7 +90,9 @@ export default {
             return getFormatter(format)(value);
         }
 
-        return this.callBase.apply(this, arguments);
+        const result = this.callBase.apply(this, arguments);
+
+        return result;
     },
     _getCurrencySymbolInfo: function(currency) {
         const formatter = getCurrencyFormatter(currency);

packages/devextreme/js/common/core/localization/ldml/number.js

@@ -19,8 +19,36 @@ function getGroupSizes(formatString) {
     });
 }
 
+function splitSignParts(format, separatorChar = ';', escapingChar = ESCAPING_CHAR) {
+    const parts = [];
+    let currentPart = '';
+    let state = 'searchingSeparator';
+
+    for(let i = 0; i < format.length; i++) {
+        const char = format[i];
+        if(state === 'searchingSeparator' && char === escapingChar) {
+            state = 'skippingSeparationInsideEscaping';
+        } else if(state === 'skippingSeparationInsideEscaping' && char === escapingChar) {
+            state = 'searchingSeparator';
+        } else if(state === 'searchingSeparator' && char === separatorChar) {
+            state = 'separating';
+            parts.push(currentPart);
+            currentPart = '';
+        }
+
+        if(state !== 'separating') {
+            currentPart += char;
+        } else {
+            state = 'searchingSeparator';
+        }
+    }
+    parts.push(currentPart);
+
+    return parts;
+}
+
 function getSignParts(format) {
-    const signParts = format.split(';');
+    const signParts = splitSignParts(format);
 
     if(signParts.length === 1) {
         signParts.push('-' + signParts[0]);
@@ -38,7 +66,7 @@ function isPercentFormat(format) {
 }
 
 function removeStubs(str) {
-    return str.replace(/'.+'/g, '');
+    return str.replace(/'[^']*'/g, '');
 }
 
 function getNonRequiredDigitCount(floatFormat) {

packages/devextreme/js/common/core/localization/number.js

@@ -287,7 +287,12 @@ const numberLocalization = dependencyInjector({
         if(!numberConfig) {
             const formatterConfig = this._getSeparators();
             formatterConfig.unlimitedIntegerDigits = format.unlimitedIntegerDigits;
-            return this.convertDigits(getFormatter(format.type, formatterConfig)(value));
+
+            const formatter = getFormatter(format.type, formatterConfig)(value);
+
+            const result = this.convertDigits(formatter);
+
+            return result;
         }
 
         return this._formatNumber(value, numberConfig, format);

packages/devextreme/testing/tests/DevExpress.localization/ldml.tests.js

@@ -228,6 +228,16 @@ QUnit.module('number formatter', () => {
         assert.strictEqual(getNumberFormatter('#0.00 руб\'.\'')(15), '15.00 руб.', 'special chars was escaped');
     });
 
+    QUnit.test('escaped semicolon in format', function(assert) {
+        const formatter = getNumberFormatter('\';\'plus \';\' 0;minus \';\' 0\';\'');
+
+        assert.strictEqual(formatter(-8), 'minus ; 8;', 'semicolons were escaped');
+        assert.strictEqual(formatter(8), ';plus ; 8', 'semicolons were escaped');
+
+        // T1275922
+        assert.strictEqual(getNumberFormatter('\';\'0')(8), ';8', 'semicolons were escaped');
+    });
+
     QUnit.test('percent formatting with leading zero', function(assert) {
         const formatter = getNumberFormatter('#0.#%;(#0.#%)');