Button: onClick function should be triggered when custom template is used Enter, Space keys are pressed in Angular & Vue (T1260670, T1260357) (DevExpress#29463)

Author: EugeniyKiyashko

packages/devextreme/js/renovation/ui/__tests__/button.test.tsx

@@ -330,12 +330,13 @@ describe('Button', () => {
               originalEvent,
             };
             const button = new Button({ onClick });
-            const stub = jest.fn();
 
-            button.contentRef = { current: { click: stub } } as any;
             button.keyDown(options);
             expect(options.originalEvent.preventDefault).toHaveBeenCalled();
-            expect(stub).toHaveBeenCalledTimes(1);
+            expect(onClick).toHaveBeenCalledTimes(1);
+            expect(onClick).toHaveBeenCalledWith({
+              event: options.originalEvent,
+            });
           });
 
           it('should not simulate click by common keys down', () => {

packages/devextreme/js/renovation/ui/button.tsx

@@ -241,16 +241,12 @@ export class Button extends JSXComponent(ButtonProps) {
 
     if (keyName === 'space' || which === 'space' || keyName === 'enter' || which === 'enter') {
       (originalEvent as Event).preventDefault();
-      this.emitClickEvent();
+      this.onWidgetClick(originalEvent as Event);
     }
 
     return undefined;
   }
 
-  emitClickEvent(): void {
-    this.contentRef.current!.click();
-  }
-
   get aria(): Record<string, string> {
     const { text, icon } = this.props;
 

packages/devextreme/testing/tests/DevExpress.ui.widgets/button.tests.js

@@ -388,24 +388,6 @@ QUnit.module('Button', function() {
             assert.equal(clickFired, 2, 'press space on button call click action');
         });
 
-        QUnit.test('click event is fired on "enter" press', function(assert) {
-            const $element = $('#button').dxButton({
-                focusStateEnabled: true
-            });
-            const handler = sinon.spy();
-
-            $element.on('click', handler);
-
-            const keyboard = keyboardMock($element);
-
-            $element.trigger('focusin');
-            keyboard.keyDown('enter');
-            assert.strictEqual(handler.callCount, 1, 'press enter on button call click action');
-
-            keyboard.keyDown('space');
-            assert.strictEqual(handler.callCount, 2, 'press space on button call click action');
-        });
-
         QUnit.test('arguments on key press', function(assert) {
             const clickHandler = sinon.spy();